Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6f874c0b-cea2-e835-ad1c-8cd21fb1a82e@redhat.com>
Date:   Mon, 29 Aug 2022 09:23:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] vduse: prevent uninitialized memory accesses
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, elic@nvidia.com,
        guanjun@linux.alibaba.com, parav@nvidia.com,
        gautam.dawar@xilinx.com, xieyongji@bytedance.com,
        jasowang@redhat.com, mst@redhat.com
References: <20220826161605.559317-1-maxime.coquelin@redhat.com>
 <20220827065435.GL2030@kadam>
From:   Maxime Coquelin <maxime.coquelin@redhat.com>
In-Reply-To: <20220827065435.GL2030@kadam>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/27/22 08:54, Dan Carpenter wrote:
> On Fri, Aug 26, 2022 at 06:16:05PM +0200, Maxime Coquelin wrote:
>> If the VDUSE application provides a smaller config space
>> than the driver expects, the driver may use uninitialized
>> memory from the stack.
>>
>> This patch prevents it by initializing the buffer passed by
>> the driver to store the config value.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> This sounds like it needs a Fixes tag?

Yes, I actually did it, but somehow forgot to generate the patch bedore
posting.

I'll post a v2 soon.

Thanks,
Maxime

> regards,
> dan carpenter
>