Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Namhyung Kim <namhyung@kernel.org>
CC:     Song Liu <song@kernel.org>,
        Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Add bpf_read_raw_record() helper
Thread-Topic: [PATCH bpf-next] bpf: Add bpf_read_raw_record() helper
Thread-Index: AQHYtzPeWFYcAGzsN0Wstq4jJDfNwK3AJloAgAAJpYCAAA9aAIAAO0MAgAAulQCAAAilAIAAsuMAgAAazgCAAAnxgIAADKuAgAAYuoCAAAP0AIAAA5MAgACW0gCAAzQjgA==
Date:   Mon, 29 Aug 2022 07:20:56 +0000
Message-ID: <4E6CFFD5-7048-4F64-8F16-70DD6D081ACF@fb.com>
References: <20220823210354.1407473-1-namhyung@kernel.org>
 <CAEf4Bzbd0-jGFCSCJu3eDxxom42xnH9Tevq0n50-AajjHb5t3g@mail.gmail.com>
 <A9E2E766-E8A2-4E2E-A661-922400D2674D@fb.com>
 <CAEf4BzbGf6FuM7VcnA7HKb33HJeJjrDuydC4h1_tCUB8sPCW2g@mail.gmail.com>
 <E215461A-01E7-4677-A404-C4439D66A7AF@fb.com>
 <CAM9d7cgigkU8quUMpScL=Xt8+WLDVXKiF5xdKiz7BbDPibSNjg@mail.gmail.com>
 <CAPhsuW5V1U_UTHQw9E80vCTeP4Jqg9Ta8B+7o3pybKB=8CGRFA@mail.gmail.com>
 <CAM9d7cjTtOkRHLOosxHN8PcbVbhTK=uLDGjw8N5=1QiTHcd6rQ@mail.gmail.com>
 <C7F3F33B-4A8E-428C-9FED-FB635955C2B1@fb.com>
 <FCC75F8E-4C2F-42A4-B582-9BE3BB87E15A@fb.com>
 <CAM9d7cj6YNTL+u38PZjhPF2Qg_BYiJ1NMmDkPDx3N3Xe+ZTbyA@mail.gmail.com>
 <FD49F694-10FA-4346-8303-E1E185C3E6E4@fb.com>
 <CAM9d7cjj0X90=NsvdwaLMGCDVkMJBLAGF_q-+Eqj6b44OAnzoQ@mail.gmail.com>
 <1CA3FC40-BC8D-4836-B3E7-0EB196DE6E66@fb.com>
 <CAM9d7cg-X6iobbmx3HzCz4H2c20peBVGPt3yf9m3WbqLb5H90A@mail.gmail.com>
In-Reply-To: <CAM9d7cg-X6iobbmx3HzCz4H2c20peBVGPt3yf9m3WbqLb5H90A@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UTyTdyWQ7rkVZnYxR28ajgCf6U4k880J8kNcmWYZ8x+aF2nXzgprfj5u5KBS?=
 =?us-ascii?Q?y4F/W6ILzqXvPORrmYRbaoa7VxmoFqshhZfUMdj/ZLJhBZDB98oqWge9ftMw?=
 =?us-ascii?Q?TZswA7s5+8RKCIIecM/SIAMTiK1hvmHKa1rp9ucYMHBlHQkOkCpLtNXPkYmD?=
 =?us-ascii?Q?NCamJIx0DWIaQ/H/AAnpeOyI0AaQKUYPenjNkgcJDew0ejP5sd32S30bMsXi?=
 =?us-ascii?Q?nEehSrRWoJJqee9ymJFDvZswduvyrNz/r2MupEZpvpZg9mwPdT7BzHXJU+Dc?=
 =?us-ascii?Q?imc9WHiYaSbOIajWZcIILFa9w9YFtq8GpIMGt1Av6UIren7FYymd4kqiUWFC?=
 =?us-ascii?Q?tKlbNUM3qxJtuKqcDAYxz7TUABrGGWltD4l0eWwuimysj+JneLkUIb/P0oo6?=
 =?us-ascii?Q?/SrVvutLCeekX8WLOCGXa8Aa3fOh8FXDHsGRP+ioP3ZKb106dFL0yxF3lyPI?=
 =?us-ascii?Q?xt7EQodE/BxIbQBtSV1RGpXVThStS+M9NfkliyiJpRkujSV4aDD67/mZzIrs?=
 =?us-ascii?Q?qGTQUZ7htFhIOPWaJpSXj3iqe5fJ2rb4E5UcKgO5bZPLUXD4OQBnLP+vm86v?=
 =?us-ascii?Q?tILeD0FQHIN4K6/Kb501HMh5YzsNI8i8HVTz0huy8JGJu7VdVp8EF3uVV1qZ?=
 =?us-ascii?Q?ghXYCSKEP1ddzO8WHhywqs8KRWatbwEhxZ+OwkXYnO+aeUIzrxisZD2tVh5Z?=
 =?us-ascii?Q?PFOFiAy40W7rhT0SdYcswIr3aWLOv4hgm2JowTPuCzw0QhOFmCKd+rG+xWhd?=
 =?us-ascii?Q?nPV7D0Nls8dLf+WdSPbdbz6Cqhj4uhAqpRVF5Cl86Iz8S/vfX+yN2+tgePO+?=
 =?us-ascii?Q?nw13fRGid5eG3ODqzYNuImvaq6zhvkC3Uane/l1p+qJ1L9rLFFJ58KNkg8BU?=
 =?us-ascii?Q?QKNKhc0bjRzu70LNa4un2jdS/JGuica5J4RTRMN+FOAdubTesc4z2BkO/Rok?=
 =?us-ascii?Q?BYpiZ/ycyKXbNvkKB7Pj6sEnjXwbXDEePxrozAMA5RCVVIkkeAtllvHruw8G?=
 =?us-ascii?Q?wFEX9XG+H5uRjWoasUiziWqLf+dxYwdm0xK8wIASxspP84z21N+RMHZ9RaZ6?=
 =?us-ascii?Q?yFEutCQk5nuadwcIj+38TGkju6Ul5XFBzhgbMnFzZqzVu8ycLP1n/xRHDtaR?=
 =?us-ascii?Q?UEQI1cn3jSs3MHfmxDdgyk2VD1y9NAKYKEKi5ayF2kYzpY0qn21QzDuH3c13?=
 =?us-ascii?Q?OS1Wx8qEkDUH2GFkLCRviD1u13mIroCtUP8elaBV+aJKcJbLgE5ZUGKzr7LU?=
 =?us-ascii?Q?oz7IubITX9sw9RgYG1sZwUDu2jBcrHJxknBpAMBx9A27RKK1ssVcMtknmUVR?=
 =?us-ascii?Q?jbZDEpfJXfesK4ElG3v1ZeWLOItj4aKhaXDq9nMl1BqihT9uzxtCKZs7XoB/?=
 =?us-ascii?Q?+mVx75zNBR+TIHnHAgUn/iddUvpR2ZtqBirbdBTh5R0Eyc0fH70oMsIbPLVU?=
 =?us-ascii?Q?OQ/dBdPqoTYZGCj8P+M8CQCdtw5jrzaHj8O1XXgoRA3E0W0TdOGzwmQZZ6to?=
 =?us-ascii?Q?WK3UZ4HN0D96HACKCIqSjkeUqRvfBLPtMvQBwjxMQphrj2jWPlj+zhGhb7LH?=
 =?us-ascii?Q?fSY0vDfbJvYXvw1eOUwfn1gyETg3SUV1tjr1muzPJkPJ7vqeVt6Y9zFP3/IT?=
 =?us-ascii?Q?54ESfQKmJ9S8LVubLXN7K6s=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3C5A29DB973AD6448557D80D80697B58@namprd15.prod.outlook.com>
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 385458e5-7095-49aa-5e67-08da898f03ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2022 07:20:56.4872
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ig+fSAH/ner5o0/wliYVb0JR6eVq6ljd/klexdzYam0Vl0rq5Y137kk1Y2dc+VmnWiVwjK/Ki4GP2XUS91zq6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR15MB4222
X-Proofpoint-ORIG-GUID: KJvgAUWRgP7HWkbFWT7_cNkaxfPnFwaf
X-Proofpoint-GUID: KJvgAUWRgP7HWkbFWT7_cNkaxfPnFwaf
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-29_03,2022-08-25_01,2022-06-22_01
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Aug 26, 2022, at 11:25 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> 
> On Fri, Aug 26, 2022 at 2:26 PM Song Liu <songliubraving@fb.com> wrote:
>> 
>> 
>> 
>>> On Aug 26, 2022, at 2:12 PM, Namhyung Kim <namhyung@kernel.org> wrote:
>>> 
>>> On Fri, Aug 26, 2022 at 1:59 PM Song Liu <songliubraving@fb.com> wrote:
>>>> 
>>>> 
>>>> 
>>>>> On Aug 26, 2022, at 12:30 PM, Namhyung Kim <namhyung@kernel.org> wrote:
>>>>> 
>>>>> On Fri, Aug 26, 2022 at 11:45 AM Song Liu <songliubraving@fb.com> wrote:
>>>>> 
>>>>>>> And actually, we can just read ctx->data and get the raw record,
>>>>>>> right..?
>>>>>> 
>>>>>> Played with this for a little bit. ctx->data appears to be not
>>>>>> reliable sometimes. I guess (not 100% sure) this is because we
>>>>>> call bpf program before event->orig_overflow_handler. We can
>>>>>> probably add a flag to specify we want to call orig_overflow_handler
>>>>>> first.
>>>>> 
>>>>> I'm not sure.  The sample_data should be provided by the caller
>>>>> of perf_event_overflow.  So I guess the bpf program should see
>>>>> a valid ctx->data.
>>>> 
>>>> Let's dig into this. Maybe we need some small changes in
>>>> pe_prog_convert_ctx_access.
>>> 
>>> Sure, can you explain the problem in detail and share your program?
>> 
>> I push the code to
>> 
>> https://git.kernel.org/pub/scm/linux/kernel/git/song/linux.git/log/?h=test-perf-event
>> 
>> The code is in tools/bpf/perf-test/.
>> 
>> The problem is we cannot get reliable print of data->cpu_entry in
>> /sys/kernel/tracing/trace.
> 
> Ah, right.  I've realized that the sample data is passed before full
> initialized.  Please see perf_sample_data_init().  The other members
> are initialized right before written to the ring buffer in the
> orig_overflow_handler (__perf_event_output).
> 
> That explains why pe_prog_convert_ctx_access() handles
> data and period specially.  We need to handle it first.

Thanks for confirming this. I guess we will need a helper (or kfunc) 
for the raw data. 

Shall we make it more generic that we can get other PERF_SAMPLE_*? 

Thanks,
Song