Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d74b6fc8-7d4e-89d1-1c29-843b98a30112@intel.com>
Date:   Mon, 29 Aug 2022 15:11:25 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.13.0
Subject: Re: [PATCH 1/2] tools/libs/slab.c: fix compiling mistakes of
 uatomic_inc/uatomic_dec
Content-Language: en-US
To:     Song Chen <chensong_2000@189.cn>, <karolinadrobnik@gmail.com>,
        <rppt@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
References: <1661755121-3286-1-git-send-email-chensong_2000@189.cn>
From:   "Huang, Shaoqin" <shaoqin.huang@intel.com>
In-Reply-To: <1661755121-3286-1-git-send-email-chensong_2000@189.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2dEaHlJaU1nSitDcWRrUHhsaVk0TGJJQTlwNUhDMWRKd0RMRkNIMG9VRzdj?=
 =?utf-8?B?RlBYbUpYbmVIVytteDZidGZFcHVnRGlmL2NYR0dBQmJubGc1bDNROHJpQ3lS?=
 =?utf-8?B?dnJDNWF6VWhWbU9xOFdLaHNPbnRMdnBkOTlVUkJQTWRWcHNpOVVMeDJpTnQ2?=
 =?utf-8?B?WWp2NFRjalFHc1VUTjVYSTg3M3pqTE1nRjRCTXBxQWpKNjIzVFkvdUZjOHla?=
 =?utf-8?B?dmVJUGVJVHdnNVl3WnZMcDFUZGJ0cjBwZEl4M3NibDB1N0tNbXdZcGZZRjE0?=
 =?utf-8?B?Zlk3YWFLWjMrbXM2UUJ5N1BnRXRSNXpBcjVqNDlSMGlhbUpWbWFua1AvTXkz?=
 =?utf-8?B?MDdybU5LcmdFV0RVTWdIMEZTT3h0UWJYWVpxMXBHM2xpN3NMNGVXcXdWa1Ny?=
 =?utf-8?B?a0Q4bGFCeWZBSURqTjhpNkZjbFBqeU1BT0xWQUdlUWtVZDFoSWh0UTZsZzdV?=
 =?utf-8?B?Tkl5NFJscG54bkQrczJDblFqNVR2SGJPcE00Vi9UeloybFFxK2xrWklXMUZD?=
 =?utf-8?B?SCtoMTQzOWs3RmJVZUM2Z3dtcUV5anI0MjQ5di9zb0FIaGZ5VnRoYjMrTjVD?=
 =?utf-8?B?UlJwQXFueGd2bk43VDFFdWtXa3B1cW1icnZGdFAxWjZRMkFHdGU3dGVjRTYz?=
 =?utf-8?B?YmpJaGo4a3M0M2g0L0UxR3k2ZmcrNk9VSlNWMTlHbDd1b3RvZWpoR29ZVlNu?=
 =?utf-8?B?aUszSDNIUHBvdW1zcGt1SmZQK1daWElDREFlRWNLYk5HdzFBT0lpSytRam5T?=
 =?utf-8?B?b091eGpYakpGUWhQZUpaaGFBZEh1R3l0UGtwOFVXTVVlYVorbGQ1RGFkMzE5?=
 =?utf-8?B?OVJ6UHhLRUxGUXJ2WmJ4WVFtUjI2RUpHYkZjNGNPL0lESnFlWmJhbmQwME90?=
 =?utf-8?B?ekMwOGtYaDR3U0liVGlsQzZnTXlQNGJ6bHp3VlduQVF6RzlOS2JGd2o0WWV5?=
 =?utf-8?B?aXFKOWF4NnRjNWZPaUQ0eFB2LzRrQ2E3TXluM3l6VTQ2cEZBRGpyaVBGUkVE?=
 =?utf-8?B?V3JsTzZMdTFaNngwdnpxSzFQRUJreDVtbGVURFpKZTlPTitoWmt3czF2Qkd3?=
 =?utf-8?B?SDhWV1htS0pyR2kxN1hUS2h6UWY1U0JUNzJZc3VFK0FaQnNBVk1qblBSYitX?=
 =?utf-8?B?Y3duK05hVG9iNDBtL1o4dDJDb1RDbnVBdEpyNGRIVHhvZDZWcnpsdDVtTzlI?=
 =?utf-8?B?R3hjb1MxeXNBZGRLOGlkTUNjYWd3THgyWW04N2ZVaHEwSzlPeFdac2pMeFZl?=
 =?utf-8?B?MHBSRklGRm11aElkM2lFVmp2NS8yamFWVWJLOFZ3eG1rWjE2RUEwRk5tTCtG?=
 =?utf-8?B?WlV1MTVBYVA1d0VsT3Z5QlZTZzQ4MnFZbmtDS0tnVVFKWHBxZ2NIb1R4Y2ZB?=
 =?utf-8?B?Yy9qakszL3dZenl5bkk1M2lvbkF6NjlIYXg2b2RFcTBmcEt5OURKd3BLenNm?=
 =?utf-8?B?SnhLSFhpUFczVWRTM3hQbGdWYmZpWGkvNmJSQytpbjJEYzgyTHdwdDMrbzhB?=
 =?utf-8?B?bS9UQXZ2RDlTTUR0ektzMlJhdm5zTXVod21KSWRFV0ppZE9SbGtmd09uWVlw?=
 =?utf-8?B?M2dac0F3VEtLY0FVUldZYlo0VGp6UitSd2pQS2UycG9Gd2ExelVEai90MXcz?=
 =?utf-8?B?RmtVTFdnTU5pZDkyVUs2MjM4WGgyVFNaMVB5YTdSMTRUZXo2VFZTWHlUbjFQ?=
 =?utf-8?B?dEh6NEN1SkJ3b1RnbmVwSldEQzBucnNVSzdxMTBGQmVCbHBnVEczMXdVazNk?=
 =?utf-8?B?YTRGQ092ZkxyOTdmNFhUVTJjdHBWTXVpN0dQUC9XdVB0VTdGbTNkN0cyK3gy?=
 =?utf-8?B?UlQxaCtUeGF2dklZaGF5TFV2Z0FTQnJxamszRFdRb0hMTlpHRUVhbjJVdnRj?=
 =?utf-8?B?REN3LzBaazVLMmNSaFB0Y0NqQ0Q1cGs2UGJXbCtlUUdtd0ErVjlxNWU1NG1t?=
 =?utf-8?B?RVRyWmtUWjVZeGZSbXVDWjZhTngrOEY0eDNvWmN5VlFRTDJBbmZISkZITVNw?=
 =?utf-8?B?Q1R4VExrSU54Q0J1Q0g1a2MvanA2bUtGZ1dGbE1icHNFY2FaWGY1L3BGMlR5?=
 =?utf-8?B?RlE1SzA0clFybGFpM0drTGpLN2hJby9pYVBLcDhPT0tWZnhmQWVtM081TEJP?=
 =?utf-8?B?NVNQbDVNY0Z4YVVubGEvK1NoQ21DNnBUZkgvcFZHZ29tL0pYdVVEWEVVcGlK?=
 =?utf-8?B?T2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb4baf4-667a-43eb-3f73-08da898db4bf
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3870.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 07:11:34.5766
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K+3TD3kDuHM3xbWTKV1zAJoF724Qn3P5jDhSWv4AU1v+47+rxqrjaLBvlqNkuEcRqn5I2PgEL32/39hBZIrnCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1454
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, your two patches are not in one thread. Don't send it separately, 
Please send it together. Or others can't download your all patches from 
this message-id.

On 8/29/2022 2:38 PM, Song Chen wrote:
> I tried to build tools/test/memblock and got such message:
> 
> /usr/bin/ld: slab.o: in function `kmalloc':
> slab.c:(.text+0x2b): undefined reference to `uatomic_inc'
> /usr/bin/ld: slab.o: in function `kfree':
> slab.c:(.text+0x97): undefined reference to `uatomic_dec'
> collect2: error: ld returned 1 exit status
> 
> I could find any definition or inplememtation of uatomic_inc/uatomic_dec
> in anywhere of the code base. So I use atomic_inc/atomic_dec_and_test
> to replace like other tests underneath tools/test, it works.
> 
> Signed-off-by: Song Chen <chensong_2000@189.cn>
> ---
>   tools/lib/slab.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/lib/slab.c b/tools/lib/slab.c
> index 959997fb0652..8a5a8d536e35 100644
> --- a/tools/lib/slab.c
> +++ b/tools/lib/slab.c
> @@ -3,7 +3,7 @@
>   #include <stdio.h>
>   #include <string.h>
>   
> -#include <urcu/uatomic.h>
> +#include <linux/atomic.h>
>   #include <linux/slab.h>
>   #include <malloc.h>
>   #include <linux/gfp.h>
> @@ -19,7 +19,7 @@ void *kmalloc(size_t size, gfp_t gfp)
>   		return NULL;
>   
>   	ret = malloc(size);
> -	uatomic_inc(&kmalloc_nr_allocated);
> +	atomic_inc(&kmalloc_nr_allocated);
>   	if (kmalloc_verbose)
>   		printf("Allocating %p from malloc\n", ret);
>   	if (gfp & __GFP_ZERO)
> @@ -31,7 +31,7 @@ void kfree(void *p)
>   {
>   	if (!p)
>   		return;
> -	uatomic_dec(&kmalloc_nr_allocated);
> +	atomic_dec_and_test(&kmalloc_nr_allocated);
>   	if (kmalloc_verbose)
>   		printf("Freeing %p to malloc\n", p);
>   	free(p);