Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac383256-65f2-e4ee-0142-65bdb9dd9dae@kernel.org>
Date:   Mon, 29 Aug 2022 09:23:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a
 larger patch series)
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20220825091707.8112-1-ilpo.jarvinen@linux.intel.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20220825091707.8112-1-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 25. 08. 22, 11:17, Ilpo Järvinen wrote:
> Add uart_xmit_advance() helper to handle circular xmit buffer
> advancement + accounting of Tx'ed bytes. Use it to fix a few drivers
> that previously lacked to accounting for DMA Tx.
> 
> Greg,
> I've a another series on top this which is tty-next material making the
> rest of the drivers to use uart_xmit_advance(). That series obviously
> depends on the patch 1/3 of this series so if you end up putting these
> 3 patches into tty-linus, I'll need it to be merged into tty-next at
> some point (I'm not in a big hurry with this so if you choose to delay
> the merge, it's not a big deal).

Hi,
could you hold off with the latter series? I'll send a v2 of TX path 
cleanup shortly. You'd then need to update much less places (if my 
series is accepted):
https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commit/?h=devel&id=2d9ade0412f7e5edacc7f791ebbf773d6481b453
https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commit/?h=devel&id=fd55062d74a8c137d30388c6e25ebd5c06a04517
https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commit/?h=devel&id=a1df5129cc0cf174a8cd03e187c6a5e890d313e4

v1 was here (but was doing a call for every character):
https://lore.kernel.org/all/20220411105405.9519-1-jslaby@suse.cz/

> Ilpo Järvinen (3):
>    serial: Create uart_xmit_advance()
>    serial: tegra: Use uart_xmit_advance(), fixes icount.tx accounting
>    serial: tegra-tcu: Use uart_xmit_advance(), fixes icount.tx accounting
> 
>   drivers/tty/serial/serial-tegra.c |  5 ++---
>   drivers/tty/serial/tegra-tcu.c    |  2 +-
>   include/linux/serial_core.h       | 17 +++++++++++++++++
>   3 files changed, 20 insertions(+), 4 deletions(-)
> 

thanks,
-- 
js
suse labs