Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 10:52:28 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     netdev@kapio-technology.com
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 net-next 1/6] net: bridge: add locked entry fdb flag
 to extend locked port feature
Message-ID: <YwxwPJOx/n5SHZM5@shredder>
References: <20220826114538.705433-1-netdev@kapio-technology.com>
 <20220826114538.705433-2-netdev@kapio-technology.com>
 <Ywo16vHMqxxszWzX@shredder>
 <dd9a4156fe421f6be3a49f5b928ef77e@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dd9a4156fe421f6be3a49f5b928ef77e@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?faizXvhhlQ5Z3CtkSJS6jNsVoI1kCMYIGsCTw1bWExKcF+aL2U3oBvCc+t1l?=
 =?us-ascii?Q?S9LfadjIsnTU0W7S7LgIYhweVe6kZ75dCzxtFg8/nByQEgYhcUjNLAzibUC0?=
 =?us-ascii?Q?O3KgCMxdUHZYRuUEm2D5LWGBOCw5ct6AqkDJftrqo8yxsC6OAUdTc5g95iFw?=
 =?us-ascii?Q?+ChtxymjO63+5DKt9S7kBSRdDQdvQzHf2SGjI7+Nt2pGn9F98Pw7o80Ih5h0?=
 =?us-ascii?Q?3PjwJnSVDpLiLDByiqkHxBl9q/jJlRDXpK6WgE4HPI4w0ybdxCVGav2xfHsD?=
 =?us-ascii?Q?1avQTntl0U+OgOvz91cjQQt8kjcMLaTjfXm6jA3KmJgDPMdOpusSnG44wmI4?=
 =?us-ascii?Q?ZCNMurLDdRLBK72ZBpU/M+Jdjv5XVcDSeslKut0qIEj7yq/mzK+pGOoMPUOQ?=
 =?us-ascii?Q?YVHp7A9oSmdwRgjEVi1AWVwfS4AiGn740hsUs5asxNQ6Rox93ZnReegAVwdN?=
 =?us-ascii?Q?nD14Rg1sxZo2lsaXMfsp16z0euq4k7/D0PCOnfePcJTFTEHRFKglhg131Rv+?=
 =?us-ascii?Q?WUAG6K9WlGO6V9CxAfuX7AXAbU8U0cz8OUuE+0yfBFIOuQMmeYh3W5rhToAp?=
 =?us-ascii?Q?LahOx9n0DYDBt426p1cYlnwP3pXC1LM7S44JpwfojbTIqgoT3r44grH6LT8t?=
 =?us-ascii?Q?hR/AGhe3Rkcbj7AaEmLryP/O068OfV37oUwzAGmTIXoGZ2pUNMQIdgexlvOr?=
 =?us-ascii?Q?hzkEf3RJZtcx+Jp7Gg98w800bRGQEx/wCLbsYEPCgd8eHYKW/DrqxzG0aKwT?=
 =?us-ascii?Q?7coU1jfgU6P/wt3TVrAeRIVaRFf/RfaV9RZL4eLIqwhVgZU+okmSdWu/9lz3?=
 =?us-ascii?Q?Ovw90x8/pnJWu98/NZ6e8g+ASISs7LH0uU7J6RAdqoMU8YAHys7L+/LJGxih?=
 =?us-ascii?Q?wb5ce4Mb0/mO36Q334eNmu1+fyIFNALn04GwhQsAj0TYfGhicNRUGGmhUrZH?=
 =?us-ascii?Q?2JFArcd9CY8migomom2ju/VnxvQlebb6h5+KQJBK6FqLb4Hv68At/qz05+ai?=
 =?us-ascii?Q?Lh6FP2fykT3afnI935QgyFdghBLUaj46OSQ0bdyPp8TTo1TWa9FYxukLxHjA?=
 =?us-ascii?Q?0P3/y1sOdNUyxApBUj6wR1YYfqA6oQY9kd//qWI//YKYLgNjX+F5uIP5Evba?=
 =?us-ascii?Q?6JGvQuPjxSk7p+3rFnYreA636ZMh8Vsb7lyyOlZsJbbzasN9lObcpimWghB/?=
 =?us-ascii?Q?wmOe7kIcBxbQFQB1bo2Y7uI86rDqUPQcwl7/mcsFmcne6pLKgNZFpzgEZV+U?=
 =?us-ascii?Q?Djm1yxdgcOj3SjCA/DT4POaoZw3RIDlNmTf+GhgZlezmNZIf9TxRAlxFt7jx?=
 =?us-ascii?Q?mO5DLHbYAFAm4ixsC86zPLSmI51qqNd1JknWrQEL96OtQaznijvCoPApMGvo?=
 =?us-ascii?Q?dGLjMt5FBMHscwfQzm2TGlD6BiBlwDRKO7VZ+BQ+dZ8X+F06O+RjZWFsxhPd?=
 =?us-ascii?Q?0eqcQZjrZl/LeqKhRKwdoohbP0EnwIPYBk5SJxxXXCXE9+nWNHoY4fwYq3Qs?=
 =?us-ascii?Q?P0u9Sb3Z7KAqqrXPO6gUAcxHzETJOR015sNwMVrIs1g/tNqOvbt5SA2PWpZn?=
 =?us-ascii?Q?V8Lz7XXyYR1VX4JC1QM2X+hl7SOLbL/BWoG2Vz02?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee45c079-41ce-4833-2a60-08da89936eac
X-MS-Exchange-CrossTenant-AuthSource: PH7SPRMB0001.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 07:52:33.8352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZCVtgZM9liPljgryfh53CEyGnZRG3j939rQxH2uip8U8uXRXjNzrGHrMRDZl1P4H8P8SxSspvZOPV6QeZT3Dww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3211
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Aug 28, 2022 at 12:23:30PM +0200, netdev@kapio-technology.com wrote:
> On 2022-08-27 17:19, Ido Schimmel wrote:
> > On Fri, Aug 26, 2022 at 01:45:33PM +0200, Hans Schultz wrote:
> > > 
> > >  	nbp_switchdev_frame_mark(p, skb);
> > > @@ -943,6 +946,10 @@ static int br_setport(struct net_bridge_port
> > > *p, struct nlattr *tb[],
> > >  	br_set_port_flag(p, tb, IFLA_BRPORT_NEIGH_SUPPRESS,
> > > BR_NEIGH_SUPPRESS);
> > >  	br_set_port_flag(p, tb, IFLA_BRPORT_ISOLATED, BR_ISOLATED);
> > >  	br_set_port_flag(p, tb, IFLA_BRPORT_LOCKED, BR_PORT_LOCKED);
> > > +	br_set_port_flag(p, tb, IFLA_BRPORT_MAB, BR_PORT_MAB);
> > > +
> > > +	if (!(p->flags & BR_PORT_LOCKED))
> > > +		p->flags &= ~BR_PORT_MAB;
> 
> The reason for this is that I wanted it to be so that if you have MAB
> enabled (and locked of course) and unlock the port, it will automatically
> clear both flags instead of having to first disable MAB and then unlock the
> port.

User space can just do:

# bridge link set dev swp1 locked off mab off

I prefer not to push such logic into the kernel and instead fail
explicitly. I won't argue if more people are in favor.