Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a9072e3a-2ea5-9da0-a1ba-2be67857e1ba@baylibre.com>
Date:   Mon, 29 Aug 2022 09:41:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h
Content-Language: en-US
To:     Huqiang Qin <huqiang.qin@amlogic.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        khilman@baylibre.com, jbrunet@baylibre.com,
        martin.blumenstingl@googlemail.com
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
References: <e32a8c39-1e47-cad1-e093-2cabb2dd37a4@amlogic.com>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
In-Reply-To: <e32a8c39-1e47-cad1-e093-2cabb2dd37a4@amlogic.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 26/08/2022 13:32, Huqiang Qin wrote:
> Hi Krzysztof,
> 
> On 2022/8/25 20:02, Krzysztof Kozlowski wrote:
>> Why? We can see what you did here, but commit msg should explain why you
>> do it...
> 
> Sorry, I didn't describe this commit message clearly.
> 
> In the future, meson-s4.dtsi will have some nodes that need
> to use the meson-s4-gpio.h file.
> 
> e.g.
>      (1) Bluetooth enable pin:
>          bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
>      (2) Audio mute pin:
>          spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
>      (3) ...
> 
> So, this patch was born.

We understand, but since the Upstream linux codebase want to avoid dead code
as much as possible, please defer this patch when node will actually use these gpio defines.

Neil

> 
> Best regards,
> Huqiang
>