Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c9dffd4f-91f6-cf49-f88d-e099881fe102@kunbus.com>
Date:   Mon, 29 Aug 2022 10:03:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v7 05/10] tpm, tpm_tis: Only handle supported interrupts
Content-Language: en-US
To:     Jason Andryuk <jandryuk@gmail.com>
Cc:     Peter Huewe <peterhuewe@gmx.de>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        linux@mniewoehner.de, linux-integrity@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>, lukas@wunner.de,
        p.rosenberger@kunbus.com
References: <20220629232653.1306735-1-LinoSanfilippo@gmx.de>
 <20220629232653.1306735-6-LinoSanfilippo@gmx.de>
 <CAKf6xpsc9KRUKo5Z-kPqDcSCdpf9-tjf+ZdREnEiJUdHwyDQcA@mail.gmail.com>
From:   Lino Sanfilippo <l.sanfilippo@kunbus.com>
In-Reply-To: <CAKf6xpsc9KRUKo5Z-kPqDcSCdpf9-tjf+ZdREnEiJUdHwyDQcA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXhKYURGNnhnZzdFWjBIQzlIaGJtRTdrdHhJQ0RPaWhSVTYwaXZ5V2ZjNXRD?=
 =?utf-8?B?b1VJSjJueW1PSHNGYW5IN3M1c0NzSWNuL25Qa3dtcEs2TWtoL052Myt3Y0c2?=
 =?utf-8?B?TFRMZUZPUUQwQzg3blhUeGVnUTVLaHErNk5FN2hid1pqZFpUY1pwdDhNQzVN?=
 =?utf-8?B?NkU4cnNZQXBhUFhrSmxsR05ZSU0rcHUyYTZmaWFKZDlWUXRpNEtMbE8yTVF1?=
 =?utf-8?B?TSswYTVMb3hJN1hvb0xXMXNSaHlHaU40T2N6Uk11ejRkVkRMRUNtWTRPOVgx?=
 =?utf-8?B?MUgrOVA3alVlZXlNaDJUeGJpMnRYNGdIVWYvTVdYMWpzVFJMaXQ4NVRhSkdN?=
 =?utf-8?B?azltc25lMm92bnBHL2FUTnQ0WE5BU0hFVUtMM0JoTTZ6dTZIcGJhOHM4K0ZW?=
 =?utf-8?B?MEJjc1ZXZUlqbmk4R3o2REVFZnBBa1h4c2RORXRkREpKb0xSZ05jQ00yNWtk?=
 =?utf-8?B?ZEJHOFhSVDNtWkM0VG5rbHNZdTJHZ0pWUTRwbTBpUUFHc2JLRDRTSVlhdWVu?=
 =?utf-8?B?WmtPUU5hTWFrRUhXQ1NDR3QzVkFYNU1mTityYjgyMTFZMVBEalN0L05qVzZq?=
 =?utf-8?B?d091aUdsZ0ZGcnI5VzQvNUxpOTcveS9tMWUyOFNwb2JobWZLVUFvVExzcGdH?=
 =?utf-8?B?NXhvb3lxQzlwM2duUTl1ejM2WnVNSWd4UVVzWlJCdkpkL0tVeWppSERqSmhV?=
 =?utf-8?B?eExTRTVqQ2pIWXVObWpucWFIMWluU3pLYXdPbE42U21xeVErcTFOUzZPVG1s?=
 =?utf-8?B?R3hNa0w0WnM2UXFuMEgzKzgwSmNLNkJKTStrYVBmc2VycnlNdE1Fb1pYdFBz?=
 =?utf-8?B?ZkdaOHRWU3V4RGlrNERUNlpuTTUybVIrV3BoaG9meWhERUI0bWZHNlovcGtB?=
 =?utf-8?B?SHRDS0E0MTBEK2IxSlh1azA3REsycXFVeHpGQitIRzMycko2b0xNT05XbVl1?=
 =?utf-8?B?ZTVqdERkT2txQUEzUFRrZlFMZG90ekI5WEJndmd5SjR0enJsSTIyaEF2bzlk?=
 =?utf-8?B?SXlocGhrVDlRNXNzV2p4NGsyc2VLYnRMc3YwT1g0eVNRaEREOXU1TXBHWXJH?=
 =?utf-8?B?eHc4ckhEZHRXQkVUUmRpa0s1SXI3WnNrRDFZZHJIQ3lYMk9EcldmWG00NGk3?=
 =?utf-8?B?WjV4MS8wMXNZeU9NTy8wUGsyUlROOXFmR2pnODUrSHFvem8yN0J3SkZybTY3?=
 =?utf-8?B?V0xHYWtobXdaZVh2bU1tVXMyMTJ2cmtMLy9PL0pNWWJ1cmdoTWJydW1QdkFO?=
 =?utf-8?B?cE4xOTBWN1MrQ0NWb1VDUjJqVWZ6SkpDTVBLbWFTOStacGtrVWNYSFFMMHRE?=
 =?utf-8?B?UTRmY3pNWU56UFBhYlh1NUZaNGowaDZodWZUTUZqSnYyUG5VR3ZzZjBjNXZH?=
 =?utf-8?B?ajhBM25OOERPcnh2VzJDb2d4Wlpub0tOdUxQcG4raUlDeG8vM3JXVWNWWlJT?=
 =?utf-8?B?SXFsdm00NmlZL2g2eFhhMGEzQ3NoZTBDM0RrUzM1ckYwSjdjQWJBZ253KzNn?=
 =?utf-8?B?SktERWllcDJEKzRYNHhPU0o1TUxMTzRUeW9ydEJ4RkVJWnBIRklYMk5TaGg4?=
 =?utf-8?B?STNoN3ZjZFdjNVYyOHNJVFc2KzFNWDI5eDhwbzNjeS9sOVdvTm9GMDZIUTlT?=
 =?utf-8?B?SU03TzBmYmF1WkNYcllBN3JpRHFidUtnazEzTTRvcDFqeVIvblpzZHZ2L1cw?=
 =?utf-8?B?cU9qeGpDbzBST3MxUC91UGFQVEtwbDNza0YwUm15YlpzT2MrbkxGZ21Fby80?=
 =?utf-8?B?Z0R0cU5rTHVRQlF1VUhnL2NNeU5MckZuMlF3TmVnbW1mTTl0S080YlZ4UDBX?=
 =?utf-8?B?NFB6aDNKbHpQL3hVaVh2MVVSajRnT2xxR1lBUlppUmJNQWVTTjd3eXhaeW1u?=
 =?utf-8?B?UHIzZTY4cU9oeHpORXVVanA1MWRraGlmNktic2Iyang5L3NPU3lkbytrcVRS?=
 =?utf-8?B?V3pmcE5IMyt5Z3haN2VSMkZNZFljWWFLWUt1VnlGa1R1MkRQS2ZWR3lHZExN?=
 =?utf-8?B?RWRxdDdUYkx5TnNZWFpHeEdoRlZENzdvUjVvMGpvTEppUmNhQk5yOThhWlV5?=
 =?utf-8?B?eG5EVGJrSnhHTGtDNkJINmVKRTRmSTVESTN6V0dZRWY5YXRTOGRTOXNTVi9n?=
 =?utf-8?B?dEwydTJEcGdiakF5OHhUdkljUFlYTVVlNWdqK2RmSlRlSzlYUjVxMlVNOGls?=
 =?utf-8?B?WXQ1RFVwV09HZDF0RUdLbjFnL0x3K1pLaU0zUVJCVXordVhLdU5QUjZCcDk0?=
 =?utf-8?B?bDN4OXFnNHovQktabnA0ZlNsUGZBPT0=?=
X-OriginatorOrg: kunbus.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fac2d1d-a385-4643-d914-08da8994ed43
X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 08:03:15.9845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n0bXnEpmqGHoZHxPagaTI3c7IzJSeUDdy6nJRB3usHA4Q+zlCJ5OgvciuYNSnUvjk7PUNG3xMvMgd5Dt2DTf9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0912
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Jason,

On 26.08.22 19:43, Jason Andryuk wrote:
> On Wed, Jun 29, 2022 at 7:28 PM Lino Sanfilippo <LinoSanfilippo@gmx.de> wrote:
> 
>> @@ -1007,8 +1029,39 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
>>         if (rc < 0)
>>                 goto out_err;
>>
>> -       intmask |= TPM_INTF_CMD_READY_INT | TPM_INTF_LOCALITY_CHANGE_INT |
>> -                  TPM_INTF_DATA_AVAIL_INT | TPM_INTF_STS_VALID_INT;
>> +       /* Figure out the capabilities */
>> +       rc = tpm_tis_read32(priv, TPM_INTF_CAPS(priv->locality), &intfcaps);
>> +       if (rc < 0)
>> +               goto out_err;
>> +
>> +       dev_dbg(dev, "TPM interface capabilities (0x%x):\n",
>> +               intfcaps);
>> +       if (intfcaps & TPM_INTF_BURST_COUNT_STATIC)
>> +               dev_dbg(dev, "\tBurst Count Static\n");
>> +       if (intfcaps & TPM_INTF_CMD_READY_INT) {
>> +               intmask |= TPM_INTF_CMD_READY_INT;
>> +               dev_dbg(dev, "\tCommand Ready Int Support\n");
>> +       }
>> +       if (intfcaps & TPM_INTF_INT_EDGE_FALLING)
>> +               dev_dbg(dev, "\tInterrupt Edge Falling\n");
>> +       if (intfcaps & TPM_INTF_INT_EDGE_RISING)
>> +               dev_dbg(dev, "\tInterrupt Edge Rising\n");
>> +       if (intfcaps & TPM_INTF_INT_LEVEL_LOW)
>> +               dev_dbg(dev, "\tInterrupt Level Low\n");
>> +       if (intfcaps & TPM_INTF_INT_LEVEL_HIGH)
>> +               dev_dbg(dev, "\tInterrupt Level High\n");
>> +       if (intfcaps & TPM_INTF_LOCALITY_CHANGE_INT)
> 
> Hi, you may already have fixed this, but I just saw:
> 
> error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
>  1144 |         if (intfcaps & TPM_INTF_LOCALITY_CHANGE_INT)
>       |         ^~
> 
>> +               intmask |= TPM_INTF_LOCALITY_CHANGE_INT;
>> +               dev_dbg(dev, "\tLocality Change Int Support\n");
> 
> You need { } for the block.
> 

thanks for pointing at this, I will fix it in the next version of this series.

Regards,
Lino


> Regards,
> Jason