Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 10:54:43 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Jiri Slaby <jirislaby@kernel.org>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a
 larger patch series)
In-Reply-To: <1a05800e-a3c2-12f3-135e-b81a283d71a2@kernel.org>
Message-ID: <e4a25dfa-a2f9-5165-2f39-1730476c5220@linux.intel.com>
References: <20220825091707.8112-1-ilpo.jarvinen@linux.intel.com> <ac383256-65f2-e4ee-0142-65bdb9dd9dae@kernel.org> <55cf3faf-2616-09c-57c3-35e7b11e55@linux.intel.com> <1a05800e-a3c2-12f3-135e-b81a283d71a2@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-669509969-1661759686=:1928"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-669509969-1661759686=:1928
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 29 Aug 2022, Jiri Slaby wrote:

> On 29. 08. 22, 9:41, Ilpo Järvinen wrote:> Looking into your patches, they
> also seemed to lack that> icount.tx++ thing.
> 
> Perhaps, you only overlooked it?
> 
> +	for (; (for_test) && (!tx_ready || tx_ready(port));
> +			(for_post), port->icount.tx++) {		

Ah, yes, I did (and its placement at the end of a multi-line for() didn't 
help that much either for pick it up :-)).

-- 
 i.

--8323329-669509969-1661759686=:1928--