Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 16:00:41 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Shakeel Butt <shakeelb@google.com>
CC:     Michal Hocko <mhocko@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mm: deduplicate cacheline padding code
Message-ID: <YwxyKS3872gW8PaO@feng-clx>
References: <20220826230642.566725-1-shakeelb@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220826230642.566725-1-shakeelb@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wd9w4XnL/qOqMy7Ngv5nLenVrsCMNX0k+y8wglJfZbZwIiQAoR6BO181R+BU?=
 =?us-ascii?Q?+La9QTp/2BSEZOLLV11vUXMWpBfJUsXQhCkmk0TtJw3pHvSvOYkHh5OPdBmU?=
 =?us-ascii?Q?80zGFd6IpHVsmkOGQdT1T6+axldPS49fjPjUNu3bIyF9jbyCgejIgO10SYii?=
 =?us-ascii?Q?JcKrVEa7gfoA+5ddTlWwVsBga3SwdPF4hxsnhhRk70ExNINcCPxH5FGS0Gfv?=
 =?us-ascii?Q?D8UEmO3nAav/tz+FCET9uTntMtqDImiSpp2qHm0k52QRkdAvkCWiT75gDSeA?=
 =?us-ascii?Q?OMsH4HYxWuAjdjFR+hG79D/IHNl2zfoBH2xtiTj5Ob+3j9xwS3WyAZzLZsyI?=
 =?us-ascii?Q?CDAW+E7Xc8CAt8P5+GCPRYvuDg5oeYMaymeZsV2J7ptNkTKsIr0dLvhSK/4C?=
 =?us-ascii?Q?LWrG5dNRutNhSFKnTgtksGUxHon+HnBW1T8urUzqIqLv8ELo16+WyK4Szecz?=
 =?us-ascii?Q?H3QNRaKhNSzOegb92/uLVebmcOH10Ne3hbjLZjYhZQRkZ5pChYnKK8g46FLu?=
 =?us-ascii?Q?vDfkyHtkcF8785QHkRVU+pojMzpvydlHlNoo7lBnZk94sYNWK7pfrOoTfQAW?=
 =?us-ascii?Q?hFvfLzlhAxdv+uX8EKxxK3H0GcjYlRPDNOxJEf7A1e7sOl9l2lX/PW24US5Z?=
 =?us-ascii?Q?JCvOb40arwsb4tTmoX9VsSm7OWIXZBYcVoCAjzekUlYebFyMLuUCmGogv7wK?=
 =?us-ascii?Q?nfsvQ2zwbm92UKODyuRdxpm5n+9u41sTxy7QwV7fNuKP+KJccQKmuNvIcuyJ?=
 =?us-ascii?Q?Flc0gnChQ5dbAlZbByYjhe7IJuqXMI+VnumWmcpL8apiM60mCaJQUFasWki1?=
 =?us-ascii?Q?FwL0NZQcg0nWzj3RqyutjcodB4cMaDmMeiGilfEZ4L4IM3c1PRDafZ4l/EW9?=
 =?us-ascii?Q?JY3NOuq0Dgkh9fh8fL20fb9/OKeHiucQBLLux0eWefp30UdyLRNjCD1poz+W?=
 =?us-ascii?Q?HKTwuWtEMBbdxvlL0+uQ8j3s5v27oHYhYtn1Y2i45VZGHg4KVTmBiAardqtJ?=
 =?us-ascii?Q?aXxULNH2OgARGhNlL6stNQqJ5NcZdA0kHKC/H8eGeg8PxeIoGM88cAWpcH91?=
 =?us-ascii?Q?dyczOeMazWb14loHhIGQu0z0Ok5dB30rOanore2UEMOykSC8Js+VlUWIu6hz?=
 =?us-ascii?Q?4sYSF3U/EtHLw+jLXqHBVxdGdvuPezGKTb3W7cPpxcKznkW8prOdZWuyUOON?=
 =?us-ascii?Q?8eZZpawOW8NHQ6ixwg1u7QuHmOaOJblmPwZ9cFfUMCIKzOmNdeyTPz8oG+AN?=
 =?us-ascii?Q?nn6xNH1cJ8LHF/STscuNh45mDDhzzCUu2HaaOuIoZSsRDsYv4UM06zbC7kbO?=
 =?us-ascii?Q?CBRN8cDOt8J0lbahQsYqxAxbZKRQVNOG5N1rEVh8t3hm71djeqzYh8cPT11D?=
 =?us-ascii?Q?y/n+/lhXyeWceDg40T3cYn5VbrfHhvZtN3a5+BuRj3m+u79K0mavmoyvvwkT?=
 =?us-ascii?Q?J5yEYFuhoo+X3ZeXUkZLGEMxD62nAp2rrD0bfTAUpWNQJO+1ER6WsTaSIZuU?=
 =?us-ascii?Q?CnUt6ZKENi/eferumCt3FZ+HGeeaZDITFxseq6TwECNpr1h27aa2CrMdBouZ?=
 =?us-ascii?Q?Hxz1P7lvAYE38CNN/4LTQ4gJ412ssEVq7hPREb6X?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 70d15240-7903-4e4e-27fe-08da8994a644
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 08:01:16.4933
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: daz8dmqbltcwAdtj23OlFhGlUwxVEv79Pi1jmibdu4tVyxxYjFES5/N3L0GpHX9WQNXLYo5pya6Vbvbw7RXJLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4327
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Aug 27, 2022 at 07:06:42AM +0800, Shakeel Butt wrote:
> There are three users (mmzone.h, memcontrol.h, page_counter.h) using
> similar code for forcing cacheline padding between fields of different
> structures. Dedup that code.
> 
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> Suggested-by: Feng Tang <feng.tang@intel.com>

Reviewed-by: Feng Tang <feng.tang@intel.com>

Thanks,
Feng

> ---
> Changes since v1:
> - add semicolons in mmzone.h
> 
>  include/linux/cache.h        | 13 +++++++++++++
>  include/linux/memcontrol.h   | 13 ++-----------
>  include/linux/mmzone.h       | 24 +++++-------------------
>  include/linux/page_counter.h | 13 ++-----------
>  4 files changed, 22 insertions(+), 41 deletions(-)
[...]