Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp2866814rwe; Mon, 29 Aug 2022 01:24:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR6l9uy0zZx8HnMF1nSzgnEw33tqR47VifHMSxLtMsKYqo1lcaC9ySB83bMYcEdh8Sy4Iz4d X-Received: by 2002:aa7:92d8:0:b0:537:acbf:5e85 with SMTP id k24-20020aa792d8000000b00537acbf5e85mr15268490pfa.61.1661761488137; Mon, 29 Aug 2022 01:24:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661761488; cv=none; d=google.com; s=arc-20160816; b=W4NGjhsneSq7cnz1p8WGNw64IjQPco6BsV2UukzHP46S+rWmXHxy8eWpyp8cUpAj7k TdOA187ruMO8FmQ7Gs0Z/qvSeD5r8I4S1chLHQ4NqGUk6iCEGYbwY29V1ixTMTkyH49l UwkB6cChjG3nAB0KNYYp9SgTK03fwaQ/3NtMgSrgZKxux1CHadDi/BmsENlHVmm8ghp+ 0bjpAQmgHKwm2i5k4qWBC9i3Ho7IN8+cQHgZxWUDsY6F3Ya8xYGvO+bbc4SjLTyb0smM m6k88aefVtv8D5N2xyWkBB2pHfO3SsYxpzUJTC8ZsrYkHOe4C3nk5dlvcbSXm1mHyqPT IAlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=j67PODyFLlaaryt3BHX3uk5uByxDeNuc4UP3AQpoax4=; b=biA2NfatLOKFOjvytA4GYzR8wyl0ND51UvjxLQlzB/DhUdsI5P03WAPR7P307gf3Sd Lov3oFTTcR5vVz1cnuN6RXGUwAlRyygD1uinPvn8tj8Fz2oii4aKneWXL5V4PRXatjY9 LOo729IjMawaOWSCZfnSs4b5kI8I3ELE0NhZ9ZscjCpWyEZF/XidRggz/poaene496n0 KDu38fRl32fTZqOugCz7Ay4wDea1Sgesw/pJzS3PI7mtnqcxHAVy7WO87glEK2It9jxy Apr2rha3qq8aw11kpF1nxMy6D+fhn90vMbmLBdWksEK8Bn+f55mEMnncvVSYDgbCCSc6 kIjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p65-20020a622944000000b00537bd76127fsi8374299pfp.55.2022.08.29.01.24.37; Mon, 29 Aug 2022 01:24:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229453AbiH2Hui (ORCPT + 99 others); Mon, 29 Aug 2022 03:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbiH2HuV (ORCPT ); Mon, 29 Aug 2022 03:50:21 -0400 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C718311C36; Mon, 29 Aug 2022 00:50:19 -0700 (PDT) Received: by mail-ed1-f47.google.com with SMTP id z8so223695edb.6; Mon, 29 Aug 2022 00:50:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=j67PODyFLlaaryt3BHX3uk5uByxDeNuc4UP3AQpoax4=; b=V9jlZbmN9PHlVZv1MoyETdBHr3pV2jfBP4+Vx5zshVD7p5/bUKJ/FPLoJiH+SBWfP8 zFcWCTR5wWXb2iS2aGkFAB6HjsoAXzSCWsCWaPsPCi5ZIbXa/jrLv213B6UDAdtxkeiS v8Tw1Hz6+U5dmeGTKbMuNS7P8rH9UeKxkRQxW4Nl0bhfBru68FUm1fSKbuxqs5giYdD/ H6mQ3YMXnRVQ3TBw1Vtnm1RTpDr4QiGpxsjiHENozFQF3C4zwvU7qLNPUcj28b3MOokc gdlMv/wBXdfLQx9ddwF9wOFJzn9pUGZCsldsDlig7PjWjpiTxGuW0+7tIdO46IUVLWVd HBCw== X-Gm-Message-State: ACgBeo0UvEDxIoab4sF/Cy59ISPKyyuzv5OTuOQGq0qbazqx0A4PWGSc pqdkkvYBjBoNXo9UgPUy077fHF51B7U= X-Received: by 2002:a05:6402:2753:b0:43a:d6f2:9839 with SMTP id z19-20020a056402275300b0043ad6f29839mr15026151edd.73.1661759418208; Mon, 29 Aug 2022 00:50:18 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id kw2-20020a170907770200b0073872f367cesm4173874ejc.112.2022.08.29.00.50.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Aug 2022 00:50:17 -0700 (PDT) Message-ID: <1a05800e-a3c2-12f3-135e-b81a283d71a2@kernel.org> Date: Mon, 29 Aug 2022 09:50:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a larger patch series) Content-Language: en-US To: =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= Cc: Greg Kroah-Hartman , linux-serial , LKML References: <20220825091707.8112-1-ilpo.jarvinen@linux.intel.com> <55cf3faf-2616-09c-57c3-35e7b11e55@linux.intel.com> From: Jiri Slaby In-Reply-To: <55cf3faf-2616-09c-57c3-35e7b11e55@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29. 08. 22, 9:41, Ilpo Järvinen wrote:> Looking into your patches, they also seemed to lack that> icount.tx++ thing. Perhaps, you only overlooked it? + for (; (for_test) && (!tx_ready || tx_ready(port)); + (for_post), port->icount.tx++) { thanks, -- js suse labs