Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3746264c-adb1-80b4-02d2-13f0790fe322@kernel.org>
Date:   Mon, 29 Aug 2022 10:21:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH] tty/vt: Remove printable variable
Content-Language: en-US
To:     Daniel Vetter <daniel.vetter@ffwll.ch>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     DRI Development <dri-devel@lists.freedesktop.org>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        nick black <dankamongmen@gmail.com>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        Yangxi Xiang <xyangxi5@gmail.com>,
        Xuezhi Zhang <zhangxuezhi1@coolpad.com>
References: <20220826202419.198535-1-daniel.vetter@ffwll.ch>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20220826202419.198535-1-daniel.vetter@ffwll.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 26. 08. 22, 22:24, Daniel Vetter wrote:
> Every since the 0.99.7A release when console_register() was introduced
> it's become impossible to call vt_console_print (called
> console_print() back then still) directly. Which means the
> initialization issue this variable protected against is no more.
> 
> Give it a send off with style and let it rest in peace.

FWIW:
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

In hopes, nothing breaks.

> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
> Cc: nick black <dankamongmen@gmail.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Yangxi Xiang <xyangxi5@gmail.com>
> Cc: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
> ---
>   drivers/tty/vt/vt.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index ae9c926acd6f..4d29e4a17db7 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -157,7 +157,6 @@ static void set_palette(struct vc_data *vc);
>   
>   #define vt_get_kmsg_redirect() vt_kmsg_redirect(-1)
>   
> -static int printable;		/* Is console ready for printing? */
>   int default_utf8 = true;
>   module_param(default_utf8, int, S_IRUGO | S_IWUSR);
>   int global_cursor_default = -1;
> @@ -3085,8 +3084,6 @@ static void vt_console_print(struct console *co, const char *b, unsigned count)
>   	int kmsg_console;
>   
>   	/* console busy or not yet initialized */
> -	if (!printable)
> -		return;
>   	if (!spin_trylock(&printing_lock))
>   		return;
>   
> @@ -3537,7 +3534,6 @@ static int __init con_init(void)
>   	pr_info("Console: %s %s %dx%d\n",
>   		vc->vc_can_do_color ? "colour" : "mono",
>   		display_desc, vc->vc_cols, vc->vc_rows);
> -	printable = 1;
>   
>   	console_unlock();
>   

thanks,
-- 
js
suse labs