Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 11:24:56 +0300
From:   Mike Rapoport <rppt@kernel.org>
To:     Song Chen <chensong_2000@189.cn>
Cc:     karolinadrobnik@gmail.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH 2/2] tools/testing/memblock: define pr_warn_ratelimited
Message-ID: <Ywx32C4/kE2WgR75@kernel.org>
References: <1661755140-3331-1-git-send-email-chensong_2000@189.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1661755140-3331-1-git-send-email-chensong_2000@189.cn>
Precedence: bulk

On Mon, Aug 29, 2022 at 02:39:00PM +0800, Song Chen wrote:
> Commit 14d9a675fd0d("mm: Ratelimited mirrored memory related warning
> messages") introduced pr_warn_ratelimited in memblock.c, which breaks
> tools/test/memblock, below is the message:
> 
> /usr/bin/ld: memblock.o: in function `memblock_find_in_range.constprop.0':
> memblock.c:(.text+0x4603): undefined reference to `pr_warn_ratelimited'
> /usr/bin/ld: memblock.o: in function `memblock_alloc_range_nid':
> memblock.c:(.text+0x786a): undefined reference to `pr_warn_ratelimited'
> collect2: error: ld returned 1 exit status
> 
> A fake pr_warn_ratelimited needs to be defined in printk.h like other
> prink functions.

This is fixed by commit 0a7e91528202 ("memblock tests: fix compilation errors")
 
> Signed-off-by: Song Chen <chensong_2000@189.cn>
> ---

-- 
Sincerely yours,
Mike.