Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a054ffb1-527b-836c-f43e-9f76058cc9ed@gmail.com>
Date:   Mon, 29 Aug 2022 10:51:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] wifi: cfg80211: add error code in
 brcmf_notify_sched_scan_results()
Content-Language: en-US
To:     Li Qiong <liqiong@nfschina.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yu Zhe <yuzhe@nfschina.com>
References: <20220829065831.14023-1-liqiong@nfschina.com>
From:   Arend Van Spriel <aspriel@gmail.com>
In-Reply-To: <20220829065831.14023-1-liqiong@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/29/2022 8:58 AM, Li Qiong wrote:
> The err code is 0 at the first two "out_err" paths, add error code
> '-EINVAL' for these error paths.

There is no added value provided in this change. There is an error 
message, but it is otherwise silently ignored as there is no additional 
fault handling required.

Regards,
Arend

> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++
>   1 file changed, 2 insertions(+)