Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8752aa54-28a3-9ae3-45ca-947551f31773@datenfreihafen.org>
Date:   Mon, 29 Aug 2022 10:55:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] ieee802154: cc2520: add rc code in cc2520_tx()
Content-Language: en-US
To:     Li Qiong <liqiong@nfschina.com>,
        Varka Bhadram <varkabhadram@gmail.com>,
        Alexander Aring <alex.aring@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Yu Zhe <yuzhe@nfschina.com>
References: <20220829071259.18330-1-liqiong@nfschina.com>
From:   Stefan Schmidt <stefan@datenfreihafen.org>
In-Reply-To: <20220829071259.18330-1-liqiong@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


Hello Qiong.

On 29.08.22 09:12, Li Qiong wrote:
> The rc code is 0 at the error path "status & CC2520_STATUS_TX_UNDERFLOW".
> Assign rc code with '-EINVAL' at this error path to fix it.
> 
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
>   drivers/net/ieee802154/cc2520.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index 1e1f40f628a0..c69b87d3837d 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -504,6 +504,7 @@ cc2520_tx(struct ieee802154_hw *hw, struct sk_buff *skb)
>   		goto err_tx;
>   
>   	if (status & CC2520_STATUS_TX_UNDERFLOW) {
> +		rc = -EINVAL;
>   		dev_err(&priv->spi->dev, "cc2520 tx underflow exception\n");
>   		goto err_tx;
>   	}

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt