Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 11:17:05 +0200
From:   Alexander Dahl <ada@thorsis.com>
To:     Olliver Schinagl <oliver@schinagl.nl>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Baolin Wang <baolin.wang@linaro.org>,
        Daniel Mack <daniel@zonque.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Oleh Kravchenko <oleg@kaa.org.ua>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Simon Shields <simon@lineageos.org>,
        Olliver Schinagl <oliver+list@schinagl.nl>,
        devicetree@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: leds: Expand LED_COLOR_ID definitions
Message-ID: <YwyEEYRUF3WoQr0M@ada.ifak-system.com>
Mail-Followup-To: Olliver Schinagl <oliver@schinagl.nl>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Baolin Wang <baolin.wang@linaro.org>,
        Daniel Mack <daniel@zonque.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Oleh Kravchenko <oleg@kaa.org.ua>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Simon Shields <simon@lineageos.org>,
        Olliver Schinagl <oliver+list@schinagl.nl>,
        devicetree@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <7c688821-140b-4b05-651b-337f602dc1fe@schinagl.nl>
 <6ec9eaa1-2bc2-a32f-6685-4a2a645a5a59@schinagl.nl>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6ec9eaa1-2bc2-a32f-6685-4a2a645a5a59@schinagl.nl>
Precedence: bulk

Hello Olliver,

Am Fri, Aug 12, 2022 at 04:31:55PM +0200 schrieb Olliver Schinagl:
> In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
> 
> Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
> added. However, there's a little more very common LED colors.
> 
> While the documentation states 'add what is missing', engineers tend to
> be lazy and will just use what currently exists. So this patch will take
> (a) list from online retailers [0], [1], [2] and use the common LED colors
> from
> there, this being reasonable as this is what is currently available to
> purchase.
> 
> Note, that LIME seems to be the modern take to 'Yellow-green' or
> 'Yellowish-green' from some older datasheets.
> 
> [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125
> [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd
> [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma
> 
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
> 
> Changes since v1: Unbreak existing definitions.
> 
> ?include/dt-bindings/leds/common.h | 28 ++++++++++++++++------------
> ?1 file changed, 16 insertions(+), 12 deletions(-)
> 
> diff --git a/include/dt-bindings/leds/common.h
> b/include/dt-bindings/leds/common.h
> index 3be89a7c20a9..04bf94523ea3 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -22,18 +22,22 @@
> ?#define LEDS_BOOST_FIXED??? 2
> 
> ?/* Standard LED colors */
> -#define LED_COLOR_ID_WHITE??? 0
> -#define LED_COLOR_ID_RED??? 1
> -#define LED_COLOR_ID_GREEN??? 2
> -#define LED_COLOR_ID_BLUE??? 3
> -#define LED_COLOR_ID_AMBER??? 4
> -#define LED_COLOR_ID_VIOLET??? 5
> -#define LED_COLOR_ID_YELLOW??? 6
> -#define LED_COLOR_ID_IR??? ??? 7
> -#define LED_COLOR_ID_MULTI??? 8??? /* For multicolor LEDs */
> -#define LED_COLOR_ID_RGB??? 9??? /* For multicolor LEDs that can do
> arbitrary color,
> -??? ??? ??? ??? ??? ?? so this would include RGBW and similar */
> -#define LED_COLOR_ID_MAX??? 10
> +#define LED_COLOR_ID_WHITE????? 0
> +#define LED_COLOR_ID_RED??????? 1
> +#define LED_COLOR_ID_GREEN????? 2
> +#define LED_COLOR_ID_BLUE?????? 3
> +#define LED_COLOR_ID_AMBER????? 4
> +#define LED_COLOR_ID_VIOLET???? 5
> +#define LED_COLOR_ID_YELLOW???? 6
> +#define LED_COLOR_ID_IR???????? 7
> +#define LED_COLOR_ID_MULTI????? 8 /* For multicolor LEDs */
> +#define LED_COLOR_ID_RGB??????? 9 /* For multicolor LEDs that can do
> arbitrary color, including RGBW etc. */
> +#define LED_COLOR_ID_PUPRPLE?? 10

Typo? Should be LED_COLOR_ID_PURPLE, right?

Greets
Alex

> +#define LED_COLOR_ID_ORANGE??? 11
> +#define LED_COLOR_ID_PINK????? 12
> +#define LED_COLOR_ID_CYAN????? 13
> +#define LED_COLOR_ID_LIME????? 14
> +#define LED_COLOR_ID_MAX?????? 15
> 
> ?/* Standard LED functions */
> ?/* Keyboard LEDs, usually it would be input4::capslock etc. */
> -- 
> 2.37.1
>