Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 12:51:06 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Hawkins Jiawei <yin31149@gmail.com>
Cc:     akpm@linux-foundation.org, anton@tuxera.com,
        chenxiaosong2@huawei.com, linux-kernel@vger.kernel.org,
        linux-ntfs-dev@lists.sourceforge.net,
        syzbot+5f8dcabe4a3b2c51c607@syzkaller.appspotmail.com,
        syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] ntfs: change check order in ntfs_attr_find
Message-ID: <20220829095106.GG2071@kadam>
References: <20220827075143.61311-1-yin31149@gmail.com>
 <20220827144943.5290-1-yin31149@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220827144943.5290-1-yin31149@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ox8dNPMUKI+8ghMNg9PIH0bzW+HtKbLy2rm+A9Fl1+kJMjtGtsAMXSSMUiKe?=
 =?us-ascii?Q?57Jwr6NxQgJ6OrczNo5kfoo0hcuPZixzphrFH3L28M9i2DvMBYnrCA7JxTgq?=
 =?us-ascii?Q?wq6LAHJAV8tbeS39Zz+dEOFxncYKff4Z2D/nDWsUtrgRMUksdwNm9FlUHijw?=
 =?us-ascii?Q?JiRb6ysQNJHkyGIh4iMiDjGiDeRrER+JUEAGRBDU1xOmJiVly0ehxnDpZbwq?=
 =?us-ascii?Q?9WZEzYWqBJS0j52izIIHNuKeWNYY8JSesSSq/xQ+5rfl05B4BTSxMyKXC/6k?=
 =?us-ascii?Q?LGr8wy9YIiOJo0GMVyef+0JmwfA/eLJdPZ49saQnrIbG+X59Kc9QD6cN9KK8?=
 =?us-ascii?Q?VuklqOjRbXuT7lKfIkVADNslngtocwGk3hdqblPwkiIqeaOMkY+SYd1Ete4z?=
 =?us-ascii?Q?C9W72INzn6/C0qFG/iqg89nAZw+XlLAAvdYnfVZygoER4b+Up8mNvFDnzB67?=
 =?us-ascii?Q?elkx2f5XwIppXsBDqtEJmhhMrXDFC2+wnOVqA4a45i8bLuPVdiQ4aeglz/Gi?=
 =?us-ascii?Q?csDw9CPTQtljuP86ZOVcN8ZakaoIWs4FB1pIfB3PtPH1kc87MAumke2XCc2O?=
 =?us-ascii?Q?FCAvYYZi92JjcUC2COyc7fNqNdZoAa4Gt7WFTG9OxZBqYaBkPmFrVxFNGLRC?=
 =?us-ascii?Q?4FvTWeqnHJpFasVX/oCtgntMYWav+qpUvEC/umw1Q+QPsnmhGyGcyeVmjsMc?=
 =?us-ascii?Q?uVh3SSNQ625+ASxIZM1AtyExzETGoXtQcXByDuw2sZmKNLHaSab+HJ4128HF?=
 =?us-ascii?Q?H2L8kF3xnBp468aUy9cDN1JbWjLs7qp9ylvfpr3eIKudpeZVeVKgcZMwJwIQ?=
 =?us-ascii?Q?h/fgq7qx/mRpCPM5nX81CdilCsTDsj+lx0qGiIXlGHUE5zeFDyRNT7YjoOTN?=
 =?us-ascii?Q?Cy8/IcCYlRU92/bMv4PxcGiMu+XBQrd8TRfY6ldyElq5Z6YhGdkYZVMamp+g?=
 =?us-ascii?Q?zTq/x2V0A+++2hG43LSer3vuJESK+dRUiSkA5eEkIF3ewusYt560e/CvMJvk?=
 =?us-ascii?Q?Z0/zhm6OqeiQoNe/p2+2WxOuzEsNA8WLPpus2yDFHkqFALlkgQ0YO1gzMznR?=
 =?us-ascii?Q?E+dnvPYeBhDbEbqHN98DpAG46N5c564wW2oAbA2LgWY13uKz5PX/Y6M9UH9j?=
 =?us-ascii?Q?lXQTS6Vn6TsokKLO2PRAial7lVRyg+NIgWTXjKuUtaFaPglVpyFdXPfuSeLU?=
 =?us-ascii?Q?votIDFM3Z+OvDI3+YzT2EMDqiApee0ezLybVfAvGU3LPDZPjxJFyZe0FMc3w?=
 =?us-ascii?Q?N7fxvJ1H3Qv/kjKXfDiijkQ/laaxP5F8s/8zw/KSgavVELRr7g2RLUj4BcyC?=
 =?us-ascii?Q?7VBEAjyHV8lyV7WnDuzA4ZxbxnAemfezDjALRRZIMav240MU1IDaVW/Gl5lm?=
 =?us-ascii?Q?3KKbwDqMCSGT4N06XcZ7UKu+cQxUnAIxl515AjINEjVHPhp/91e4pae14TCG?=
 =?us-ascii?Q?BLwB9yZk2J879HwIji+CYzzfbPRJ20V0vwvSmAJKXM6M9Gm5i7Ma9L5CUuUy?=
 =?us-ascii?Q?fL8Lq4UHslB/fgy8CWu2uJPKbpnHZOmp/yvf4fBRNQIagn5xkZnV/Q/Denbw?=
 =?us-ascii?Q?1Isv/srfU3cZX8eJ+cLNVAGaokgH410Flr8egZaZAfudYc+IeLPKXZ8wpSm9?=
 =?us-ascii?Q?2A=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74376338-18a3-4cb3-59df-08da89a408aa
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 09:51:24.8119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0og8cWGY9cTSilUM/z3MJK2l9Os0lziR4U7G8GHEvw6Pj7XqpRwEUS4ed0hKX3Tox6Fum7Djmm9q1U9vADFZUySb8VNsZjx309JyPSp1AOQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1362
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-29_05,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxlogscore=728 adultscore=0 phishscore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208290048
X-Proofpoint-GUID: AdxUz_JtlUI23TcAjaHJUmEmcBWyaiPE
X-Proofpoint-ORIG-GUID: AdxUz_JtlUI23TcAjaHJUmEmcBWyaiPE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Aug 27, 2022 at 10:49:44PM +0800, Hawkins Jiawei wrote:
> >
> > And as for the root cause for use-after-free read, I think it is the
> > ctx->attr->length to be blamed.
> Apologize for my typing error, it is the ctx->attr should be blamed:
> 

Yep.  Both patches are required.

regards,
dan carpenter