Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3049215rwe; Mon, 29 Aug 2022 05:08:31 -0700 (PDT) X-Google-Smtp-Source: AA6agR4Xupw6Cl0aTSvPhhsG/iAu2OYR2A934jQ7YLjGJq9B5qvyQZoH1eE3T4NMSxYrxXcvNgMq X-Received: by 2002:a05:6402:240d:b0:442:b0c4:9e02 with SMTP id t13-20020a056402240d00b00442b0c49e02mr16360255eda.210.1661774911678; Mon, 29 Aug 2022 05:08:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661774911; cv=none; d=google.com; s=arc-20160816; b=MT2Iy3uq4q7Pz8Rr5OhyrwenVEknZCMFtdAY+z+OTwQCOhB/erYG5dmv/1nft4goDe 1JIkx4mQjPwHgItebLj3oFKLei3pvO0dMim7C8KrGIFnN4pqErIIBINSxKRzgBpZxW6j ypjhI6Ur/PBAvR1X2+nkKd0FSwScxf0WX6fIhurhQkePlXA4iD1qveme54IX/AD033j7 UWrrQsIKTVy5xvxYT8JCS6mrtUcDY05IuysuaVpm9SY2hxQYjpqDDsHHVWlPwBfOirGm HRZAmmZzq1NDhRz390oTfyrIq30Awz6NSR350UCOsF2EpWSah9fgl+qr8Y42Ky1cb0q2 FXTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QjvP6ZV6bbNv2Dp9W+WRSFk/mMMzOalRHgTwtAhlchk=; b=vFkaP9jMCo1UGVVDPM0c9tYKEzf3j99nd3hohm7vCfySQy74Ij7dfnHVQYxUtLbP61 ZYzSZj6UyLYd4p7GSRDSmIaDe46dzoZEevWH3iEwZLpWR/MCP5WgRrWPXq9U/rRs3wpc wNnd5Tgc9Vi4my9CcB+VpPsSWVbnSc1fQ097HxiWws0PM37D05TPpwlEaiWh3Df5KIgX S8dMC4wm7feRjjvOhYH+3lSw+QP5NJAaTEmNUjsMlUb1qu2dusNmEVnSuKROr1i0/1Hf sX/bNYgLbd5jHpACMiQTamoegq6ivV4o3s1mp1GmGCOATxyqVyjkGP9tOgwtjCCpJxUm oI7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YabyQDof; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb11-20020a170907160b00b007313314bb73si6292320ejc.806.2022.08.29.05.08.01; Mon, 29 Aug 2022 05:08:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YabyQDof; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231985AbiH2LZr (ORCPT + 99 others); Mon, 29 Aug 2022 07:25:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232018AbiH2LXy (ORCPT ); Mon, 29 Aug 2022 07:23:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D9972C67E; Mon, 29 Aug 2022 04:15:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 76389B80F91; Mon, 29 Aug 2022 11:07:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3B0CC433D6; Mon, 29 Aug 2022 11:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661771261; bh=dYzrEy0JL2Yge+1xE4zJCRSulIl0IZUKNJKzOgvPSrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YabyQDofyd1d7TH+BGAm3dIjIYtwKJFtA0wwGM80ZOA+1qFvpa5biWPOCcrXYREpD IUA9NOqXVdUK+nzn+kjpcMdpyb/z8IpG9EsAiQC0u0HgiCGrhwlrQWc6mNbY0qFxDw pWiJQiRYKxrWDuFfIuCYKLHSquXb4qGJmL7Xnhe8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gwangun Jung , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 5.15 067/136] netfilter: nf_tables: disallow binding to already bound chain Date: Mon, 29 Aug 2022 12:58:54 +0200 Message-Id: <20220829105807.382365862@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220829105804.609007228@linuxfoundation.org> References: <20220829105804.609007228@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pablo Neira Ayuso [ Upstream commit e02f0d3970404bfea385b6edb86f2d936db0ea2b ] Update nft_data_init() to report EINVAL if chain is already bound. Fixes: d0e2c7de92c7 ("netfilter: nf_tables: add NFT_CHAIN_BINDING") Reported-by: Gwangun Jung Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nf_tables_api.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 8bc4460b627ae..d8ca55d6be409 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -9505,6 +9505,8 @@ static int nft_verdict_init(const struct nft_ctx *ctx, struct nft_data *data, return PTR_ERR(chain); if (nft_is_base_chain(chain)) return -EOPNOTSUPP; + if (nft_chain_is_bound(chain)) + return -EINVAL; if (desc->flags & NFT_DATA_DESC_SETELEM && chain->flags & NFT_CHAIN_BINDING) return -EINVAL; -- 2.35.1