Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3050661rwe; Mon, 29 Aug 2022 05:09:43 -0700 (PDT) X-Google-Smtp-Source: AA6agR76DAfIrlHnkhm8nelCMz3VLjm584KY/c8x2rAmbmqHkwGI7G3oMdlUOStrxi5m/Sb7e+N6 X-Received: by 2002:a17:907:9814:b0:73d:cb9f:c0b8 with SMTP id ji20-20020a170907981400b0073dcb9fc0b8mr13602917ejc.648.1661774983357; Mon, 29 Aug 2022 05:09:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661774983; cv=none; d=google.com; s=arc-20160816; b=APDGxNp4gdE/Q6fmm1aQSzRZvUzZInR8t/MX6eEQ5acNS+esrvc1IMDJVT/ipe3SXy U54SGeLlFRMzVBiOz57ExtQd3+L+8hapPAkEstYRQlhhSF7XP18pY7hshBeWM488kdxr 1AA8lT4QFat7C2HiOjhppdhkwmgvTIUyYlueCFMBKmmACQr0J9Ha4YrHjJNELgkoqmhY /8o7HoYSgZZsGHXZ8q7mcGrHGTOR/Xdrb7gG9S4tgcHo5Kl95h0SFXrHCTSVp8GWSZMX 8Ds7EnVtHGOn2hpr3UorXa7YBjjZPK6a+ToHHTfEvqpUB7m5gNV7m9vEiz0WDKHFqZ6m dUCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=KoJwoj6+HQp4A3I2mmqO1r+wuei2YtT38ACk85WUR7s=; b=lJMkHOpKLdygFqLjMl0OM9/k8JR9ShlAzRTaOkhrNBBPy2LpHc/rJjPUEK5gPZLGHt FUiUY3SPb7lcXX6W2mQXzc3ftkOSDHYLm8lk6L8T1HGbGqxKAZifMXJIiB6i2UvDTPX9 EJ2EVFrDRGZQRl3ieFcMSsDiJ8j24nxzfEv2V/dxXSXpAu9lOuM+vcextrzJCamvtx/i F0BmqHcwIiVm/ZjDXQMCKgkOS9pslGhUXmK2QPI5D/3/3jZ9pCU7VvGeVjvcjj8H186s C28rExuFP0rueRPrR1Nef35wVLOeg0cTYxLVhjxrBwbPy7+01AMH2pPBZrUypGO5ocwQ 7rlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YQNAowDh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eh13-20020a0564020f8d00b004472b35d7a5si5689434edb.309.2022.08.29.05.09.16; Mon, 29 Aug 2022 05:09:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YQNAowDh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232180AbiH2L1G (ORCPT + 99 others); Mon, 29 Aug 2022 07:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231681AbiH2LYr (ORCPT ); Mon, 29 Aug 2022 07:24:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3769A7677F; Mon, 29 Aug 2022 04:15:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2ED83B80F00; Mon, 29 Aug 2022 11:15:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71FA5C433C1; Mon, 29 Aug 2022 11:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661771724; bh=Ywpm/N3wNiOfJT9MgHTXXtCudCMFssgoOA1F3CJyNtY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YQNAowDhyj0Z4vtQHJU7Ap+O100PJbnOM7UFjot7mkyTtj4M7zQ+hyAIaxP27VYsS 7tk2umdYJwN/qQHEUXUEZk+wZn2YsTowxm84SDu/vs4u5NlYMHlgJxXXJBGghTkQs1 ht3FnCFS1dEmtpKGcaXAnCcG/EMLVHZhHC8Gf97Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Guoqing Jiang , Song Liu Subject: [PATCH 5.15 122/136] Revert "md-raid: destroy the bitmap after destroying the thread" Date: Mon, 29 Aug 2022 12:59:49 +0200 Message-Id: <20220829105809.688502811@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220829105804.609007228@linuxfoundation.org> References: <20220829105804.609007228@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guoqing Jiang commit 1d258758cf06a0734482989911d184dd5837ed4e upstream. This reverts commit e151db8ecfb019b7da31d076130a794574c89f6f. Because it obviously breaks clustered raid as noticed by Neil though it fixed KASAN issue for dm-raid, let's revert it and fix KASAN issue in next commit. [1]. https://lore.kernel.org/linux-raid/a6657e08-b6a7-358b-2d2a-0ac37d49d23a@linux.dev/T/#m95ac225cab7409f66c295772483d091084a6d470 Fixes: e151db8ecfb0 ("md-raid: destroy the bitmap after destroying the thread") Signed-off-by: Guoqing Jiang Signed-off-by: Song Liu Signed-off-by: Greg Kroah-Hartman --- drivers/md/md.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -6251,11 +6251,11 @@ static void mddev_detach(struct mddev *m static void __md_stop(struct mddev *mddev) { struct md_personality *pers = mddev->pers; + md_bitmap_destroy(mddev); mddev_detach(mddev); /* Ensure ->event_work is done */ if (mddev->event_work.func) flush_workqueue(md_misc_wq); - md_bitmap_destroy(mddev); spin_lock(&mddev->lock); mddev->pers = NULL; spin_unlock(&mddev->lock);