Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 13:16:40 +0200
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
        "Alexander Lobakin" <alexandr.lobakin@intel.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        "Sasha Levin" <sashal@kernel.org>
Subject: Re: [PATCH 5.15 042/136] ice: xsk: Force rings to be sized to power
 of 2
Message-ID: <YwygGA09Qtddbgw6@boxer>
References: <20220829105804.609007228@linuxfoundation.org>
 <20220829105806.324347516@linuxfoundation.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220829105806.324347516@linuxfoundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vWeh7uUiCKRSSDdBX+zW7YcMkUocUDTN024zMDdIPywygrHPDAosOVhYn7r2?=
 =?us-ascii?Q?SZyW2RNK7duojkT9+4OxcvU0TMsdCxfbTbJ2VWP07aG+MZ1HdbFMNfygwsvK?=
 =?us-ascii?Q?6LP4PgImmxs3XSOHvIeqXkkkqPcLe1hQpTAn/kM8DsmPXbzMiKHNsjozOIAw?=
 =?us-ascii?Q?EfZtHZMht1ZWXN4fhGTPnyQ2dFK9NIw+DRGzEHIfGIresIOiG0v2N2BsImNt?=
 =?us-ascii?Q?oLyd44lqjwILbCqn1wMsOvZSOv7CRAmJOaVJ5sYxf3g3Qs+xz7JedjYmrQ03?=
 =?us-ascii?Q?fQxXdOBUmn3NQ1i84kadXY9IAQnHXkP74aK5GgofvexTkEtby3jeUyVGJ+BC?=
 =?us-ascii?Q?gG98haY6OReF2OEtHU5ZRB1/SjJJcY8UD4KsLXW4CwKKqYUWRZoCureZheiT?=
 =?us-ascii?Q?pAmNJpwiYSVr65dVvzc8KeKKQpX2oOYFGXNjt0tI7AGW3Hj+Wf5oNY0+aTTJ?=
 =?us-ascii?Q?y33UEI5IY05YLDZbJyp+VGHqKk5l3/3eoKF62Q64vpKaSv3cUD3tRoWUdy73?=
 =?us-ascii?Q?f09fLXXXMqaEC/heOvm7QOaXs7jShm+XyCMvK8gwq+b/XtyYcmoLtwxMn7b0?=
 =?us-ascii?Q?7o/mwLgzv47S5uendB33urx5aIeCpuQaHt34U/fKs4YOtNU/GBalWWvHckDy?=
 =?us-ascii?Q?ZLCqDXr1Jev1GQyL0t4GQQFNwrediuufTsdF2TaLaUfNXJl3T79Nql3+9jNY?=
 =?us-ascii?Q?g+ZV+hpIUco0Dv+KgLTlI3kIDIHeoVwmuGNne3kNUKzReWp0KfJushEaAVcE?=
 =?us-ascii?Q?zG+JJx47srbfvZLZD3jWr5VRf9DGyFr/OpQrfgmjmj2DLsF2D64z2ATB4sr1?=
 =?us-ascii?Q?pzdhMQoss1ADdMBl+MSZqKiqwGozw3qJ17LzBO1gQktF7gAB0v6Zs7ttRQA+?=
 =?us-ascii?Q?q0Iim1aRluxmUmO4dVG7kWmHDXJcHPiQHr9NSa89uTG14tQldRzJL6/LnmGR?=
 =?us-ascii?Q?40hNParmI0ZUYm//bdI/a52Ow/H+M0jdyKNnIibHpWuLEOqEcfqf04nQ1EhD?=
 =?us-ascii?Q?8F3P77Lf5wxadPztCGqkmZTBTGO84ouGal7JNdW4aOI3GZbGOxL8CyNFvReL?=
 =?us-ascii?Q?DBmc5xPAvtrU17+xk/+rIltLks5OK5DpDdHI7Dzr9rHfzj0Q4j7Jlu6b2YB1?=
 =?us-ascii?Q?ThkgyrHr1J1yd1ftFmyVivgDj3+RSuM/CrD0zec3QaRr6eeTs8eRLtoT80Xn?=
 =?us-ascii?Q?9E/O2QFzw1Gd/ESo3oc9UT1Q7Wta8ycQgYj7Yx7deYO1uYHCV19d1YhHUB5z?=
 =?us-ascii?Q?Uhcm+8FU3Ri/vT56ZamXuJWm7u/bLBtbqrjLmtDgK5wU5elHY4AHMd2HVPyi?=
 =?us-ascii?Q?nRRFrgdwELDVFmQROl7PwD795G7En5hkMmPa8vPuJoEi1813KLYc5B7QVaru?=
 =?us-ascii?Q?UDpTJhvxF7y/b+qQE7ey1ciRGmXgMbi0UxHl/cAMdw0nNibVe4NUOzZL3fyp?=
 =?us-ascii?Q?f3J70zAn4O1fWIS0rrpGRaB29M3xLP/OdZj3QjmzKMsdKjc91oFqqUE+5YtM?=
 =?us-ascii?Q?te2DvKHhS9FPLWaOTkgCU/LkUltkSM3DWSde/KN2nAwC+26Irq5DvWN0OK+V?=
 =?us-ascii?Q?JCQukZklcwqY4pMOBUCD1iMnLKDGVbmVbshNhLxmvRhq4W2xUbTvLlU81qWE?=
 =?us-ascii?Q?bQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 51e30f43-65ec-46a9-f2fe-08da89aff56f
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 11:16:45.7164
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +9n13LTa0iLD1JSXr8ucaoKJmF6yhGj7mxemJaa2Xn9yI+GkSizf9pGNJ131FaFpZXxMO7jJxxc3jJNEbYtkmNSUwQKmmFzNBpcx6iBjBjQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2330
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 29, 2022 at 12:58:29PM +0200, Greg Kroah-Hartman wrote:
> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> 
> [ Upstream commit 296f13ff3854535009a185aaf8e3603266d39d94 ]
> 
> With the upcoming introduction of batching to XSK data path,
> performance wise it will be the best to have the ring descriptor count
> to be aligned to power of 2.
> 
> Check if ring sizes that user is going to attach the XSK socket fulfill
> the condition above. For Tx side, although check is being done against
> the Tx queue and in the end the socket will be attached to the XDP
> queue, it is fine since XDP queues get the ring->count setting from Tx
> queues.

Hi Greg,

We had multiple customers reporting that this change makes them unable to
use max ring size which is 8160 for this particular driver (which is not a
power of 2 obviously) so we are about to send a patch that will drop this
limitation.

To avoid the double work, can you please not proceed with this one?
The other two:
ice: xsk: prohibit usage of non-balanced queue id
ice: xsk: use Rx rings XDP ring when picking NAPI context

are valid and needed.

FWIW this was a part of -next patch set, so I suppose you picked this due
to some dependency?

Thanks,
Maciej

> 
> Suggested-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
> Link: https://lore.kernel.org/bpf/20220125160446.78976-3-maciej.fijalkowski@intel.com
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/net/ethernet/intel/ice/ice_xsk.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c
> index 5581747947e57..0348cc4265034 100644
> --- a/drivers/net/ethernet/intel/ice/ice_xsk.c
> +++ b/drivers/net/ethernet/intel/ice/ice_xsk.c
> @@ -321,6 +321,13 @@ int ice_xsk_pool_setup(struct ice_vsi *vsi, struct xsk_buff_pool *pool, u16 qid)
>  	bool if_running, pool_present = !!pool;
>  	int ret = 0, pool_failure = 0;
>  
> +	if (!is_power_of_2(vsi->rx_rings[qid]->count) ||
> +	    !is_power_of_2(vsi->tx_rings[qid]->count)) {
> +		netdev_err(vsi->netdev, "Please align ring sizes to power of 2\n");
> +		pool_failure = -EINVAL;
> +		goto failure;
> +	}
> +
>  	if_running = netif_running(vsi->netdev) && ice_is_xdp_ena_vsi(vsi);
>  
>  	if (if_running) {
> @@ -343,6 +350,7 @@ int ice_xsk_pool_setup(struct ice_vsi *vsi, struct xsk_buff_pool *pool, u16 qid)
>  			netdev_err(vsi->netdev, "ice_qp_ena error = %d\n", ret);
>  	}
>  
> +failure:
>  	if (pool_failure) {
>  		netdev_err(vsi->netdev, "Could not %sable buffer pool, error = %d\n",
>  			   pool_present ? "en" : "dis", pool_failure);
> -- 
> 2.35.1
> 
> 
>