Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3056507rwe; Mon, 29 Aug 2022 05:14:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR58tYuD6YoLZzMvAF02OClMVVmIG6g7whd9/KUxnYeaWgksoG+D4n19Pu/HpcBiYF2RV8m0 X-Received: by 2002:a17:90b:4c0b:b0:1f5:b72:3b0b with SMTP id na11-20020a17090b4c0b00b001f50b723b0bmr17837972pjb.227.1661775287775; Mon, 29 Aug 2022 05:14:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661775287; cv=none; d=google.com; s=arc-20160816; b=L0wx5OuJ8pPoU7lwACP9Pb0CVWRw9UIKN8xMsg+5qib7WIIN9TQKkpzRimAVA8oMHt h73B2QfY2RmRTKdjm3cmfhG/TplbSlLV9ce2Yyf9fEcZgRKVszFjgTxLxPfnfHKepHNv Fq48UWV/KWFib5cNPNVqCmSW6ofJbtgIJg1j8yltq/YQ1ScSTr4ptjM5V0eJMpXWOMH1 vNH9mjATCtf+YY07jeoV+YfuV3j4vpYrYmG7Acx6vDiH76mCVSTQTrUmHu8rgLIGCbEV AGE2r5BDpSX6ZxAdUuuwCr0mHQAsq1IovVFlmwaUkBvPM6i8lhZLrjTpPRE1r2Vyu+WJ XTxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QDLx1Iwkm/zMpsblrD5jnFDwj+UI1Jl81WpYOuwsUSQ=; b=D31U/XOOGsVm/7sxNBhxLZCo1hSwqYBr1WjuwZZtu6SiiysjEJ5ZQ4Bg+rKH3o3rHG 74SIt5AMO0ewq0KhD31bptE50A5uPq+LQnLxE+vjoedH5avWe2RmEZSHdollAby4Md+6 dy1krJg+2qpmvL2AplV3ARJK/lIInH/BBaWGI4Y0czfCV8HyCuT8nLcLSvIXkkN8HgXc a/UTbnYfp2S+XP8ggB7447HvoaioPyYpp1bvmhQpppT61esnnvMnaiZC/LbMQNaU3f3V Bh7BSxhbdGKzQmAfLv7UQUQYBwq6b/3iI/kCZEqtihiZXhRP7itst7EmF2G5PVbPgL3a A28Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vwDlQMIQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gj16-20020a17090b109000b001fd8abd1cdcsi5738560pjb.82.2022.08.29.05.14.36; Mon, 29 Aug 2022 05:14:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vwDlQMIQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232989AbiH2Lng (ORCPT + 99 others); Mon, 29 Aug 2022 07:43:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232969AbiH2LnG (ORCPT ); Mon, 29 Aug 2022 07:43:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC67585AB2; Mon, 29 Aug 2022 04:27:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8BF6E61231; Mon, 29 Aug 2022 11:13:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97FEEC433D6; Mon, 29 Aug 2022 11:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661771634; bh=fd2B/jkW98W9XGlcOE2Qih4zdW0I/EfQnMIYTXhDY5c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vwDlQMIQPKj3M9RizvAb2r3mcBbykrZLLYAJjF3N9aCqvKfTNIW6d3W2svmX6J4mo fFsidxAYAuG0WLn20ViseEbH1x7yRlqoJy0NxdgHZg+Xbl/wIF1Mh3dDTEE3tDkMTw /BGIeB2xIOq2WRvOZhwaRzTKVdwuVGHU5IPraUXo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vikas Gupta , Michael Chan , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.19 053/158] bnxt_en: fix NQ resource accounting during vf creation on 57500 chips Date: Mon, 29 Aug 2022 12:58:23 +0200 Message-Id: <20220829105810.954627849@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220829105808.828227973@linuxfoundation.org> References: <20220829105808.828227973@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vikas Gupta [ Upstream commit 09a89cc59ad67794a11e1d3dd13c5b3172adcc51 ] There are 2 issues: 1. We should decrement hw_resc->max_nqs instead of hw_resc->max_irqs with the number of NQs assigned to the VFs. The IRQs are fixed on each function and cannot be re-assigned. Only the NQs are being assigned to the VFs. 2. vf_msix is the total number of NQs to be assigned to the VFs. So we should decrement vf_msix from hw_resc->max_nqs. Fixes: b16b68918674 ("bnxt_en: Add SR-IOV support for 57500 chips.") Signed-off-by: Vikas Gupta Signed-off-by: Michael Chan Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c index a1a2c7a64fd58..c9cf0569451a2 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c @@ -623,7 +623,7 @@ static int bnxt_hwrm_func_vf_resc_cfg(struct bnxt *bp, int num_vfs, bool reset) hw_resc->max_stat_ctxs -= le16_to_cpu(req->min_stat_ctx) * n; hw_resc->max_vnics -= le16_to_cpu(req->min_vnics) * n; if (bp->flags & BNXT_FLAG_CHIP_P5) - hw_resc->max_irqs -= vf_msix * n; + hw_resc->max_nqs -= vf_msix; rc = pf->active_vfs; } -- 2.35.1