Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3061881rwe; Mon, 29 Aug 2022 05:19:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ACvgSGXU53M/Nrlcs3WzMxgPc4EHXc5dTFI79IXFa1T1/JO1y7kltIBmDU4CYVN2HHkA3 X-Received: by 2002:a05:6402:1706:b0:448:1b9f:d8bd with SMTP id y6-20020a056402170600b004481b9fd8bdmr8493576edu.397.1661775567361; Mon, 29 Aug 2022 05:19:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661775567; cv=none; d=google.com; s=arc-20160816; b=SPXAurawM/U502M8+qUE6NsUGDN2+8vHeZ5EMG4wFwzy1K6umm3CSXWvKHuUp5NxDa vABvApE3F1Qs7WKUOHo/bY4khpq3UrkbjfDiyamh0G0NQX9/arQqD7fHgBhWV691CiIY G7jkYGesKsdPuxMbkqeIX4Y5mGw0CeJxxmhWTy9aM2Z1edWzL4pSJ+Dh74sk2tg3ibA2 xe0vNrQ4qvQXQOJudnY/tpbT0lXEB8SUd/Jkf6J2kPGFKscUdO1IAJMGJYpw/lu5BxvU 9KXFeLqI6784lfubcSsVNgoWFw6PHya05iwEGMKEegPm9rr0FkQBFh5pbKLjHrwUfHfj 0OnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=wgyZr38fR7+7wMS/JcKUanSzKNvy+Wbv92Ect1Ewc6c=; b=EIDkohr4YZKAoLQ7boPGErG+d4lqIeawAMIyQZ+5VAW1jj6OOu/G/kTNCVHZ0xDyK5 tmkure1bbWMnliMgmh071rXy2z1IB30TBQwJZ7eV0V0t0OXmuvadF3zFlBYXzd013hmC V5LQ+auN2ju/wHFbj2knppHOFTDCasJPUkVYmhWsC6K1tcgUXikt5SaYdtN3fG8nkESY cL6k4p8/NNdXsoyr1MbNo8A4jF1xjpVoBgKYpRimi4h1iOAyXov3nH1hsvqWNqExsUXt wcqwiVtJeYu8JUM3z1muHGiR2zOV2XG+zNReCkgPZ1lrYOGhwrtF85bKyiRDqqP5uoRn NEdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dp20-20020a170906c15400b007262ad8839esi7185364ejc.16.2022.08.29.05.19.01; Mon, 29 Aug 2022 05:19:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229507AbiH2MPw (ORCPT + 99 others); Mon, 29 Aug 2022 08:15:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229977AbiH2MPa (ORCPT ); Mon, 29 Aug 2022 08:15:30 -0400 Received: from mail.nfschina.com (unknown [IPv6:2400:dd01:100f:2:72e2:84ff:fe10:5f45]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5134C832DF; Mon, 29 Aug 2022 04:59:23 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id C4E821E80D90; Mon, 29 Aug 2022 19:26:48 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M6hgVIKQLa_j; Mon, 29 Aug 2022 19:26:46 +0800 (CST) Received: from [172.30.38.131] (unknown [180.167.10.98]) (Authenticated sender: liqiong@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id 8AB451E80D59; Mon, 29 Aug 2022 19:26:44 +0800 (CST) Subject: Re: [PATCH] wifi: cfg80211: add error code in brcmf_notify_sched_scan_results() To: Arend Van Spriel , Kalle Valo , "David S . Miller" , Eric Dumazet , Jakub Kicinski Cc: Franky Lin , Hante Meuleman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Zhe References: <20220829065831.14023-1-liqiong@nfschina.com> From: liqiong Message-ID: <6b8c94c3-2c8d-a222-67ec-4461615185e1@nfschina.com> Date: Mon, 29 Aug 2022 19:31:25 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022年08月29日 16:51, Arend Van Spriel 写道: > On 8/29/2022 8:58 AM, Li Qiong wrote: >> The err code is 0 at the first two "out_err" paths, add error code >> '-EINVAL' for these error paths. > > There is no added value provided in this change. There is an error message, but it is otherwise silently ignored as there is no additional fault handling required. It should be better to fix the return code, and It seems that the code has been checked, eg: if (ifp->drvr->fweh.evt_handler[i]) { ..... } > > Regards, > Arend > >> Signed-off-by: Li Qiong >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++ >> 1 file changed, 2 insertions(+)