Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3099822rwe; Mon, 29 Aug 2022 05:58:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR5iuvy9pvhkxQ0lwSzYsbNC3d8JUkXxYSZN9LG6DduqaTcT7Sg31/THaY+EzsaMfpKaFnmw X-Received: by 2002:a05:6402:5024:b0:440:e4ad:f7b6 with SMTP id p36-20020a056402502400b00440e4adf7b6mr16583048eda.358.1661777927065; Mon, 29 Aug 2022 05:58:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661777927; cv=none; d=google.com; s=arc-20160816; b=kj3H1oQRCsTrKu7432fsBsEnhKdbDkeCTu+FJx7ttXbRRT/U51yhzcRs7fua4MDokt IUWYWycaFSm+UQxBwLlHwUYSpuEVgY/Lbl4m0L4s5RTPOuq7lcEQ6BewfVEG7+uU8yCx aLCOiknl4PDK8s24fwAfi30gnB2ziSlGE2q+aPElBBDPT2VPm79zY05Og4DNt2d6O6x4 VTpS0iZb9KrA65bTXVzoH8B85HDInoevX367R+hgdWMN1xja0UrH0F1uhnqJHowKHIQd ACl+xlGahxcSoxYjII+v3A05UD56KKfUxrjiNysINe3bQ2oIshz3IrqlkfCRav4d4iah BHEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=DIzBXvxSqVSHI/HC2vXzjp0OxsYZkWnly17VLzGI69k=; b=zk6j4xo+9ZklTGQoemldnVJpStYr7+FqkXQIwrN6K//9YF5CcEasoiOQw+lnoiKNm5 p33YLF5nkWtTHyJYh5KS/jV2e+DZzsj41xCPAbFkFlAHmu5ByUrsqv4Lm0LGM+bv91My nhoFUGwFUUKC2pBOFHH7/EHffgyr5Kj5agzpciycAZiOmT2xSlY8EkyUDLdInOI5Nw4z mad5eEw2RA3m0SJxWoQzIJknOTiTS04ntvyDufTDRAms4hEd6VweVeCSU9grsrvHu26f VcZk6ZvIAmj2Qt3BuK3GOTxatg0L+oloUTZiV3HL46UZnJGfrfZnyzdIoMqrqHgaL5BG W6lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rn20-20020a170906d93400b0073d8830e4c7si5581131ejb.954.2022.08.29.05.58.20; Mon, 29 Aug 2022 05:58:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbiH2Mu4 (ORCPT + 99 others); Mon, 29 Aug 2022 08:50:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229846AbiH2Mu1 (ORCPT ); Mon, 29 Aug 2022 08:50:27 -0400 Received: from outbound-smtp51.blacknight.com (outbound-smtp51.blacknight.com [46.22.136.235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A851B6567A for ; Mon, 29 Aug 2022 05:37:05 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp51.blacknight.com (Postfix) with ESMTPS id A362EFAADE for ; Mon, 29 Aug 2022 13:37:03 +0100 (IST) Received: (qmail 11672 invoked from network); 29 Aug 2022 12:37:03 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Aug 2022 12:37:03 -0000 Date: Mon, 29 Aug 2022 13:36:59 +0100 From: Mel Gorman To: Abel Wu Cc: Peter Zijlstra , Mel Gorman , Vincent Guittot , Josh Don , Chen Yu , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] sched/fair: avoid double search on same cpu Message-ID: <20220829123659.xoeerauu72nrs7x4@techsingularity.net> References: <20220712082036.5130-1-wuyun.abel@bytedance.com> <20220712082036.5130-5-wuyun.abel@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20220712082036.5130-5-wuyun.abel@bytedance.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2022 at 04:20:35PM +0800, Abel Wu wrote: > The prev cpu is checked at the beginning of SIS, and it's unlikely > to be idle before the second check in select_idle_smt(). So we'd > better focus on its SMT siblings. > > Signed-off-by: Abel Wu > Reviewed-by: Josh Don Acked-by: Mel Gorman -- Mel Gorman SUSE Labs