Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
From:   Maxime Ripard <maxime@cerno.tech>
To:     Maxime Ripard <mripard@kernel.org>,
        Ben Skeggs <bskeggs@redhat.com>,
        David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Lyude Paul <lyude@redhat.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Karol Herbst <kherbst@redhat.com>,
        =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= <noralf@tronnes.org>,
        Emma Anholt <emma@anholt.net>, Daniel Vetter <daniel@ffwll.ch>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc:     Maxime Ripard <maxime@cerno.tech>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-arm-kernel@lists.infradead.org,
        Phil Elwell <phil@raspberrypi.com>,
        intel-gfx@lists.freedesktop.org,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        dri-devel@lists.freedesktop.org, Dom Cobley <dom@raspberrypi.com>,
        linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
        linux-sunxi@lists.linux.dev,
        Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH v2 23/41] drm/atomic-helper: Add an analog TV atomic_check implementation
Date:   Mon, 29 Aug 2022 15:11:37 +0200
Message-Id: <20220728-rpi-analog-tv-properties-v2-23-459522d653a7@cerno.tech>
In-Reply-To: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech>
References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

The analog TV connector drivers share some atomic_check logic, and the new=
=0D
TV standard property have created a bunch of new constraints that needs to=
=0D
be shared across drivers too.=0D
=0D
Let's create an atomic_check helper for those use cases.=0D
=0D
Signed-off-by: Maxime Ripard <maxime@cerno.tech>=0D
=0D
diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/dr=
m_atomic_state_helper.c=0D
index 0373c3dc824b..d64733c6aae3 100644=0D
--- a/drivers/gpu/drm/drm_atomic_state_helper.c=0D
+++ b/drivers/gpu/drm/drm_atomic_state_helper.c=0D
@@ -556,6 +556,42 @@ void drm_atomic_helper_connector_tv_reset(struct drm_c=
onnector *connector)=0D
 }=0D
 EXPORT_SYMBOL(drm_atomic_helper_connector_tv_reset);=0D
 =0D
+/**=0D
+ * @drm_atomic_helper_connector_tv_check: Validate an analog TV connector =
state=0D
+ * @connector: DRM Connector=0D
+ * @state: the DRM State object=0D
+ *=0D
+ * Checks the state object to see if the requested state is valid for an=0D
+ * analog TV connector.=0D
+ *=0D
+ * Returns:=0D
+ * Zero for success, a negative error code on error.=0D
+ */=0D
+int drm_atomic_helper_connector_tv_check(struct drm_connector *connector,=
=0D
+					 struct drm_atomic_state *state)=0D
+{=0D
+	struct drm_connector_state *old_conn_state =3D=0D
+		drm_atomic_get_old_connector_state(state, connector);=0D
+	struct drm_connector_state *new_conn_state =3D=0D
+		drm_atomic_get_new_connector_state(state, connector);=0D
+	struct drm_crtc_state *crtc_state;=0D
+	struct drm_crtc *crtc;=0D
+=0D
+	crtc =3D new_conn_state->crtc;=0D
+	if (!crtc)=0D
+		return 0;=0D
+=0D
+	crtc_state =3D drm_atomic_get_new_crtc_state(state, crtc);=0D
+	if (!crtc_state)=0D
+		return -EINVAL;=0D
+=0D
+	if (old_conn_state->tv.mode !=3D new_conn_state->tv.mode)=0D
+		crtc_state->mode_changed =3D true;=0D
+=0D
+	return 0;=0D
+}=0D
+EXPORT_SYMBOL(drm_atomic_helper_connector_tv_check);=0D
+=0D
 /**=0D
  * __drm_atomic_helper_connector_duplicate_state - copy atomic connector s=
tate=0D
  * @connector: connector object=0D
diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic=
_state_helper.h=0D
index c8fbce795ee7..b9740edb2658 100644=0D
--- a/include/drm/drm_atomic_state_helper.h=0D
+++ b/include/drm/drm_atomic_state_helper.h=0D
@@ -26,6 +26,7 @@=0D
 =0D
 #include <linux/types.h>=0D
 =0D
+struct drm_atomic_state;=0D
 struct drm_bridge;=0D
 struct drm_bridge_state;=0D
 struct drm_crtc;=0D
@@ -71,6 +72,8 @@ void __drm_atomic_helper_connector_reset(struct drm_conne=
ctor *connector,=0D
 					 struct drm_connector_state *conn_state);=0D
 void drm_atomic_helper_connector_reset(struct drm_connector *connector);=0D
 void drm_atomic_helper_connector_tv_reset(struct drm_connector *connector)=
;=0D
+int drm_atomic_helper_connector_tv_check(struct drm_connector *connector,=
=0D
+					 struct drm_atomic_state *state);=0D
 void drm_atomic_helper_connector_tv_margins_reset(struct drm_connector *co=
nnector);=0D
 void=0D
 __drm_atomic_helper_connector_duplicate_state(struct drm_connector *connec=
tor,=0D
=0D
-- =0D
b4 0.10.0-dev-65ba7=0D