Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
From:   Maxime Ripard <maxime@cerno.tech>
To:     Maxime Ripard <mripard@kernel.org>,
        Ben Skeggs <bskeggs@redhat.com>,
        David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Lyude Paul <lyude@redhat.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Karol Herbst <kherbst@redhat.com>,
        =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= <noralf@tronnes.org>,
        Emma Anholt <emma@anholt.net>, Daniel Vetter <daniel@ffwll.ch>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc:     Maxime Ripard <maxime@cerno.tech>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-arm-kernel@lists.infradead.org,
        Phil Elwell <phil@raspberrypi.com>,
        intel-gfx@lists.freedesktop.org,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        dri-devel@lists.freedesktop.org, Dom Cobley <dom@raspberrypi.com>,
        linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
        linux-sunxi@lists.linux.dev,
        Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH v2 17/41] drm/connector: Add pixel clock to cmdline mode
Date:   Mon, 29 Aug 2022 15:11:31 +0200
Message-Id: <20220728-rpi-analog-tv-properties-v2-17-459522d653a7@cerno.tech>
In-Reply-To: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech>
References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

We'll need to get the pixel clock to generate proper display modes for=0D
all the current named modes. Let's add it to struct drm_cmdline_mode and=0D
fill it when parsing the named mode.=0D
=0D
Signed-off-by: Maxime Ripard <maxime@cerno.tech>=0D
=0D
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c=0D
index 5e898699b532..73d01e755496 100644=0D
--- a/drivers/gpu/drm/drm_modes.c=0D
+++ b/drivers/gpu/drm/drm_modes.c=0D
@@ -2208,22 +2208,24 @@ static int drm_mode_parse_cmdline_options(const cha=
r *str,=0D
 =0D
 struct drm_named_mode {=0D
 	const char *name;=0D
+	unsigned int pixel_clock_khz;=0D
 	unsigned int xres;=0D
 	unsigned int yres;=0D
 	unsigned int flags;=0D
 };=0D
 =0D
-#define NAMED_MODE(_name, _x, _y, _flags)		\=0D
+#define NAMED_MODE(_name, _pclk, _x, _y, _flags)	\=0D
 	{						\=0D
 		.name =3D _name,				\=0D
+		.pixel_clock_khz =3D _pclk,		\=0D
 		.xres =3D _x,				\=0D
 		.yres =3D _y,				\=0D
 		.flags =3D _flags,			\=0D
 	}=0D
 =0D
 static const struct drm_named_mode drm_named_modes[] =3D {=0D
-	NAMED_MODE("NTSC", 720, 480, DRM_MODE_FLAG_INTERLACE),=0D
-	NAMED_MODE("PAL", 720, 576, DRM_MODE_FLAG_INTERLACE),=0D
+	NAMED_MODE("NTSC", 13500, 720, 480, DRM_MODE_FLAG_INTERLACE),=0D
+	NAMED_MODE("PAL", 13500, 720, 576, DRM_MODE_FLAG_INTERLACE),=0D
 };=0D
 =0D
 static int drm_mode_parse_cmdline_named_mode(const char *name,=0D
@@ -2265,6 +2267,7 @@ static int drm_mode_parse_cmdline_named_mode(const ch=
ar *name,=0D
 			continue;=0D
 =0D
 		strcpy(cmdline_mode->name, mode->name);=0D
+		cmdline_mode->pixel_clock =3D mode->pixel_clock_khz;=0D
 		cmdline_mode->xres =3D mode->xres;=0D
 		cmdline_mode->yres =3D mode->yres;=0D
 		cmdline_mode->interlace =3D !!(mode->flags & DRM_MODE_FLAG_INTERLACE);=0D
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h=0D
index 7d3881f35e7c..bb39d2bb806e 100644=0D
--- a/include/drm/drm_connector.h=0D
+++ b/include/drm/drm_connector.h=0D
@@ -1352,6 +1352,13 @@ struct drm_cmdline_mode {=0D
 	 */=0D
 	bool bpp_specified;=0D
 =0D
+	/**=0D
+	 * @pixel_clock:=0D
+	 *=0D
+	 * Pixel Clock in kHz. Optional.=0D
+	 */=0D
+	unsigned int pixel_clock;=0D
+=0D
 	/**=0D
 	 * @xres:=0D
 	 *=0D
=0D
-- =0D
b4 0.10.0-dev-65ba7=0D