Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
From:   Maxime Ripard <maxime@cerno.tech>
To:     Maxime Ripard <mripard@kernel.org>,
        Ben Skeggs <bskeggs@redhat.com>,
        David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Lyude Paul <lyude@redhat.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Karol Herbst <kherbst@redhat.com>,
        =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= <noralf@tronnes.org>,
        Emma Anholt <emma@anholt.net>, Daniel Vetter <daniel@ffwll.ch>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc:     Maxime Ripard <maxime@cerno.tech>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-arm-kernel@lists.infradead.org,
        Phil Elwell <phil@raspberrypi.com>,
        intel-gfx@lists.freedesktop.org,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        dri-devel@lists.freedesktop.org, Dom Cobley <dom@raspberrypi.com>,
        linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
        linux-sunxi@lists.linux.dev,
        Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH v2 31/41] drm/vc4: vec: Use TV Reset implementation
Date:   Mon, 29 Aug 2022 15:11:45 +0200
Message-Id: <20220728-rpi-analog-tv-properties-v2-31-459522d653a7@cerno.tech>
In-Reply-To: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech>
References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

The analog TV properties created by the drm_mode_create_tv_properties() are=
=0D
not properly initialised at reset. Let's switch our implementation to call=
=0D
drm_atomic_helper_connector_tv_reset().=0D
=0D
Signed-off-by: Maxime Ripard <maxime@cerno.tech>=0D
=0D
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c=
=0D
index fa85dd260742..ba6f81908923 100644=0D
--- a/drivers/gpu/drm/vc4/vc4_vec.c=0D
+++ b/drivers/gpu/drm/vc4/vc4_vec.c=0D
@@ -254,6 +254,12 @@ vc4_vec_connector_detect(struct drm_connector *connect=
or, bool force)=0D
 	return connector_status_unknown;=0D
 }=0D
 =0D
+static void vc4_vec_connector_reset(struct drm_connector *connector)=0D
+{=0D
+	drm_atomic_helper_connector_reset(connector);=0D
+	drm_atomic_helper_connector_tv_reset(connector);=0D
+}=0D
+=0D
 static int vc4_vec_connector_get_modes(struct drm_connector *connector)=0D
 {=0D
 	struct drm_connector_state *state =3D connector->state;=0D
@@ -274,7 +280,7 @@ static int vc4_vec_connector_get_modes(struct drm_conne=
ctor *connector)=0D
 static const struct drm_connector_funcs vc4_vec_connector_funcs =3D {=0D
 	.detect =3D vc4_vec_connector_detect,=0D
 	.fill_modes =3D drm_helper_probe_single_connector_modes,=0D
-	.reset =3D drm_atomic_helper_connector_reset,=0D
+	.reset =3D vc4_vec_connector_reset,=0D
 	.atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state,=
=0D
 	.atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state,=0D
 };=0D
=0D
-- =0D
b4 0.10.0-dev-65ba7=0D