Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220812205746.609107-1-mairacanal@riseup.net> <20220812205746.609107-2-mairacanal@riseup.net>
In-Reply-To: <20220812205746.609107-2-mairacanal@riseup.net>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Mon, 29 Aug 2022 15:51:20 +0200
Message-ID: <CAG3jFyuMF4+Zfu2eDrE96nO7EWfhhQE8a+VQ=HhJ+iLYaX8HZg@mail.gmail.com>
Subject: Re: [PATCH 1/5] drm/bridge: anx7625: Drop of_gpio header
To:     =?UTF-8?B?TWHDrXJhIENhbmFs?= <mairacanal@riseup.net>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Maxime Ripard <maxime@cerno.tech>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Maira,

On Fri, 12 Aug 2022 at 22:58, Ma=C3=ADra Canal <mairacanal@riseup.net> wrot=
e:
>
> This driver includes the deprecated OF GPIO header <linux/of_gpio.h>
> yet fail to use symbols from it, so drop the include.
>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Signed-off-by: Ma=C3=ADra Canal <mairacanal@riseup.net>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/=
bridge/analogix/anx7625.c
> index 79fc7a50b497..d7d4ca1c8b30 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -17,7 +17,6 @@
>  #include <linux/types.h>
>  #include <linux/workqueue.h>
>
> -#include <linux/of_gpio.h>
>  #include <linux/of_graph.h>
>  #include <linux/of_platform.h>
>
> --
> 2.37.1
>

This cleanup looks good to me.

Reviewed-by: Robert Foss <robert.foss@linar.org>