Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 16:21:35 +0200
From:   Sascha Hauer <s.hauer@pengutronix.de>
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     linux-gpio@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH 1/2] gpio: Add gpio latch driver
Message-ID: <20220829142135.GB24324@pengutronix.de>
References: <20220825094132.1268174-1-s.hauer@pengutronix.de>
 <20220825094132.1268174-2-s.hauer@pengutronix.de>
 <20220826055306.tdsmdambl6fjoiop@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826055306.tdsmdambl6fjoiop@pengutronix.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi Marco,

On Fri, Aug 26, 2022 at 07:53:07AM +0200, Marco Felsch wrote:
> Hi Sascha,
> 
> nice patche, please see inline.
> 
> On 22-08-25, Sascha Hauer wrote:
> > This driver implements a GPIO multiplexer based on latches connected to
> > other GPIOs. A set of data GPIOs is connected to the data input of
> > multiple latches. The clock input of each latch is driven by another
> > set of GPIOs. With two 8-bit latches 10 GPIOs can be multiplexed into
> > 16 GPIOs. GPOs might be a better term as in fact the multiplexed pins
> > are output only.
> > 

[snip]

> > +
> > +static void __gpio_latch_set(struct gpio_latch_priv *priv, unsigned int offset, int val)
> > +{
> > +	int latch = offset / priv->n_pins;
> > +	int i;
> > +
> > +	if (val)
> > +		priv->shadow[latch] |= BIT(offset % priv->n_pins);
> > +	else
> > +		priv->shadow[latch] &= ~BIT(offset % priv->n_pins);
> > +
> > +	for (i = 0; i < priv->n_pins; i++)
> > +		gpiod_set_value(priv->data_gpios->desc[i], priv->shadow[latch] & BIT(i));
> > +
> > +	gpiod_set_value(priv->clk_gpios->desc[latch], 1);
> > +	gpiod_set_value(priv->clk_gpios->desc[latch], 0);
> 
> Your have two access function for _can_sleep and "can not sleep" but
> here you don't resepect it.

I thought the gpio framework would pick the right implementation
automatically. Apparently it doesn't. Will fix in v2.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |