Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4ff2a310-c8ba-ccf2-8d51-5181b83685c7@loongson.cn>
Date:   Mon, 29 Aug 2022 22:34:17 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] LoongArch: Fix warning: #warning syscall fstat not
 implemented
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>, Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>
Cc:     loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
References: <1661766931-7277-1-git-send-email-yangtiezhu@loongson.cn>
 <d1a52fa2-380a-421b-8c46-5150a39be484@www.fastmail.com>
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
In-Reply-To: <d1a52fa2-380a-421b-8c46-5150a39be484@www.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/29/22 19:36, Arnd Bergmann wrote:
> On Mon, Aug 29, 2022, at 11:55 AM, Tiezhu Yang wrote:
> 
>>    CALL    scripts/checksyscalls.sh
>> <stdin>:569:2: warning: #warning syscall fstat not implemented [-Wcpp]
> 
>> @@ -1,4 +1,5 @@
>> /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
>> +#define __ARCH_WANT_NEW_STAT
>> #define __ARCH_WANT_SYS_CLONE
>> #define __ARCH_WANT_SYS_CLONE3
> 
> The correct fix is to change scripts/checksyscalls.sh,
> making it always define __IGNORE_fstat
> 

Hi Arnd,

Thank you very much.

I read the commit message in the commit 82b355d161c9 ("y2038: Remove
newstat family from default syscall set"), I am not quite sure whether
we should check __ARCH_WANT_NEW_STAT first, like this:

   #ifndef __ARCH_WANT_NEW_STAT
   #define __IGNORE_fstat
   #endif

Thanks,
Tiezhu