Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 16:44:51 +0300
From:   Mike Rapoport <rppt@kernel.org>
To:     vbendel@redhat.com
Cc:     linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        linux-kernel@vger.kernel.org, trivial@kernel.org,
        Jozef Bacik <jobacik@redhat.com>
Subject: Re: [PATCH] docs: mm: fix vm overcommit documentation for
 OVERCOMMIT_GUESS
Message-ID: <YwzC01N62rtDvzQV@kernel.org>
References: <20220829124638.63748-1-vbendel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220829124638.63748-1-vbendel@redhat.com>
Precedence: bulk

On Mon, Aug 29, 2022 at 02:46:38PM +0200, vbendel@redhat.com wrote:
> From: Vratislav Bendel <vbendel@redhat.com>
> 
> Commit 8c7829b04c52 "mm: fix false-positive OVERCOMMIT_GUESS failures"
> changed the behavior of the default OVERCOMMIT_GUESS setting.
> Reflect the change also in the Documentation, namely files:
>     Documentation/admin-guide/sysctl/vm.rst
>     Documentation/mm/overcommit-accounting.rst
> 
> Reported-by: Jozef Bacik <jobacik@redhat.com>
> Signed-off-by: Vratislav Bendel <vbendel@redhat.com>

Acked-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  Documentation/admin-guide/sysctl/vm.rst    | 4 ++--
>  Documentation/mm/overcommit-accounting.rst | 3 +--
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst
> index 9b833e439f09..351443427360 100644
> --- a/Documentation/admin-guide/sysctl/vm.rst
> +++ b/Documentation/admin-guide/sysctl/vm.rst
> @@ -742,8 +742,8 @@ overcommit_memory
>  
>  This value contains a flag that enables memory overcommitment.
>  
> -When this flag is 0, the kernel attempts to estimate the amount
> -of free memory left when userspace requests more memory.
> +When this flag is 0, the kernel compares the userspace memory request
> +size against total memory plus swap and rejects obvious overcommits.
>  
>  When this flag is 1, the kernel pretends there is always enough
>  memory until it actually runs out.
> diff --git a/Documentation/mm/overcommit-accounting.rst b/Documentation/mm/overcommit-accounting.rst
> index a4895d6fc1c2..e2263477f6d5 100644
> --- a/Documentation/mm/overcommit-accounting.rst
> +++ b/Documentation/mm/overcommit-accounting.rst
> @@ -8,8 +8,7 @@ The Linux kernel supports the following overcommit handling modes
>  	Heuristic overcommit handling. Obvious overcommits of address
>  	space are refused. Used for a typical system. It ensures a
>  	seriously wild allocation fails while allowing overcommit to
> -	reduce swap usage.  root is allowed to allocate slightly more
> -	memory in this mode. This is the default.
> +	reduce swap usage. This is the default.
>  
>  1
>  	Always overcommit. Appropriate for some scientific
> -- 
> 2.26.3
> 

-- 
Sincerely yours,
Mike.