Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 16:40:32 +0200
From:   Sascha Hauer <s.hauer@pengutronix.de>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <brgl@bgdev.pl>, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] dt-bindings: gpio: Add gpio-latch binding document
Message-ID: <20220829144032.GC24324@pengutronix.de>
References: <20220825094132.1268174-1-s.hauer@pengutronix.de>
 <20220825094132.1268174-3-s.hauer@pengutronix.de>
 <CACRpkdYL24cJgo9F1nWYzP=8+XywdUXhSedJRQFJ16MUAx7-dQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACRpkdYL24cJgo9F1nWYzP=8+XywdUXhSedJRQFJ16MUAx7-dQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi Linus,

On Fri, Aug 26, 2022 at 03:37:40PM +0200, Linus Walleij wrote:
> On Thu, Aug 25, 2022 at 11:41 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > This adds a binding for a GPIO multiplexer driver based on latches
> > connected to other GPIOs.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> 
> Nice overall!
> 
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-latch.yaml
> > @@ -0,0 +1,83 @@
> > +%YAML 1.2
> 
> No license?

Will add in v2.

> 
> > +  data-gpios:
> > +    description: Array of GPIOs to be used as data GPIOs
> 
> Hm I wanted to just call these "gpios" but that is maybe confusing.
> What about "latch-gpios"?

Hm, the clk input is used to latch the current state of the inputs to
the outputs, so "latch-gpios" might even be confused with the GPIO
routed to the clk unput of the latch.  Overall, the whole thing is a
latch, so "latch-gpios" doesn't sound like a good name to distinguish
the different types of inputs of a latch.  I still like data-gpios best
as these lines are described as "Data inputs" in my 74273 data sheet.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |