Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220829133146.15236-1-xry111@xry111.site> <e0629567084ae5c1bab880b34b417256ea23f604.camel@xry111.site>
In-Reply-To: <e0629567084ae5c1bab880b34b417256ea23f604.camel@xry111.site>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Mon, 29 Aug 2022 23:02:11 +0800
Message-ID: <CAAhV-H67C=Cv8ok6oGe=YMS=U39N7ZKfdsSmGPc2gGpxbmU+cw@mail.gmail.com>
Subject: Re: [PATCH v6 0/6] LoongArch: Support toolchain with new relocation types
To:     Xi Ruoyao <xry111@xry111.site>
Cc:     loongarch@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>,
        WANG Xuerui <kernel@xen0n.name>,
        Youling Tang <tangyouling@loongson.cn>,
        Jinyang He <hejinyang@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Ruoyao,

This version looks good to me, only some small issues. Thank you very much.

Huacai

On Mon, Aug 29, 2022 at 10:57 PM Xi Ruoyao <xry111@xry111.site> wrote:
>
> On Mon, 2022-08-29 at 21:31 +0800, Xi Ruoyao wrote:
>
> > Changes from v5 to v6:
> >
> > - Restore version number.
> > - Rename CONFIG_CC_HAS_EXPLICIT_RELOCS to
> > CONFIG_AS_HAS_EXPLICIT_RELOCS.
> >   It now only checks assembler.
> > - No longer support "old GCC with new Binutils", so R_LARCH_ABS* is
> >   dropped.
> >   - "Old GCC with old Binutils" is still supported until Arnd ack.
>
> >     longer support it.
> ^^^^
> This line should be removed :(.
>
> >   - "New GCC with old Binutils" is still supported as it does not
> >     require additional code.
> > - Remove "cc-option" around "-mexplicit-relocs".  For unsupported
> >   "old GCC with new Binutils" combination, forcing -mexplicit-relocs
> >   makes assembling fail, instead of silently producing unloadable
> >   modules.
> > - Move the error report for "lacking model attribute" into Makefile.
> > - Squash the two patches for R_LARCH_B26 and R_LARCH_PCALA* into one.
>
> --
> Xi Ruoyao <xry111@xry111.site>
> School of Aerospace Science and Technology, Xidian University