Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 19:12:47 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     netdev@kapio-technology.com
Cc:     Nikolay Aleksandrov <razor@blackwall.org>, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>, Shuah Khan <shuah@kernel.org>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 net-next 1/6] net: bridge: add locked entry fdb flag
 to extend locked port feature
Message-ID: <Ywzlfzns/vDDiKB1@shredder>
References: <20220826114538.705433-1-netdev@kapio-technology.com>
 <20220826114538.705433-2-netdev@kapio-technology.com>
 <e9eb5b72-073a-f182-13b7-37fc53611d5f@blackwall.org>
 <972663825881d135d19f9e391b2b7587@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <972663825881d135d19f9e391b2b7587@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?48WpWIx1LneHKos/o/UoszPYArxlcBZgYbEr7aciBrfjwcFWCT8jd3Y1Rv71?=
 =?us-ascii?Q?Q8KplQt8puMPV3hNdqoUM0ehs1VYjZdNubdBHlziIR4EuMhw6GEMkp9xqpp0?=
 =?us-ascii?Q?8BKzCdnrxbpIXlRbpZ4yErDsm3Z6i0O0jSeJswMBNFtmP6B2pHHqJxdFfr6K?=
 =?us-ascii?Q?MREbOth9worx3dx/RIC60EXqnOTqQoAt5ARimKI6Tue4//9EfNgIyk206nUJ?=
 =?us-ascii?Q?XE8604Yo00np0fbwGCpMaOOgqnUfbc+vhsXNClZSEVVVidj0c/bcjur3hoyd?=
 =?us-ascii?Q?nuY9yPzGjMHg4feRCTh+BXrD4il3jqzHlon80F/3kspnGg6Nic5pQfA0ijRx?=
 =?us-ascii?Q?FaMRY2FXCj5M8C0KAnrXbds6GxlRhSkkSWfEQ8tgxgVhVsOe24WgE1XR4odO?=
 =?us-ascii?Q?giP4SqT5q1JGkVfjySRErqt8NbuzFDK3hnFCVh2bgdVOxDceDBSEKdgBeNSg?=
 =?us-ascii?Q?aZlO5jqsVedRXVckZD6yQ4zzuemKTTYO9ZksAAfI8YZaVg2AQrqSBjvB+3RL?=
 =?us-ascii?Q?LftCBCfiXYtHy0xZIrpWqF+vNNt/g1YgFJzNP9GPNHIHyc6awSISCkvkiw2H?=
 =?us-ascii?Q?6O0sBGqdYC7ZFdtgkoQPZl7X8oygoGfHk/Pm4oFShAti0ClkPfuudyxy9usL?=
 =?us-ascii?Q?eNuSuimOVUTc1PkIXM0J6YWDqsS77Y3/ICYQiLvtTAYgC6uJQxADtDBHW/lU?=
 =?us-ascii?Q?ic54ULBEsnsl6gH/bnq7KKsQCn3qCsLDT8x85AcgebXh9qAAS59qWWq6sSrr?=
 =?us-ascii?Q?oOy6Tc+uJKMB8PHwKNIpVzhH8BlNbBXNSARLgMTZBmqAdwCuHRq3qTfE8Qj7?=
 =?us-ascii?Q?c8jWdvBkFQEX4yR9Q1Sw46kDhxtjQguRjdNuiPJ/wVzZywMfMXGgqVmhGDOc?=
 =?us-ascii?Q?QUi8nPjVyOMVXF1BIhAbjCnUmPPI0Ep3VlR8S5RI0syKIgMMvUccSQnz+exK?=
 =?us-ascii?Q?50hSZvb+zhIG+GSf5/NMYCA3lT77Z8iaPcwpIG7FZ6CpIX/ajchXeFAMgyfF?=
 =?us-ascii?Q?Nm3itLIsA6QAxZPN0tOEsCRg8EvUgm1OuRInCru9IYGXVi6UEjjVCxZIYfbJ?=
 =?us-ascii?Q?rMdc4tl69pl+QCm6Mesfg0uZaVVwrSYfQ03xm58SUveydPMqLLFwTuXmFEYc?=
 =?us-ascii?Q?kwQ5oNTxHrSPYlWEptuZx2RWT4qczbigWw9lwcD9RkMoV9E0WNPBo+Wr2H7z?=
 =?us-ascii?Q?lAdpTnDmKlwChnZ4PO5ZHBF+38cq820O3JtXOj9YPHIxF0jP1HIsPeYbuzpJ?=
 =?us-ascii?Q?hRJSPg7IbMjVCT5BvzdH20e91tmbjXqa4d7qyM301RT2juLy7UEnQfQ+T7Fs?=
 =?us-ascii?Q?KGqMwOwAFcoY4Fw5+nJcn05V0Ij0+kgANeTK0wMJMsCKEXOpMxm7zDdlCbz4?=
 =?us-ascii?Q?FWZ3IzwwazbE11+Vkf190kcLuHK2vVNT93LVkqFtX0rZ4pItFch+k/TaalyD?=
 =?us-ascii?Q?cyJaQZDU1qXorSwJUpkj6HJtgweqfgBFVtup2GWVvgj05kPNh3I4wBd2JM5h?=
 =?us-ascii?Q?Lpi8jQ61xpbNu6spWY5gvvUlNF2gfJ42mYp2U9GhFenjdrBwv811H2HQwq3M?=
 =?us-ascii?Q?vI7f2/9q1xUMaDl/AYU2yyKUKDZivfbyTAeykYvZ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 458cf043-40c6-4dfe-e455-08da89d953a8
X-MS-Exchange-CrossTenant-AuthSource: PH7SPRMB0001.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 16:12:53.2238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qO9PlPy0ZMasgC7Pq/+Y2JTqskesVBKrl8iNvo6nteTbwS41VeDrQexdoxn+1X4hGwE1uoTqvIxAX0bx5hB4KA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5633
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 29, 2022 at 04:02:46PM +0200, netdev@kapio-technology.com wrote:
> On 2022-08-27 13:30, Nikolay Aleksandrov wrote:
> > On 26/08/2022 14:45, Hans Schultz wrote:
> > 
> > Hi,
> > Please add the blackhole flag in a separate patch.
> > A few more comments and questions below..
> > 
> 
> Hi,
> if userspace is to set this flag I think I need to change stuff in
> rtnetlink.c, as I will need to extent struct ndmsg with a new u32 entry as
> the old u8 flags is full.

You cannot extend 'struct ndmsg'. That's why 'NDA_FLAGS_EXT' was
introduced. See:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2c611ad97a82b51221bb0920cc6cac0b1d4c0e52

'NTF_EXT_BLACKHOLE' belongs in 'NDA_FLAGS_EXT' like you have it now, but
the kernel should not reject it in br_fdb_add().

> Maybe this is straight forward, but I am not so sure as I don't know that
> code too well. Maybe someone can give me a hint...?