Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <41c4e85d-2468-e23b-4270-0cc39c3c75d5@roeck-us.net>
Date:   Mon, 29 Aug 2022 09:15:24 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 1/2] watchdog/hpwdt: Include nmi.h only if
 CONFIG_HPWDT_NMI_DECODING
Content-Language: en-US
To:     Jerry Hoemann <jerry.hoemann@hpe.com>, wim@linux-watchdog.org
Cc:     linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220820202821.1263837-1-jerry.hoemann@hpe.com>
 <20220820202821.1263837-2-jerry.hoemann@hpe.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20220820202821.1263837-2-jerry.hoemann@hpe.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/20/22 13:28, Jerry Hoemann wrote:
> Fixes: d48b0e173715 ("x86, nmi, drivers: Fix nmi splitup build bug")
> 
> Arm64 does not support NMI and has no <asm/nmi.h>.
> 
> Include <asm/nmi.h> only if CONFIG_HPWDT_NMI_DECODING is defined to
> avoid build failure on non-existent header file on Arm64.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/hpwdt.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index a5006a58e0db..f79f932bca14 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -20,7 +20,9 @@
>   #include <linux/pci_ids.h>
>   #include <linux/types.h>
>   #include <linux/watchdog.h>
> +#ifdef CONFIG_HPWDT_NMI_DECODING
>   #include <asm/nmi.h>
> +#endif
>   #include <linux/crash_dump.h>
>   
>   #define HPWDT_VERSION			"2.0.4"