Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 14:27:31 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Baolu Lu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 07/17] iommu: Try to allocate blocking domain when
 probing device
Message-ID: <Ywz3A3tHEzY+Sf7b@nvidia.com>
References: <20220826121141.50743-1-baolu.lu@linux.intel.com>
 <20220826121141.50743-8-baolu.lu@linux.intel.com>
 <YwjeL2SVmdRpoWb6@nvidia.com>
 <316f6575-59ea-08e3-aaaf-bc1e4f42a574@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <316f6575-59ea-08e3-aaaf-bc1e4f42a574@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k4X+zZhsptKA9Wom+oTgDWj0OOa9dI88KW1gcSyUQoVK3CQuJAAT2hAlyGnk?=
 =?us-ascii?Q?HEq+TMhBILlHDQA/qohFrM9uabOIZB2b6nctOZ+DtYv6RIRYd7h92Y1BpwQK?=
 =?us-ascii?Q?MGQpC1FjwQqurM0B2WVzmrjX7Y3NwjJbuANn08B6WlzKQdWF5YVVhptqPP8h?=
 =?us-ascii?Q?iYberEmf86tf/0WmYg3xL8yh9TPIysHVF+GIDq0oNcLO6uXOZoRh7iN5kRh4?=
 =?us-ascii?Q?hl4GiYXakQS/hH5Eqyl3OVbIs9hiYD17D5tzHytOIj6Cr6oc1eYwgAU3xJC8?=
 =?us-ascii?Q?qv5lwnQ4YQbAJmhsrYvEI8YzRiJkOTHBTVZJCGenf6PwXkugKRM9g70jlIc8?=
 =?us-ascii?Q?57NQyg1ajAZ/78ZeL+MBUUNzjGkpIoRa41uijh7wo7AMNTx8HEmbsxHfzfLD?=
 =?us-ascii?Q?2xZEC0wg38xPvWcbOlZC52PVfNdHcDixwv6Iw5l9DqTNujIyYsgrdoXgkBmm?=
 =?us-ascii?Q?+vnGNv5YPnMXm/N4mBUz7WKRjBKVzRQhM8qEJdyxcPQegZGTPQHad6AWSh+a?=
 =?us-ascii?Q?3GGIga3SrthpVlpBnX5hFZSefJw1zdiLMKjL5yxL589bA3ofa9CJXXlPlaaO?=
 =?us-ascii?Q?pGk6LJr4oJWjfEHgYlvC/9SjZdt4F01Zm/uF1xPnuzC8IhFpU0Nk10JAACoK?=
 =?us-ascii?Q?qjNXkBA2Eaky7ioChEaogesyXqy+PXLYjpPxPtUKIGsYAjOWbgYKdQjHOusk?=
 =?us-ascii?Q?Y9wUC2UlnBuXE8fgDmpl7q6GiU+rd3FAeZZb18t9ie4MiWijeJMVbl/XrJey?=
 =?us-ascii?Q?OtCspKTsaghGjQASRv/RpA3Lt/zqNE+WfEVgeXfi2r9CJ4G8hArrIFUhyCDR?=
 =?us-ascii?Q?YgFnCZPd8ymfFKyy1aawvy0cNlY3677WTGwKvcrxF00ONI16gMkS+Vo1w5kg?=
 =?us-ascii?Q?okQEZp2BT8q6YLs4bvWvqO5/gEtPQ7keHqwqaefcjUGUbijB+Bhr+Uk2MvUk?=
 =?us-ascii?Q?ItHR864l1KcTFbgifjyEoFvQaKityhgA+l8BRzMbebrPmY6SJ+M9uGWGA+l8?=
 =?us-ascii?Q?Bj3Twp2DLzDAH3wjOAd/AVLiF9LJcHQZ9QC5Av6zFz5ULhg8OTN4xJKFRiFg?=
 =?us-ascii?Q?CBhaRBrhsvbkgstPIXF+VoCylqj2SmadRrS0f+X4nM5p+v8Vd6R+M/RuVPcM?=
 =?us-ascii?Q?OF2vqOA5dX+Egtu+7jGbcuUpQyoZQ8SMCWgqU3UTEQVwTDWQz/PGgI91Al28?=
 =?us-ascii?Q?3shJCFZytfsWuK1kwveZU9yT39g52DYoh1QswYV8bPEyS4jIKizoJdU2BMYN?=
 =?us-ascii?Q?nyOntSdJLwAiEUjACDKfp3Z4ZT/Q+HCaET+DnLMRd4LYWZynrapDa+004kMl?=
 =?us-ascii?Q?v1sYnW1ATUyNJi5Ut46wkXumCjI+/L0zkxwyB1F/XkNNjrCRh4LywnHXRl6a?=
 =?us-ascii?Q?ZvBiH+rcqYv/OZXQfWkzQkrd91jGzGQfPWPCmVMTDUB6SEVoHC/4nwj4MSO0?=
 =?us-ascii?Q?q+YNAGQJkqjftbDbkZuRd3tQmPgZ4c0zVoIURjmMqEDQjgjMVgfARd0rF9zp?=
 =?us-ascii?Q?PEd1KQinJCgZ3NYvsGz2C3VRvDaU671XMghiLTuM1ptqzcZU1MQtEaUNoWf/?=
 =?us-ascii?Q?anANOBd/83u5l+c/CS4T58AGTjN6cd/HdD0rQevA?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e215827-82de-4878-cf4f-08da89e3c18e
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 17:27:32.5852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ve4lRNCeUEylia8/PsmmureXt4YopiQen+PcP35LzAPsbYeWEBpwgKAHy1qwTIJz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4274
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 29, 2022 at 11:40:24AM +0800, Baolu Lu wrote:
> On 2022/8/26 22:52, Jason Gunthorpe wrote:
> > On Fri, Aug 26, 2022 at 08:11:31PM +0800, Lu Baolu wrote:
> > > Allocate the blocking domain when probing devices if the driver supports
> > > blocking domain allocation. Otherwise, revert to the previous behavior,
> > > that is, use UNMANAGED domain instead when the blocking domain is needed.
> > > 
> > > Signed-off-by: Lu Baolu<baolu.lu@linux.intel.com>
> > > Tested-by: Zhangfei Gao<zhangfei.gao@linaro.org>
> > > Tested-by: Tony Zhu<tony.zhu@intel.com>
> > > ---
> > >   drivers/iommu/iommu.c | 29 +++++++++++++++++------------
> > >   1 file changed, 17 insertions(+), 12 deletions(-)
> > This seems like a lot of overhead to allocate these things for every
> > group?
> > 
> > Why not add a simple refcount on the blocking domain instead and
> > allocate the domain on the pasid attach like we do for ownership?
> 
> I am working towards implementing static instance of blocking domain for
> each IOMMU driver, and then, there's no much overhead to allocate it in
> the probing device path.

Well, I thought about that and I don't think we can get
there in a short order. Would rather you progress this series without
getting entangled in such a big adventure

Jason