Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220828154904.20477-1-farbere@amazon.com> <20220828154904.20477-2-farbere@amazon.com>
In-Reply-To: <20220828154904.20477-2-farbere@amazon.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 29 Aug 2022 13:55:51 -0500
Message-ID: <CAL_JsqL1UAM80wydnq7hjsKB1zO9tE_Xnba8U3KjDiFY157TOA@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: at24: add new optional power-supply property
To:     Eliav Farber <farbere@amazon.com>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Mark Rutland <mark.rutland@arm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux I2C <linux-i2c@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Talel Shenhar <talel@amazon.com>,
        "Hawa, Hanna" <hhhawa@amazon.com>,
        Jonathan Chocron <jonnyc@amazon.com>,
        "Hanoch, Uri" <hanochu@amazon.com>,
        "Krupnik, Ronen" <ronenk@amazon.com>, itamark@amazon.com,
        shellykz@amazon.com, shorer@amazon.com, amitlavi@amazon.com,
        almogbs@amazon.com, dkl@amazon.com,
        "Woodhouse, David" <dwmw@amazon.co.uk>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Aug 28, 2022 at 10:49 AM Eliav Farber <farbere@amazon.com> wrote:
>
> Boards using the AT24 EEPROMs might have a GPIO that controls the power
> supply of the chip, and it must be set to enable the usage of it.
>
> Add a new optional property to the device tree binding document, which
> allows to specify a GPIO regulator for the pin that controls the power.
>
> On Linux this means that we need to enable the GPIO at the beginning of
> probe function, before trying to access the chip.
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> V2 -> V3:
> Apply on top of v6.0-rc1
>
>  Documentation/devicetree/bindings/eeprom/at24.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index d14e0accbda8..82f0046f67a9 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -179,6 +179,10 @@ properties:
>      description:
>        phandle of the regulator that provides the supply voltage.
>
> +  power-supply:

The datasheets I looked at say the supply name is 'VCC', so vcc-supply.

> +    description:
> +      phandle of the gpio regulator that provides the supply voltage.

What the connection is is outside the scope of the binding. IOW, it
might not be a GPIO controlled regulator. So drop the description.

> +
>  required:
>    - compatible
>    - reg
> --
> 2.37.1
>