Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3526370rwe; Mon, 29 Aug 2022 13:46:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR7DXQVqtXTCG9uMF4elIAkHPHpkt4FkNvk6OxVitb9z/nSaFMcUvJrLavAfJZ6AhgMYQELj X-Received: by 2002:a17:90b:4c52:b0:1f5:5129:af1a with SMTP id np18-20020a17090b4c5200b001f55129af1amr19875015pjb.202.1661805990387; Mon, 29 Aug 2022 13:46:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661805990; cv=none; d=google.com; s=arc-20160816; b=S7qbWrcsjETFVJxh4dNBxb+suHWl1mr/xhOXP0VJXkv9EG7FxEseDAz1U1btliQZs/ XXNW3SdoGxKjtgIZqGChB4VuzJg+FixfczbAXQLblJoTqzVToF1ZJ8OYNzEXH1ukXGPh lsCmqHKJ7z3UEkPHAaRlM0DSgMd6rF+zFNcEarJbPnjMWq1Bmp9h19GmIFzvYOrgp1kv o2CxF6ozaLp8qkUrZthP4MoKhAT1IthA6VkB3u8R9q0QaNo3oibxkGUhK7luxwEP3KOL SqCwf4AjrK9KtL/LH0kD5k/tnGsYKmLR6lc/y8wP7Bvx6rb5l5zG2OhDWBD4FqYarasG YlDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=fPs0/yVo3nczXzOWJ59vYdXG0D55mgcEo8jaLEweVY4=; b=RKscaFGlrvLt/RoFzoaB4is9imq8oHFJbSyQMLMkZAxmUzNm505dTKbftFjktfvDLU Jh70idzDqq5Xi2ikGui6F6YSCA+4ZnoRmO6sGZZZmlkkM/LOvwSs3K4ZYJIExSbGhUj2 iqGz05Vqpm9t4dHkDJKBSIe6eFn4QtpMn+6Agf92Nq3uNUU8JyTvXiYpr17p2HH9Q9Vx 16YUsYeQbaU8BO+m3HyI0CXFvERlsHJdGcTJVZ/gYgKRNP+wJoKo1DUDdUkXFpp+FIiL et+gmOOCuzkS7CN9+Hz0B6wyDF1fe+3nNlXLt/a4OAieEbUCiQN4HoOvg+/pOndrEL2b B2Vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linux-foundation.org header.s=korg header.b=W98aFR9L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n9-20020a170902d2c900b00170c27cceb5si11376254plc.620.2022.08.29.13.46.17; Mon, 29 Aug 2022 13:46:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@linux-foundation.org header.s=korg header.b=W98aFR9L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbiH2Ue7 (ORCPT + 99 others); Mon, 29 Aug 2022 16:34:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbiH2Ue5 (ORCPT ); Mon, 29 Aug 2022 16:34:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 235591CB34; Mon, 29 Aug 2022 13:34:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D6561B81211; Mon, 29 Aug 2022 20:34:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09EEAC433D6; Mon, 29 Aug 2022 20:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1661805293; bh=JdpTsh0vpLzXYFuVgPaN22fxCzf3es58W6ZxtaLnGJo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W98aFR9L/yVMMf3iotWWAjyF8BnjSlCM3x5mH4GwSvEWlNp4ZivZ3+WKFui043hcI f65XvSDXEL/OrQMwaFn6CnHqm4sw3BebP9jZfsM1NjloVIo666eZW3wkBIoKcHK2WG qi0DsjDdyPw2OBNGUMxX3ddTC8XRZ8qJqx2S7Ax8= Date: Mon, 29 Aug 2022 13:34:52 -0700 From: Andrew Morton To: Carlos Llamas Cc: Greg Kroah-Hartman , =?ISO-8859-1?Q? "Arve_?= =?ISO-8859-1?Q?Hj=F8nnev=E5g" ?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , Liam Howlett , kernel-team@android.com, syzbot+f7dc54e5be28950ac459@syzkaller.appspotmail.com, syzbot+a75ebe0452711c9e56d9@syzkaller.appspotmail.com, stable@vger.kernel.org, "Liam R . Howlett" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] binder: fix alloc->vma_vm_mm null-ptr dereference Message-Id: <20220829133452.cd4d9abe858c940126557c41@linux-foundation.org> In-Reply-To: <20220829201254.1814484-2-cmllamas@google.com> References: <20220829201254.1814484-1-cmllamas@google.com> <20220829201254.1814484-2-cmllamas@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Aug 2022 20:12:48 +0000 Carlos Llamas wrote: > Syzbot reported a couple issues introduced by commit 44e602b4e52f > ("binder_alloc: add missing mmap_lock calls when using the VMA"), in > which we attempt to acquire the mmap_lock when alloc->vma_vm_mm has not > been initialized yet. > > This can happen if a binder_proc receives a transaction without having > previously called mmap() to setup the binder_proc->alloc space in [1]. > Also, a similar issue occurs via binder_alloc_print_pages() when we try > to dump the debugfs binder stats file in [2]. Thanks. I assume you'll be merging all these into mainline? > > Fixes: 44e602b4e52f ("binder_alloc: add missing mmap_lock calls when using the VMA") > Reported-by: syzbot+f7dc54e5be28950ac459@syzkaller.appspotmail.com > Reported-by: syzbot+a75ebe0452711c9e56d9@syzkaller.appspotmail.com > Cc: # v5.15+ 44e602b4e52f is only present in 6.0-rcX?