Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 Aug 2022 22:19:02 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Asmaa Mnebhi <asmaa@nvidia.com>
Cc:     robh@kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/9] i2c-mlxbf.c: bug fixes and new feature support
Message-ID: <Yw0fNuOWtJbe/OT1@shikoro>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Asmaa Mnebhi <asmaa@nvidia.com>, robh@kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220822195725.12656-1-asmaa@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7Ba7C5FXgFqMN/r8"
Content-Disposition: inline
In-Reply-To: <20220822195725.12656-1-asmaa@nvidia.com>
Precedence: bulk


--7Ba7C5FXgFqMN/r8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 22, 2022 at 03:57:16PM -0400, Asmaa Mnebhi wrote:
> This is a series of patches fixing several bugs and implementing
> new features.

What did change since v1 and where did Khalil's Rev-by tags go?

> Bug fixes:
> 1) Fix the frequency calculation
> 2) remove unnecessary IRQF_ONESHOT flag

Is this really a bugfix?

> 3) Fix incorrect base address passed during io write
> 4) prevent stack overflow in mlxbf_i2c_smbus_start_transaction()
> 5) Support lock mechanism

Here, I am also not sure if this is a bugfix.

Thanks for the update,

   Wolfram


--7Ba7C5FXgFqMN/r8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmMNHzUACgkQFA3kzBSg
KbaOng/+ImN7GRwp7C2SQyYFsjDX0RUTohS2gENjCPiLlss5aDAbyrEazQxNSEQN
lecyEn7Nj6szbnfUAc/VspcUXLmOEEywGLBoMPkmnKrSefeUnE33ONO71+gTkrOx
Liq+ceKWHn6d/W6qZPKj2JGdETMo1UWtnhuD31Jw1sCNfogiLuX36w6Qgij9vFKN
30zjs9KZkd5ViZbyfs5S3yc0OxI7YMvuWWa8JCbiqgWUutsfRbYl1JjoqFuBY/RF
822lxwLCPt2R7JEMwjtPJ3nh6mmX6yihxXLXIkSAEsCTI884BsKsMqg5qWGEBhuV
HMTwC1y9+DcjDoPs4BoYbb0ZkzfiWNNV61DPFFWpXnp1zSQbwBQMvdSl9Wl+nNQm
SHhHgN0nshIvubZC6cFydocBUPNpH5NxsgxOvdRFvI47K5SzJqMXpsoPhgJX0fvD
LoarAytnyVPDUGEBqnJH2YTrUZFYBdBrXH5oPBrvyo0rhpeEJWAdkI8iMQQoOTFV
ZTnqIOzjd5zSqrZL1TAquM+3n3tkUmiycqkZaPdt2RANECgjKmSZS7kWERckqORO
flUXYEczRdt5W3CMuH8L1txVVEfOnRWq1oM0sPdUAXf4OlaX0tqxccMy+/aiN/cJ
4HttwLKPirVi7Vi0Hjg2aWvyK1KMIunFsTL6ACLHNmAUUQE07XU=
=JJtI
-----END PGP SIGNATURE-----

--7Ba7C5FXgFqMN/r8--