Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
CC:     "robh@kernel.org" <robh@kernel.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 0/9] i2c-mlxbf.c: bug fixes and new feature support
Thread-Topic: [PATCH v2 0/9] i2c-mlxbf.c: bug fixes and new feature support
Thread-Index: AQHYtmFspLN7eEXzUE2AAJMrZ0F9+63GXGUAgAAEL0A=
Date:   Mon, 29 Aug 2022 20:46:05 +0000
Message-ID: <CH2PR12MB38951B9B8F189E1B991A7950D7769@CH2PR12MB3895.namprd12.prod.outlook.com>
References: <20220822195725.12656-1-asmaa@nvidia.com>
 <Yw0fNuOWtJbe/OT1@shikoro>
In-Reply-To: <Yw0fNuOWtJbe/OT1@shikoro>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iFYkTz8aLVXv+xbgAgHS+PYTMDYK+7/KUEIEAPXDe/6k7q2r0mbIwA/eVWjB?=
 =?us-ascii?Q?0tkiO1ftvh7bnLdJgVPzYKELWzPqr0U7yGV1A93PsT5m8xuSPMZxq3qDcT1D?=
 =?us-ascii?Q?ckxZvUPHX61NkFpoYsGLhRprT+it9ZVhJcgnJLaPkkO7hglaxEO75vVXojzi?=
 =?us-ascii?Q?nL8OLw8K9OOWEUfTLNEVbgF+rcBv3cgBpdP7VieDndZIuXUaB4oYayXMhDYY?=
 =?us-ascii?Q?4sYNnLP9wiELukKsHKC5MFGJLZ4KPrCm9bbaQyhsOZVH1DI6wyDkj6cg+oJh?=
 =?us-ascii?Q?r+Do8A/2IrTAW4PbY6f6gYzRkjLH0/5CoQGlG+yWQw8duNQ/e70YAWkZK3TW?=
 =?us-ascii?Q?ClB9jeeTt+wcvg1n/sQt/nNpFSYaOBwsh+ejzVbS0xIfI8wSLvKLI9+Zy57r?=
 =?us-ascii?Q?EeJiS1m77+yRzYO+rI57TCG+wW9oG5GJb9sqPCA75WDon++NGflmATRmH2/5?=
 =?us-ascii?Q?2hNNp1nYgOj2VKhvkQ4WiDEfxF/9WEHvS5I4vYllSPkMJmqT2Odl7MuPCT4x?=
 =?us-ascii?Q?Ge4NvqJGPxNxcZEvwi23tLscKAGexyqG5ubpwKoNBTV2ipmsqFngJUlG2yKR?=
 =?us-ascii?Q?AkY4vfPxiTq8DRwcXGe3KT1r7hOBo9VaX0VTznkz8QzIMv12AowEIdfmIKc0?=
 =?us-ascii?Q?YVKi740llchb5Yvgn8OyVhPmMRaMGWVTuvrnIty2DNODXeZLcjYJTNtsfB51?=
 =?us-ascii?Q?MvaiTroDwbmmW7FVNePLm+4xhFNs1ZpObP73VqGxAA31pcwBe2a+h3IcBTD+?=
 =?us-ascii?Q?pCQSJNpEfmjgwvdiaQSdT+HFWOLRDFJK4HHiko/JAJ8SzKWjg+U+AKgSq9Gz?=
 =?us-ascii?Q?pmgDOS18QXzYNRLMZMYLz0VWWL2mx+Oh2ahRCsJ2rwSrUEdy20mjOIkq8tQY?=
 =?us-ascii?Q?HtddbLWsTMfxX1Kn15izeswTEnTfWPiO2m9KC0YtlkzDnAUGelrWyIvYEhJv?=
 =?us-ascii?Q?vdkOD8pdXAIkkaUmTkObtjWGb+2u/pkj6X3zLYR11cDiEZ1YQYLBws4OXVKT?=
 =?us-ascii?Q?9XCDe9U8N5+NH4bEXDZ/OU3BlseCfg8LsAmeGlJ3Fh7uc1SOaIUSnFznHDC1?=
 =?us-ascii?Q?8aL7ty0wXo4EDUQ5VqvI7q4xwsR8HABdQwsSa+RhBvhXIA6zJO9+AdM8Hh64?=
 =?us-ascii?Q?YGBWns8G5oNsBy9+FSW/AGBUvJ3zryY96QPv8VgOnqCPHII+rIQnruqSqq92?=
 =?us-ascii?Q?DorjCqtkMcusOSyrQBWzwaA6CmaxPlZ90LXTUgwFTRN5DPpCD85LkXfUUv0L?=
 =?us-ascii?Q?hy63R+3HcI+wKlbrnhyzm2tUtzg1LvBJw/4loBNRuscEy+EoLOsZCNedqyUB?=
 =?us-ascii?Q?NRVVkwvlXYq368Y3Xq8UqyFTz8kWQYge7yZqO6kJ3o/yipgFOimtNjopj2V4?=
 =?us-ascii?Q?vZ5DuHeTTgUQAOEjFplQSLZFTgRrhYAFGEaHqRkLt+u+rrkxm2cpZQdhFImC?=
 =?us-ascii?Q?z+izC8QnRoVovJ5OwMT0U1VNNQs33DcBaOjX264KFcQNfU1Co8Vvz1JLVHuG?=
 =?us-ascii?Q?Bocu04SA+OmEgyytwQ0emRAXRxfOgJovxcKr8Ls5sY2GcaEx+LtcS2R6Gy0j?=
 =?us-ascii?Q?JgaKyCHfSZWsi1pRdxs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3895.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f61014e-14a8-4365-a784-08da89ff7e94
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2022 20:46:05.9371
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HCnCkXqvaHJpUQRccoJi4AnLnT70CBtPQTLi1W1ihWJ1iVdvWZM8AkkdWeG/yOtesnI9oFV2KF1xWn5E/wgNKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3260
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> This is a series of patches fixing several bugs and implementing new=20
> features.

What did change since v1 and where did Khalil's Rev-by tags go?

Khalil told me to remove the rev-by : ) since it is supposed to be reserved=
 for the reviewers. I will add it back and describe what has changed in my =
next set of patches. As a note , this is what changed from v1->v2:
1) moved all the bug fixes to the top commits and left the features for las=
t=20
2) split the BlueField-3 SoC patch into 2 to address Rob's comment: one for=
 the driver code and another patch for the device tree binding yaml documen=
tation file
3) addressed  Rob's comment regarding keeping the device tree/acpi tables b=
ackward compatible. So add the new resources at the end of the enum.
4) update the license in a separate patch

> Bug fixes:
> 1) Fix the frequency calculation
> 2) remove unnecessary IRQF_ONESHOT flag

Is this really a bugfix?

This is not a bug fix. We removed it because it is no longer needed.

> 3) Fix incorrect base address passed during io write
> 4) prevent stack overflow in mlxbf_i2c_smbus_start_transaction()
> 5) Support lock mechanism

Here, I am also not sure if this is a bugfix.

I think this is a bug fix because we have an i2c driver also in UEFI so we =
need this lock mechanism to avoid race conditions over acquiring the i2c bu=
s. Not using this lock resulted in unexpected behavior.

Thanks for the update,

   Wolfram