Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a3668c54-b5fb-6bf5-28d3-12818d46153b@intel.com>
Date:   Mon, 29 Aug 2022 15:07:42 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH net-next v2] drivers/net/ethernet: check return value of
 e1e_rphy()
Content-Language: en-US
To:     Li Zhong <floridsleeves@gmail.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>
CC:     <jesse.brandeburg@intel.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
References: <20220826065627.1615965-1-floridsleeves@gmail.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20220826065627.1615965-1-floridsleeves@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzlCNy9IZUFVcFJreDFFMm03eU4zd2w3WHB0WTJXeFUyajBOaWhpRTZRQ2Ir?=
 =?utf-8?B?cUVVaHBkbnNEdVZ4YndjRndaNlV3Z2tuT09CT0xhcFJZTWN2ZW95QjAyWWtR?=
 =?utf-8?B?TTZ5VDc2Uy9JMVBaQWRzb3ltaVBod1hiNGd3MTYrb011eW51U09rQ01vd2lK?=
 =?utf-8?B?ZzlERXlCMnMwY1ZvTjhVejhRazU0L2xuUVJZVFpEaWpsbXM2OE9ic1BKZERG?=
 =?utf-8?B?bEc1WVVhb2hrWnpDQm9yQXVzdjV3TlNvRHhTRllseWpOdEl0ODRsRjVhRnZ2?=
 =?utf-8?B?UFoycFZZUGMzdXp5aFRpR3plcE5vZGs0TGpKbXZHNWxEWVRyT093OHlzZEpB?=
 =?utf-8?B?bTZnSXpNd1IvUmZyZXFSRnFlMTlOMzR1bnJjZUJqL1JVcHdDTFREbnQ4Wmxi?=
 =?utf-8?B?dkxTVysvS2czUDFLaVlpVk9qOWdOY1FVeHVxZnZOdnBJVk5YenJwQitHeVls?=
 =?utf-8?B?QXhOZFRrUG9IWGY5bktjKzgycXE0ZEVpK3FNNnJpQWVQUndXUDNpZ3BmRW9E?=
 =?utf-8?B?cEdEVFpadVZCQnNhRlRoQXA0c0xRa1pFYlEzZmdkeVUveHFXSVdMZ2RQWVF5?=
 =?utf-8?B?ZFBGMXAzekNOUTFFR0QyRURCSjhjOTVQRTVCK3lqSXQvM2hwS2lpSVUzcW9v?=
 =?utf-8?B?NVYrTFhOYVl2MkszM09LT2Y4Uk4yVXNNNXliWk5lWGpKemd1emJMTEdjZnVS?=
 =?utf-8?B?RWZyZGlFUkFnMUF1OS9LWHJnRFVramc0QWRmNXJ2MWFaZjN1Rm9iUkNJUytR?=
 =?utf-8?B?QWR3Rm1JOE9xTlBpMjlPSFZIYzBDNCtEWkUySHZQb0NFSWVOMTE0R3UyeE5o?=
 =?utf-8?B?U3d6eTJWY2xpTERxc3dmR0t0WlJiWUpVOFp6bUYzZWdIZDF4R0tibHgwUDRi?=
 =?utf-8?B?YU1DNytJSCtmYm5LVml4NlZidnZGUi9NdzhPNXh5dzkwSXZMTHRXQ2dhTWRK?=
 =?utf-8?B?Tk1abkg0MEpZQnA5RjVnLyttWWNlalgxRUZBNmxnVjFWTzRHazI5ZWJFbnZL?=
 =?utf-8?B?NlBwOWhyM0QwdW9yakVuajhjVmhZUWV1bUI4RStLS3grT3UyMzBYdlBwcVg4?=
 =?utf-8?B?bzI4NnIxc0NvVWxKMVdOR2FUWUdhK0g5SlhoUHJrY0hqdFkyUWFJbUJoTTRH?=
 =?utf-8?B?eGtvMUhaVmZuVUhZWmh0akE4dyt2V01GcFk4bnlVTXkrM1c0YXFGM3BNdi9h?=
 =?utf-8?B?dXN6czN0QWphL0xubFBmUHNZcFRXL21MOSt3THZDMmdYdnc3dmFGTXZ3bE15?=
 =?utf-8?B?RzhxTTVwNDg4WlluWWQwbWQ0VHlNZmc3WkxseDBHT1V4cWo5ZDVxSVY3VkNw?=
 =?utf-8?B?b2kzTmY4SVYzRS8yL3J3a2hHYlpHa2Z0c3cxdGtjL3d3ZzhRZCtuVmprZ3NS?=
 =?utf-8?B?WnFadUgxcXU3MXVNdjBIZThaMERuTVJIT0JkSENRU2d4YXl1TEcxZlZoZGw3?=
 =?utf-8?B?RStYb0d6YXBUVWRrVWZBN0NUNHliYVM5ckNYT1ZrV0owSnI4MUhzTG9NTFBo?=
 =?utf-8?B?bVBSdEZKUXNBMUhzZWxEa3ZQR21RbmNUQ0VPSXNvbVpPVGk3NytkYXJEWHlC?=
 =?utf-8?B?ek9CTHNDQ3hySzBtOFFWUG5vMnZwQWpRbmE2SkVlWFF5dHdhNjhOejdpNkxG?=
 =?utf-8?B?b0owZGtWaXFTMXk4V1JDN2VWZW5xQW9OZksyVUtPNEQxaWJNSEJyUE9pV0I5?=
 =?utf-8?B?YUZ3eVBUNng2SW1adEZWa2RsNlorb3p6a3RUa0UvMHIra0F5QUNORGpicTFv?=
 =?utf-8?B?MkIwTmFsYnhxV21EUERxcVBvQTM0MnlUcEdmaVJka1NtR09CTW5uY25qekJM?=
 =?utf-8?B?WlJQekJmY1crNUkxUDJhRGtvWXVCT3VzQ0JxbEFBcWpiZzZBMnY2UkI4RTZK?=
 =?utf-8?B?NVN1TWFCanFZU1hzdXJWYUFJQ0xnbWsrdkZZNkFsMU5yaVRUbis4UkF2Q2R2?=
 =?utf-8?B?YmRPSUI4YjM1N3FZZkxTUXZicnNXeDNTWHBFWGhZMkR2OXNjcVYvamdiSGZj?=
 =?utf-8?B?ejlpVEhTR1BCeFFoTlMvL2FTaTJoNElSUUdmZlQrcHNwNjFEdENBU3hpTnlx?=
 =?utf-8?B?R2lzWmdObFR0WitkeC91Y0xwRTJicmcranBPam5GQVRvQytNeHRlSk1IMHFa?=
 =?utf-8?B?NGJRK3JpRDlIbm13ZVMxR0J5NjQvQnErUHBZaEtudjdISEpwMC9MQmtnN3Zq?=
 =?utf-8?B?ZEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 60131290-5a6c-4f55-980e-08da8a0ae695
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 22:07:45.1559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mT/mjjRZ6xQivOtQaLcwZqPhYVNVXkQ5bjmxF14qgeWqT3nwkjphVXtooEAcSC6/fYrLoPdDGzt0zR6ik7pb22SWhBoZ8TCZo9O9p68d/Kg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0062
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/25/2022 11:56 PM, Li Zhong wrote:

nit: Could you mention the driver name in the commit title

e.g.
e1000e: check return value of e1e_rphy()

Thanks,
Tony

> e1e_rphy() could return error value, which needs to be checked and
> reported for debugging and diagnose.
> 
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> ---
>   drivers/net/ethernet/intel/e1000e/phy.c | 20 +++++++++++++++++---
>   1 file changed, 17 insertions(+), 3 deletions(-)