Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <Yw00w6XRcq7B6ub6@work> <202208291506.869166F4CE@keescook>
In-Reply-To: <202208291506.869166F4CE@keescook>
From:   Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Date:   Tue, 30 Aug 2022 10:15:00 +0900
Message-ID: <CAMZ6RqJzdrjTR6jDmi4qXwt+YZjwD-5M7LLjaiU5z0xu2tHWXg@mail.gmail.com>
Subject: Re: [PATCH][next] can: etas_es58x: Replace zero-length array with
 DECLARE_FLEX_ARRAY() helper
To:     Kees Cook <keescook@chromium.org>
Cc:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue. 30 Aug. 2022 at 07:15, Kees Cook <keescook@chromium.org> wrote:
> On Mon, Aug 29, 2022 at 04:50:59PM -0500, Gustavo A. R. Silva wrote:
> > Zero-length arrays are deprecated and we are moving towards adopting
> > C99 flexible-array members, instead. So, replace zero-length array
> > declaration in union es58x_urb_cmd with the new DECLARE_FLEX_ARRAY()
> > helper macro.
> >
> > This helper allows for a flexible-array member in a union.
> >
> > Link: https://github.com/KSPP/linux/issues/193
> > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>

Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>


Yours sincerely,
Vincent Mailhol