Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 10:47:21 +0900
From:   Sergey Senozhatsky <senozhatsky@chromium.org>
To:     Kent Overstreet <kent.overstreet@linux.dev>
Cc:     linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH 1/2] lib/test_printf.c: Add ip6 tests
Message-ID: <Yw1sKTOEs1Nrdb2S@google.com>
References: <20220830003119.1793219-1-kent.overstreet@linux.dev>
 <20220830003119.1793219-2-kent.overstreet@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220830003119.1793219-2-kent.overstreet@linux.dev>
Precedence: bulk

On (22/08/29 20:31), Kent Overstreet wrote:
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 4bd15a593f..6a56dbf076 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -18,6 +18,7 @@
>  #include <linux/dcache.h>
>  #include <linux/socket.h>
>  #include <linux/in.h>
> +#include <linux/in6.h>
>  
>  #include <linux/gfp.h>
>  #include <linux/mm.h>
> @@ -61,6 +62,9 @@ do_test(int bufsize, const char *expect, int elen,
>  		pr_warn("vsnprintf(buf, %d, \"%s\", ...) returned %d, expected %d\n",
>  			bufsize, fmt, ret, elen);
>  		return 1;
> +		pr_warn("vsnprintf(buf, %d, \"%s\", ...) returned %d, expected %d (%s != %s)\n",
> +			bufsize, fmt, ret, elen, test_buffer, expect);
> +		return 1;
>  	}

I assume you intended to replace first pr_warn() with the second one?