Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3774521rwe; Mon, 29 Aug 2022 20:31:20 -0700 (PDT) X-Google-Smtp-Source: AA6agR55lATlR1IQPftamiXR/wCANaYpxHPBoJkgxW7iGb8bXpByvCRY5BNzel93MGLFgXeNbi/7 X-Received: by 2002:a63:154b:0:b0:42c:60ce:8bd3 with SMTP id 11-20020a63154b000000b0042c60ce8bd3mr3824887pgv.372.1661830280048; Mon, 29 Aug 2022 20:31:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661830280; cv=none; d=google.com; s=arc-20160816; b=Fkk/G2SieinGJVyvDmtXBFKWLRiMwXDzSi7ThUWeFDYmLNqSo4FtV3idty7fcFSdw1 S+JzqcOYk7Y4mr87m5Zxi+sWqe/h0UH8sfcTGipfIdEvo/aV9QQgmm13A+RLn8ipkx9q 6WUSpGJYQa1AswqivwTqILrT4BUs9rgOXnBqt4ciiSi4Fgvw58tS5nRGCsyUqd7Fj7S6 duP+90sEseIjX2ai1FQ+wSZbTiqzeDFK80vjK5MHyC9PvCcdtq2zuKOQ9QZwqJCQyPPe cewj93TBalxSK28JYPfbVfmLFHpmSBgHv2qp+q9ad70i392FYqzI/kEX8NfBldxbdEk1 0I2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Sj2YAf+jcJpwZgorIhbu6IO4GDMZ2Kf9QmWmBPLXWvU=; b=OTjADNduRPnQFANg9hcYHW89LExNRr4bjtEqts/x9gR6Et+MDpOr8am3QXRETJE6vK 67jXsaeHuxOFGmsFD3Qp1FdgtBOCILMgLB1iMgfcGEN3XjOQWRSi4NOpxwsYUCzgFbjS SJWNPuofmQlcS+beQsTC1/unIjVAeyTrmIEfTO8PmpD8w6T+Gz9Fag9+CzUmycxkF0aO PGwWabO7CalcUPUgaIPr+xdXZQnk21ZrBi0sS4dpgk4WAI84JwpRlGFUTO0j3PSD0mU9 ucQ/Fnn82EOH75lNIiObinbglI0otoRCQ2OUT5hjh7v435yILJmLNf29tn/s6PxNylq7 cwMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=kSS0ivJZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f21-20020a056a00239500b005108171fe28si11448828pfc.162.2022.08.29.20.31.08; Mon, 29 Aug 2022 20:31:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=kSS0ivJZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbiH3D0c (ORCPT + 99 others); Mon, 29 Aug 2022 23:26:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229950AbiH3D02 (ORCPT ); Mon, 29 Aug 2022 23:26:28 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0341D86FC5 for ; Mon, 29 Aug 2022 20:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Sj2YAf+jcJpwZgorIhbu6IO4GDMZ2Kf9QmWmBPLXWvU=; b=kSS0ivJZA881DO1pPuT5Jep76P EKfzIVdydNx9TKycdzueqIPeCY0HoFzlgRsNay+JdDbP6aJR9v6uZRcrHYsL/tGbgzlOBbIWQp0mr p3vq0+rO67wFe3vR5/P8o75ACPROvcJh6G/vVmldTrPI8muBkZK3tyrDE2w232PN4adJC9oDtpE+6 rJ2hh9pTqRjpTxTH9zYRfKO9L0prazTDkP9iZXlscM5s9RfjJu4WMzzrocBq5GUDQTcZVOfbTHPaB MvOKYqDkqbDfQ5pKDo+NxdR7VoZqFWGN9ebgS0H67O7L656skRPc650HDxz77sSloGFJkgAT/wr7M CEJP/64g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSrtI-003dkn-T1; Tue, 30 Aug 2022 03:26:16 +0000 Date: Tue, 30 Aug 2022 04:26:16 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, vbabka@suse.cz, william.kucharski@oracle.com, dhowells@redhat.com, peterx@redhat.com, arnd@arndb.de, ccross@google.com, hughd@google.com, ebiederm@xmission.com Subject: Re: [PATCH 5/7] mm/hugetlb: convert hugetlb_delete_from_page_cache() to use folios Message-ID: References: <20220829230014.384722-1-sidhartha.kumar@oracle.com> <20220829230014.384722-6-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829230014.384722-6-sidhartha.kumar@oracle.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2022 at 04:00:12PM -0700, Sidhartha Kumar wrote: > static void hugetlb_delete_from_page_cache(struct page *page) > { > - ClearPageDirty(page); > - ClearPageUptodate(page); > - delete_from_page_cache(page); > + folio_clear_dirty(folio); > + folio_clear_uptodate(folio); > + filemap_remove_folio(folio); > } Did you send the right version of this patch? It doesn't look like it'll compile.