Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3835366rwe; Mon, 29 Aug 2022 22:24:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR6sCbSdLd0jg9f2rEHKJhUad3MYf7uhUk/vbKLNtoNFQCgxE2jRYC2wQKaWEVhxKbcChxY9 X-Received: by 2002:a17:90a:c782:b0:1f7:a4ed:11a1 with SMTP id gn2-20020a17090ac78200b001f7a4ed11a1mr22317931pjb.12.1661837072224; Mon, 29 Aug 2022 22:24:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661837072; cv=none; d=google.com; s=arc-20160816; b=qtOB7j+e/Uvvypq//6XFVYOJTXZNX6m3eyQGNNfS2zNV3GAls+sJ/7cOgUk216Ktsd X8FmdKeCCrqY8f4NdTA3hkZr8Lgcs/258SUnJssQGtWzGj9FEWNEVN5kYdn8TCstwkc5 1f0tb1NSb41VhXMg0rrZVsuYzi+cT06FU6NR0EtoDdd9UZRlCUw+6XouEXb3lPPLT0IF BFMNz+ANXKi+D7/RVVh/byTG4KVu1YJH88Dv1GpbvjFp/B0VZCIaha3qpge727SrC7iy Zh4yRSIauCgkvb3Ov7MrX5haYYlAM8yuCKd54plRxl/byevBT6qDZJRbzL3lErB7EEN2 AZnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=I6WHeUetxkndWUeAWsbD2ot1w3EtSeROzqEICjVikAY=; b=0Yzm+0DsmtmK3jKdKl9FHU5uxgwGmNfygNOjU+lmBfJCsJm4DuuGusOQJLFQ1Ml0W9 eCjKQfcIvqB6qLBbAKkMFL/COm1QawVaPzemz19W4CtaCt17uvUPYthyYQNnnrSoaXAz TU0WnbXNRv26YEk3qqIuSYfnIsgsfT42NDECO5vV34pqvQ2wOVCVeQ3v4GdqlnQK+w8T hI1uasWDfhLP+23HtLbPoU3kvMfFdCWEoFeAMq/b989WpYGCoLwYA71DgWuqX6gbfyKR BQ9Z5ve3DlSrzXZw7rtiRAa1swrShLVO85NvPom6zjY6uP/jWQ7AV6Ihk/jI+cqy+HXm 3LYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k18-20020a170902ba9200b00172be58c758si10104029pls.48.2022.08.29.22.24.20; Mon, 29 Aug 2022 22:24:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbiH3FGM (ORCPT + 99 others); Tue, 30 Aug 2022 01:06:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbiH3FGK (ORCPT ); Tue, 30 Aug 2022 01:06:10 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 160D26172C for ; Mon, 29 Aug 2022 22:06:04 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id B25A868AA6; Tue, 30 Aug 2022 07:05:59 +0200 (CEST) Date: Tue, 30 Aug 2022 07:05:59 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH -next v4 1/6] Revert "frontswap: remove support for multiple ops" Message-ID: <20220830050559.GA23877@lst.de> References: <20220829132302.3367054-1-liushixin2@huawei.com> <20220829132302.3367054-2-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829132302.3367054-2-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2022 at 09:22:57PM +0800, Liu Shixin wrote: > This reverts commit 1da0d94a3ec8c5f3793b7be8538b55e60ebeefe3. Err, no, this is a way to big hammer and going in the wrong way. If we can't have a sane way to fix it, the fix is just to remove the now rather pointless fontswap abstraction entirely. I'm on vacation this week, but I'll look into it ASAP once back.