Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <72631035-58a6-23b5-1f7e-f1643b120432@amlogic.com>
Date:   Tue, 30 Aug 2022 14:05:11 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH V3 2/6] arm64: dts: meson: add S4 Soc PLL clock controller
 in DT
Content-Language: en-US
To:     Jerome Brunet <jbrunet@baylibre.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <linux-clk@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-amlogic@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
References: <20220805085716.5635-1-yu.tu@amlogic.com>
 <20220805085716.5635-3-yu.tu@amlogic.com>
 <19654574-bdc0-9fa5-6465-fc88b20e20c5@linaro.org>
 <c223a85a-b76e-0e82-9a8c-6b60588dc03a@amlogic.com>
 <1jmtccz0f4.fsf@starbuckisacylon.baylibre.com>
 <edc9b0bd-6c69-0562-05ca-db0496897cf1@amlogic.com>
 <1j1qszv0wa.fsf@starbuckisacylon.baylibre.com>
From:   Yu Tu <yu.tu@amlogic.com>
In-Reply-To: <1j1qszv0wa.fsf@starbuckisacylon.baylibre.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/8/29 17:43, Jerome Brunet wrote:
> [ EXTERNAL EMAIL ]
> 
> 
> On Mon 15 Aug 2022 at 14:17, Yu Tu <yu.tu@amlogic.com> wrote:
> 
>> Hi Jerome，
>>
>> On 2022/8/10 21:32, Jerome Brunet wrote:
>>> [ EXTERNAL EMAIL ]
>>> On Fri 05 Aug 2022 at 17:39, Yu Tu <yu.tu@amlogic.com> wrote:
>>>
>>>> Hi Krzysztof,
>>>>       Thank you for your reply.
>>>>
>>>> On 2022/8/5 17:16, Krzysztof Kozlowski wrote:
>>>>> [ EXTERNAL EMAIL ]
>>>>> On 05/08/2022 10:57, Yu Tu wrote:
>>>>>> Added information about the S4 SOC PLL Clock controller in DT.
>>>>>>
>>>>>> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
>>>>>> ---
>>>>>>     arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 8 ++++++++
>>>>>>     1 file changed, 8 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>>>>>> index ff213618a598..a816b1f7694b 100644
>>>>>> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>>>>>> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>>>>>> @@ -92,6 +92,14 @@ apb4: apb4@fe000000 {
>>>>>>     			#size-cells = <2>;
>>>>>>     			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>>>>>>     +			clkc_pll: pll-clock-controller@8000 {
>>>>> Node names should be generic - clock-controller.
>>>>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>>>>>
>>>> I will change to clkc_pll: clock-controller@8000, in next version.
>>> Same comment applies to the binding doc.
>> OKay.
>>> Also it would be nice to split this in two series.
>>> Bindings and drivers in one, arm64 dt in the other. These changes goes
>>> in through different trees.
>> At present, Bindings, DTS and drivers are three series. Do you mean to put
>> Bindings and drivers together? If so, checkpatch.pl will report a warning.
> 
> Yes because patches are not in yet so there is a good reason to ignore
> the warning. Warning will never show up on the actual tree if the
> patches are correctly ordered.

I think Binding, DTS and drivers use three series and you said two 
series is not a big problem. Three series are recommended for 
checkpatch.pl, I think it should be easy for that to separate and merge。

I've sent it to V4. Please look at V4 and give some comments.

> 
>>
>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>> .
>>> .
> 
> .