Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "S.J. Wang" <shengjiu.wang@nxp.com>
To:     Chancel Liu <chancel.liu@nxp.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "Xiubo.Lee@gmail.com" <Xiubo.Lee@gmail.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "nicoleotsuka@gmail.com" <nicoleotsuka@gmail.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: [PATCH 1/5] ASoC: dt-bindings: fsl_rpmsg: Add a property to
 assign platform driver name
Thread-Topic: [PATCH 1/5] ASoC: dt-bindings: fsl_rpmsg: Add a property to
 assign platform driver name
Thread-Index: AQHYu3zGgKrj+wHzzkWzPDbVUiF1Eq3G++vw
Date:   Tue, 30 Aug 2022 06:28:26 +0000
Message-ID: <GV1PR04MB91839C3B94A89F235133374AE3799@GV1PR04MB9183.eurprd04.prod.outlook.com>
References: <20220829075144.2405000-1-chancel.liu@nxp.com>
 <20220829075144.2405000-2-chancel.liu@nxp.com>
In-Reply-To: <20220829075144.2405000-2-chancel.liu@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XJC+CgdAXwMPKFJh07LagO4mqvZu3e05fn3U5yobvnLaHL+aeaWX99kcA0tC?=
 =?us-ascii?Q?UpYWxnGB6WkYQikPsvHm3YiTO2/PTO4H/0v6Y5sCYAmXDGECZWNtGMVvCBrZ?=
 =?us-ascii?Q?6q2bM6+4V9R1GCqDx3Ont4VWtO8/XbF8uWkRtfoJnqkZpVXP47pGCJOFR3MS?=
 =?us-ascii?Q?4F4PUEAMv10qacSkTG1q5NEN3c7IdCj3FuIXByctWfo2sSE+Hg/U7HB6dZIW?=
 =?us-ascii?Q?mu6TYgf84TO4QF9HoKulGBvx3S4S7odcT9ApT2JJbfdBiaF0vlG2GF+R5CEr?=
 =?us-ascii?Q?hb1NMK4cQcxSM1ua9vDd20BAh66eD+isRTXfH5fDWgAtyZB5INZktHDw+rpj?=
 =?us-ascii?Q?nmyWJZ4G7xwNpaaHsgpWSsk8m6ywLh2s3acBpP7ayzLdKdYn/mp33L7hGviU?=
 =?us-ascii?Q?2V+Fe8WdEogomgddhfYlIzpcq2kpfKutIuNQpkhYlItW9ac9CM58CA7sanBw?=
 =?us-ascii?Q?qGbLG+FgRA3MM1bTzGtZdka+9gOBUCYoMNqvqjtX6B33KTDjfm03HEF7FJSF?=
 =?us-ascii?Q?zPbi6XPdV1LMf6f52cpa6aGr11EXcap3N7kXQ7Zf2n7TVjUO1mbw8qh0WWql?=
 =?us-ascii?Q?M8ybMfjpS7OLB/SczC66K3mp+FD/ogp1iIyiF7LouMlJMR4W5x3V9pp6LYTK?=
 =?us-ascii?Q?jXkEuJ4njJkaTHq3To1jf9Yz+NNmfJX9jpx/jtnsc4WNznprjQ4eJ/sI+JHW?=
 =?us-ascii?Q?o6O+vveloAQ6fMrfqehKDebzcj8CG1yx8wlmedizF5UQDe7LCCX1ThsXR9Ky?=
 =?us-ascii?Q?hNd0RYgGfJrp4DuFod7WDfgnYczHlOsW+nrI9MUparDU4en+7iGd7bM0TSvC?=
 =?us-ascii?Q?mRYpoemviRf9jjGrrY9EoYFUoI+qFAPXpul0VGla1SMVUOFzFaIJ97ohnoM4?=
 =?us-ascii?Q?JOlmqrkM4IVImgm9ddLTKx1B8cith1ImQSkQn7YjcTQDHF6l0GqFlutEpSO0?=
 =?us-ascii?Q?xN4U+7uIIOUUOH73XRjK5gO0fbvGw8Lc0eMujbBeNjxYr+F+dnH7fmSgwSEt?=
 =?us-ascii?Q?TPJ974f+lcG5lSXwrbjPiIERpLZIJp56ND4NvjtihtQIqR+VRduiBZw0dykd?=
 =?us-ascii?Q?eA/5t8yaVK4L8+bTMe62Iscviq4ZpYl5DV85WqG5uWsYGXEz5KonVe0RT8WV?=
 =?us-ascii?Q?10uMNvlYCMOgcz8lEKUqK4fcFwurIWZ9Nh/RREdUuJF42I1Fhft9BROx+yHo?=
 =?us-ascii?Q?jRwVB67zmwbF7xDLWAyQcqEdQjojvEXTI15YoS8EyxLRCpyWFau+MR86NwXy?=
 =?us-ascii?Q?c2X6/dGCYP1dDvcbpERIxNlds3DMsXthPYChusXNDH2VsD5CY0MGe6YDr02S?=
 =?us-ascii?Q?EU91xUrXO112mNm3UUXlQUmLPfiVQcZdJUDJQqvN83Yhh8qoNA3zF5Nqe7EW?=
 =?us-ascii?Q?QDNt28B5Lof74Fm8+ko6/9e0Uu17IM7M+5XjnYXdF1v06hD3HNpCOOcIkYq/?=
 =?us-ascii?Q?mddR6Ywe63JzbqHq2c+wWi95DynampDJ9W5pw5dDhLgAC+kWmjcTGrjYqjOk?=
 =?us-ascii?Q?mzr7oEmjyo/3B76qKhE9wyxCGOLDnNew2/C45W3iidC0bnRfN217ZgqODG+z?=
 =?us-ascii?Q?bNbE4mMX2m6xv5W0wuBcRcFWuozft+qlZgeX5NQR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9183.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b52a81c-075d-4ae9-35c8-08da8a50d919
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2022 06:28:27.0358
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B8xQaS0aeD9TwfjiPZ6SjunRO644zBsCzlXK9lHj9w4QqOvv7O4UIqioX8vmh8bP4iNvp52a7oFH0HIW+WrZPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3098
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Add a string property to assign ASoC platform driver name. It also repres=
ents
> the rpmsg channel this sound card sits on. This property can be omitted i=
f
> there is only one sound card and it sits on "rpmsg-audio-channel".
>=20
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
>  .../devicetree/bindings/sound/fsl,rpmsg.yaml  | 34 +++++++++++++++++--
>  1 file changed, 32 insertions(+), 2 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml
> b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml
> index d370c98a62c7..35e3cb9f768b 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml
> @@ -11,8 +11,11 @@ maintainers:
>=20
>  description: |
>    fsl_rpmsg is a virtual audio device. Mapping to real hardware devices
> -  are SAI, DMA controlled by Cortex M core. What we see from Linux
> -  side is a device which provides audio service by rpmsg channel.
> +  are SAI, MICFIL, DMA controlled by Cortex M core. What we see from
> + Linux side is a device which provides audio service by rpmsg channel.
> +  We can create different sound cards which access different hardwares
> + such as SAI, MICFIL, .etc through building rpmsg channels between
> + Cortex-A and Cortex-M.
>=20
>  properties:
>    compatible:
> @@ -85,6 +88,14 @@ properties:
>        This is a boolean property. If present, the receiving function
>        will be enabled.
>=20
> +  fsl,platform:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description: |
> +      A string property to assign ASoC platform driver name. It also
> +      represents the rpmsg channel this sound card sits on. This propert=
y
> +      can be omitted if there is only one sound card and it sits on
> +      "rpmsg-audio-channel".

Please add enum to list supported strings.

Best regards
Wang Shengjiu
> +
>  required:
>    - compatible
>    - model
> @@ -107,3 +118,22 @@ examples:
>                   <&clk IMX8MN_AUDIO_PLL2_OUT>;
>          clock-names =3D "ipg", "mclk", "dma", "pll8k", "pll11k";
>      };
> +
> +  - |
> +    #include <dt-bindings/clock/imx8mm-clock.h>
> +
> +    rpmsg_micfil: rpmsg_micfil {
> +        compatible =3D "fsl,imx8mm-rpmsg-audio";
> +        model =3D "micfil-audio";
> +        fsl,platform =3D "rpmsg-micfil-channel";
> +        fsl,enable-lpa;
> +        fsl,rpmsg-in;
> +        clocks =3D <&clk IMX8MM_CLK_PDM_IPG>,
> +                 <&clk IMX8MM_CLK_PDM_ROOT>,
> +                 <&clk IMX8MM_CLK_SDMA3_ROOT>,
> +                 <&clk IMX8MM_AUDIO_PLL1_OUT>,
> +                 <&clk IMX8MM_AUDIO_PLL2_OUT>;
> +        clock-names =3D "ipg", "mclk", "dma", "pll8k", "pll11k";
> +    };
> +
> +...
> --
> 2.25.1