Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "S.J. Wang" <shengjiu.wang@nxp.com>
To:     Chancel Liu <chancel.liu@nxp.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "Xiubo.Lee@gmail.com" <Xiubo.Lee@gmail.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "nicoleotsuka@gmail.com" <nicoleotsuka@gmail.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: [PATCH 3/5] ASoC: imx-pcm-rpmsg: Register different platform
 drivers
Thread-Topic: [PATCH 3/5] ASoC: imx-pcm-rpmsg: Register different platform
 drivers
Thread-Index: AQHYu3zMYmOVvaPO90OGp9+KALSMdq3G/IvA
Date:   Tue, 30 Aug 2022 06:31:27 +0000
Message-ID: <GV1PR04MB91831EF183F0D0E6E9BBD9E9E3799@GV1PR04MB9183.eurprd04.prod.outlook.com>
References: <20220829075144.2405000-1-chancel.liu@nxp.com>
 <20220829075144.2405000-4-chancel.liu@nxp.com>
In-Reply-To: <20220829075144.2405000-4-chancel.liu@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JgPjEXyfkwNiYPny0Ak2giJX+K9X89haSEnSdfDG2miCpuDusvUz50wFRHiR?=
 =?us-ascii?Q?jS09GEeRDCglumeNXLNN6mh54QRmjHRyLVsceTGQtMdL27WBI6q9qY/b2x2s?=
 =?us-ascii?Q?AYBdMY1yo907M+xw7wX2jNDZkV1TqFOA0toTnb0oc3HazCN6vlNZ1t6EIpXc?=
 =?us-ascii?Q?j6dOIgDLxj66DcdQsKdfxWp4tsq22YupagBKr96waZky3LgRirGdBuo2E0Fn?=
 =?us-ascii?Q?UXjkbZJP/jbu5Q3AMnd21XuexYz7cDLsXUMf8HUtm+ej0grF8f6UWajgDAFK?=
 =?us-ascii?Q?VnICVfp08mBtWke2D4cr6dKxg74mOkOPIdeL6fOrHsxKRuxnUu8JPCnSUZfg?=
 =?us-ascii?Q?uV9dKbbeOK3s8HPFoQZLJlnGwAkkMBbyQbOA6ito35swcoVdAeoY6GI+JrFx?=
 =?us-ascii?Q?1pNgo+ktxa0RBZ4SZzbLrC4j/HI/3/lrKPZLH/AMc/0BR1SpYCzRjnG3Fd37?=
 =?us-ascii?Q?VLN5Or2eeS2SsaSeMgDBgNoKYnnUqxGgGBR7UBBOl7HD8f67wwni93ANHv5B?=
 =?us-ascii?Q?SINhYO5BpYeQVVf87spqw9cQChA5ggD1gCTB3rb3CmDeyYDOqGm6acPvesdR?=
 =?us-ascii?Q?LKzC7rB+a1DaiGw2CbHMz4Zx4hodvTZwX3w2X7yNrAYNSkNJU0ec8wetPn0h?=
 =?us-ascii?Q?2t9cwmMdyV0j1kWCwbfYvzqskhfRMfB8oUtJyZZou0wAAJGbN+6B8LY+cteR?=
 =?us-ascii?Q?dIhNR0ihS0xH/ttWPphOFa5DAJluFEgEE7ZKf+NKomrxg0rAo6t3lZHQ2HUI?=
 =?us-ascii?Q?UTVcpNd3gl75C8odwPpqHBfYxiFENAjuZ6uM6DFj2GM7vxb5Mwnh6KryGG0Y?=
 =?us-ascii?Q?qRFF00+Y71MDPZNK9IkkkSP2sY4l4+D7RvdpYznkmHl+HtceD6TgS/7vZcGD?=
 =?us-ascii?Q?OmAsuf9S64tKwCRllqrX6r9/je4yxmFVN4LFG/nnUVIoXYFf+Bd1kRvZU1m1?=
 =?us-ascii?Q?4hWO6x3n9ceBthAGTo0R43QDNFJbma3yAg1UjlEJBqbW9QJorZHzTJY6v+Gz?=
 =?us-ascii?Q?oNU/xVa5e2EELXs6T3+DmkYHxULL/89/otOuSUbx49Zo8xuCVjdQh2MB47DY?=
 =?us-ascii?Q?/GxNpgKnf6fUWlzpT4oCUVnjTzWkKBTh2FXzDE7RLhDhB4MdzhkiJgXDC+Ba?=
 =?us-ascii?Q?GuVwBqLoCEcW4MohRB1Wgl2QUikxmhXC0XMmJNazHqBaN6KOF3dS5Z8L6ppS?=
 =?us-ascii?Q?K8Hy597vfOi2qM+v8lAESdcSBXt02nFBTGTFzwHy7Qp/08PCf+ESZok3zYLi?=
 =?us-ascii?Q?8e8JL8dYUzkaRzZQI8IcpFzOqQKt5pCJEYMldLTxRiFxGXXnFZTn3MgrGEWK?=
 =?us-ascii?Q?Sm95BHEn6z4TpDroFTTCR8EQ2c0YmzcNgYMUYORKauiyl09v4Fo4l25rGRbo?=
 =?us-ascii?Q?8i0441I1wpbg5QdpGosueDIfX4Jj0L0KsEd+/wA5oa+mU3mu1XnpcQE3iRiV?=
 =?us-ascii?Q?6e+okwl2zbBvmvqgymt3KQOPJqO9pOyKW7aFIlylMxBcUlvMaq9SDxluAZzJ?=
 =?us-ascii?Q?3A6zlm7NwTBvAAZXPskSo20GGvNKy/rCahWR9xeXef0jgoWhVOqCj063FCUt?=
 =?us-ascii?Q?VPlUjtjZBsoYyGjf09l3LMjyCgYQnvsEMsn7n7FJ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9183.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ac7239c-22ae-4bbe-6d4a-08da8a5144c1
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2022 06:31:27.6545
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OMFquitHciJcD1/o+xGZuiwGbI3+yMjot0X5rrpTBYQeyMJHyZK9hV52b1G5peKAciLCf9typo8dCWvNZXjZfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB2953
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> This patch can register different ASoC platform drivers in reference to
> "fsl,platform" property of the corresponding node in dts. So sound cards
> based on different rpmsg channels can link to their respective platform
> drivers.
>=20
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
>  sound/soc/fsl/imx-pcm-rpmsg.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>=20
> diff --git a/sound/soc/fsl/imx-pcm-rpmsg.c b/sound/soc/fsl/imx-pcm-
> rpmsg.c index 35049043e532..2f310994f7ee 100644
> --- a/sound/soc/fsl/imx-pcm-rpmsg.c
> +++ b/sound/soc/fsl/imx-pcm-rpmsg.c
> @@ -178,7 +178,7 @@ static int imx_rpmsg_pcm_hw_params(struct
> snd_soc_component *component,
>  		msg->s_msg.param.channels =3D RPMSG_CH_STEREO;
>  		break;
>  	default:
> -		ret =3D -EINVAL;
> +		msg->s_msg.param.channels =3D params_channels(params);

Please use separate commit for this change, I think the fsl_rpmsg_dai. chan=
nels_max
Should be updated also?

Best regards
Wang shengjiug

>  		break;
>  	}
>=20
> @@ -684,7 +684,7 @@ static int imx_rpmsg_pcm_probe(struct
> platform_device *pdev)
>  	info->rpdev =3D container_of(pdev->dev.parent, struct rpmsg_device,
> dev);
>  	info->dev =3D &pdev->dev;
>  	/* Setup work queue */
> -	info->rpmsg_wq =3D alloc_ordered_workqueue("rpmsg_audio",
> +	info->rpmsg_wq =3D alloc_ordered_workqueue(info->rpdev->id.name,
>  						 WQ_HIGHPRI |
>  						 WQ_UNBOUND |
>  						 WQ_FREEZABLE);
> @@ -723,11 +723,15 @@ static int imx_rpmsg_pcm_probe(struct
> platform_device *pdev)
>  	if (ret)
>  		goto fail;
>=20
> -	component =3D snd_soc_lookup_component(&pdev->dev,
> IMX_PCM_DRV_NAME);
> +	component =3D snd_soc_lookup_component(&pdev->dev, NULL);
>  	if (!component) {
>  		ret =3D -EINVAL;
>  		goto fail;
>  	}
> +
> +	/* platform component name is used by machine driver to link with
> */
> +	component->name =3D info->rpdev->id.name;
> +
>  #ifdef CONFIG_DEBUG_FS
>  	component->debugfs_prefix =3D "rpmsg";
>  #endif
> --
> 2.25.1