Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8741636-ea2e-4c5f-4dc1-9a5dec4dafa1@linux.intel.com>
Date:   Tue, 30 Aug 2022 15:46:55 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Cc:     baolu.lu@linux.intel.com, Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH v12 13/17] iommu/sva: Refactoring
 iommu_sva_bind/unbind_device()
Content-Language: en-US
To:     Yuan Can <yuancan@huawei.com>, Joerg Roedel <joro@8bytes.org>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Vinod Koul <vkoul@kernel.org>
References: <20220826121141.50743-1-baolu.lu@linux.intel.com>
 <20220826121141.50743-14-baolu.lu@linux.intel.com>
 <47879368-fb4e-79aa-35f9-018d871f013c@huawei.com>
 <96ac1693-d87f-250d-c897-c79f13ed4c0a@linux.intel.com>
From:   Baolu Lu <baolu.lu@linux.intel.com>
In-Reply-To: <96ac1693-d87f-250d-c897-c79f13ed4c0a@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2022/8/30 15:45, Baolu Lu wrote:
> On 2022/8/30 15:30, Yuan Can wrote:
>>
>> 在 2022/8/26 20:11, Lu Baolu 写道:
>>> The existing iommu SVA interfaces are implemented by calling the SVA
>>> specific iommu ops provided by the IOMMU drivers. There's no need for
>>> any SVA specific ops in iommu_ops vector anymore as we can achieve
>>> this through the generic attach/detach_dev_pasid domain ops.
>>>
>>> This refactors the IOMMU SVA interfaces implementation by using the
>>> iommu_detach/detach_device_pasid interfaces and align them with the
>>
>> Did you mean using the iommu_attach/detach_device_pasid interfaces here?
> 
> The device driver oriented SVA interfaces keep consistent as before.
> Here we only refactor the IOMMU internal implementation.

Oh! A typo in the commit message, right? Thanks and I will fix it.

Best regards,
baolu