Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3937328rwe; Tue, 30 Aug 2022 01:13:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR7+EosP+L1q+GKKKjgsODXPk1qgaEYdnC0BDhCxq8WhNIqhcaAAMQYzIWPl4XZkCN4ftdqJ X-Received: by 2002:a65:5ac4:0:b0:41b:af7f:125 with SMTP id d4-20020a655ac4000000b0041baf7f0125mr17151374pgt.224.1661847221092; Tue, 30 Aug 2022 01:13:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661847221; cv=none; d=google.com; s=arc-20160816; b=Vca/fSdxEgOwrNiiqsKLO+Bqkp3y88Q3wi+mxdOpLaznPQfe3GHJkhrN/PGbGu0SoK aLypsRwjgVJL1n7+Jyw9cOkLMKeX1uqK4+ZKz69AmvWOilbjsqR15BcCNkgafpjmkQ2N aZGAKU6xKU3vyPWX2vAztNfB8NcozwMYZsSIaGXe6JvXKFfcpDikVN/6xv0+SS/QNFD4 xtbNRHh4AXhx0nOXUJvJesXYGNKK1Kc3l2M4Ub3Fixbcx/UCmHhdv7oXC1uDSX0Wg/rR 9iK4ZTZ931Jqr1Yq+0WAioUsqQWKgAgQjPBs5tdFB2Xc4UUo5mGidFcJDJ+0e/S8IvWO SIlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dX/vDKI40058jdDafjlLeDR22H0oqmaIcL6uvjCb6dc=; b=qwBnTi9HhaEeMakdTwajXV05CN+v2rDKnLo9U3oCEXxmVlDM94KC18Nb4ET58o0No9 5a3FI5Et5toaKlCfYy/tnmdLmsHl9c/eNjwpfTXp3ET5WA0PG19NJFwFpEJ5xCZfFapz qJDnrWmN60q25EsPtcInIVI/uvGUxJDOfK3PROo0FC2d+9m9LghOhpHRIo4BHMOMQUtG oJDK7HZWjICIeM0SzPaN/EYotjXD+0VGefHQ7OjtCN1+K28Gt1mim98SWWyvn72uIVoe FEkOL3bbfYLhaedPK7PfWL13S4CTeXd/gJJ8Tm2z8DFbqdSxaHyXcbJiWwE0HbVo054t MbQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tV6oBMpm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u2-20020a63d342000000b0042b9117ba6asi1495600pgi.746.2022.08.30.01.13.25; Tue, 30 Aug 2022 01:13:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tV6oBMpm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbiH3H6D (ORCPT + 99 others); Tue, 30 Aug 2022 03:58:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbiH3H6B (ORCPT ); Tue, 30 Aug 2022 03:58:01 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BE5BD11E2 for ; Tue, 30 Aug 2022 00:58:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BBA23B816CE for ; Tue, 30 Aug 2022 07:57:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B516C433D6; Tue, 30 Aug 2022 07:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661846278; bh=tMezW17H30QYH+rtqSZLpnK9Zmp87zjX0uCL3+xUkqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tV6oBMpm8Q7OvzGU0kdTL7C8kgKDOwa39BWo+lhO5mOdnUsOAVhk52V2fbzv24ZnQ +RnMsJ0TIPrf/uhtoyHS/EbpuMYrm9G5MwcYfWEoK3W+UHXmFclIvIvH8VMtQxhzy6 D513r5dPHqTXnSZhZPHRQBuoANbJdhdfgNmLG+nmUT9Uwl8YHhZp1QvKjgcybZ2cAw iwW4MVZBn9ND7Tp3nu2VWNfbvF96sNTvb2Djlg4eTm7Gp9GziKL6T6Kx6dqfgBTVmn ba4YAOPC7QMXH8xlJSCF0vjwNUF+cnkO+BgOSLIQyD/tFhh7eqM9/NcNK7nSZZI2Wj I1KlExypp76kQ== Date: Tue, 30 Aug 2022 09:57:52 +0200 From: Christian Brauner To: Carlos Llamas Cc: Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Suren Baghdasaryan , kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] binder: remove unused binder_alloc->buffer_free Message-ID: <20220830075752.6lueoqmaskhygb5z@wittgenstein> References: <20220829201254.1814484-1-cmllamas@google.com> <20220829201254.1814484-6-cmllamas@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220829201254.1814484-6-cmllamas@google.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2022 at 08:12:52PM +0000, Carlos Llamas wrote: > The ->buffer_free member was introduced in the first revision of the > driver under staging but it appears like it was never actually used > according to git's history. Remove it from binder_alloc. > > Signed-off-by: Carlos Llamas > --- Looks good, Reviewed-by: Christian Brauner (Microsoft)