Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <954cdab4-62d3-b413-f615-9c7b1563c1b1@huawei.com>
Date:   Tue, 30 Aug 2022 16:01:00 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH] cpufreq: bmips-cpufreq: Use module_init and add
 module_exit
To:     Viresh Kumar <viresh.kumar@linaro.org>
CC:     <mmayer@broadcom.com>, <rafael@kernel.org>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220826021845.2283648-1-chris.zjh@huawei.com>
 <20220830052922.aedexy7ovdus5pzk@vireshk-i7>
From:   "zhangjianhua (E)" <chris.zjh@huawei.com>
In-Reply-To: <20220830052922.aedexy7ovdus5pzk@vireshk-i7>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/8/30 13:29, Viresh Kumar 写道:
> On 26-08-22, 10:18, Zhang Jianhua wrote:
>> - Use module_init instead of device_initcall.
>> - Add a function for module_exit to unregister driver.
>>
>> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
>> ---
>>   drivers/cpufreq/bmips-cpufreq.c | 10 ++++++++--
>>   1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/bmips-cpufreq.c b/drivers/cpufreq/bmips-cpufreq.c
>> index f7c23fa468f0..21c0417c95e1 100644
>> --- a/drivers/cpufreq/bmips-cpufreq.c
>> +++ b/drivers/cpufreq/bmips-cpufreq.c
>> @@ -156,7 +156,7 @@ static struct cpufreq_driver bmips_cpufreq_driver = {
>>   	.name		= BMIPS_CPUFREQ_PREFIX,
>>   };
>>   
>> -static int __init bmips_cpufreq_probe(void)
>> +static int __init bmips_cpufreq_driver_init(void)
>>   {
>>   	struct cpufreq_compat *cc;
>>   	struct device_node *np;
>> @@ -176,7 +176,13 @@ static int __init bmips_cpufreq_probe(void)
>>   
>>   	return cpufreq_register_driver(&bmips_cpufreq_driver);
>>   }
>> -device_initcall(bmips_cpufreq_probe);
>> +module_init(bmips_cpufreq_driver_init);
>> +
>> +static void __exit bmips_cpufreq_driver_exit(void)
>> +{
>> +	cpufreq_unregister_driver(&bmips_cpufreq_driver);
>> +}
>> +module_exit(bmips_cpufreq_driver_exit)
> Semicolon ? Did you even compile this ? :)

Semicolon is not necessary for module_exit, and it can be compiled. I will send v2 patch to keep the format consistent, thanks.

>>   
>>   MODULE_AUTHOR("Markus Mayer <mmayer@broadcom.com>");
>>   MODULE_DESCRIPTION("CPUfreq driver for Broadcom BMIPS SoCs");
>> -- 
>> 2.31.0