Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220803151217.75962-1-ppbuk5246@gmail.com> <CAM7-yPTdihLsPjDKM-0OEszxNd8n0bgeRseiEkCsSZW-uuaRvw@mail.gmail.com>
 <Yw2+H9MNpf3Ve0eJ@MiWiFi-R3L-srv>
In-Reply-To: <Yw2+H9MNpf3Ve0eJ@MiWiFi-R3L-srv>
From:   Yun Levi <ppbuk5246@gmail.com>
Date:   Tue, 30 Aug 2022 17:30:29 +0900
Message-ID: <CAM7-yPRoBofD9+avRj1SH_GFogAnmJ7U8jJjbViH_hgOFBTX0w@mail.gmail.com>
Subject: Re: [PATCH-RESEND] arm64/kexec: Fix missing extra range for crashkres_low.
To:     Baoquan He <bhe@redhat.com>
Cc:     will@kernel.org, chenzhou10@huawei.com, nramas@linux.microsoft.com,
        thunder.leizhen@huawei.com, linux-arm-kernel@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kexec@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> Right, excluding crashkernel region may cause memory region splitting,
> so we need extra slot for that.
>
> Meanwhile, can you fix above code comment mess? Otherwise, this looks
> good to me.

Thanks! I'll remove the comment.

> Or we can add extra 2 slots like we do in x86, it just add another 16
> bytes temporarily.

Agree. I'll send the patch again by modifying nr_ranges' initialized value as 2.

Thanks!